golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-10-30 02:07:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

service/debugger: close executable file (#2976)

Browse Source 
Close executable file after we open it.
This commit is contained in:
Alessandro Arzilli
2022-04-26 23:32:22 +02:00
committed by GitHub
parent c120db3467
commit 7ab33ac92f
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
service/debugger/debugger_unix.go
View File

@ -28,16 +28,18 @@ func verifyBinaryFormat(exePath string) error {
} }
// check that the binary format is what we expect for the host system // check that the binary format is what we expect for the host system
var exe interface{ Close() error }
switch runtime.GOOS { switch runtime.GOOS {
case "darwin": case "darwin":
_, err = macho.NewFile(f) exe, err = macho.NewFile(f)
case "linux", "freebsd": case "linux", "freebsd":
_, err = elf.NewFile(f) exe, err = elf.NewFile(f)
default: default:
panic("attempting to open file Delve cannot parse") panic("attempting to open file Delve cannot parse")
} }
if err != nil { if err != nil {
return api.ErrNotExecutable return api.ErrNotExecutable
} }
exe.Close()
return nil return nil
} }

4
service/debugger/debugger_windows.go
View File

@ -35,8 +35,10 @@ func verifyBinaryFormat(exePath string) error {
} }
} }
if _, err = pe.NewFile(f); err != nil { exe, err := pe.NewFile(f)
if err != nil {
return api.ErrNotExecutable return api.ErrNotExecutable
} }
exe.Close()
return nil return nil
} }