From 6d88b525094d766e899e93ea44bf707767ab5705 Mon Sep 17 00:00:00 2001
From: Alessandro Arzilli <alessandro.arzilli@gmail.com>
Date: Mon, 24 Apr 2023 21:10:50 +0200
Subject: [PATCH] proc: disable flaky tests on windows/arm64 (#3328)

Disable some tests on windows/arm64 that are flaky.
---
 Documentation/backend_test_health.md | 3 ++-
 pkg/proc/proc_test.go                | 3 +++
 service/dap/server_test.go           | 3 +++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/backend_test_health.md b/Documentation/backend_test_health.md
index 4f16ef93..d8b08ee5 100644
--- a/Documentation/backend_test_health.md
+++ b/Documentation/backend_test_health.md
@@ -21,6 +21,7 @@ Tests skipped by each supported backend:
 	* 1 broken
 	* 3 see https://github.com/go-delve/delve/issues/2768
 	* 1 upstream issue
-* windows/arm64 skipped = 2
+* windows/arm64 skipped = 5
+	* 3 broken
 	* 1 broken - cgo stacktraces
 	* 1 broken - step concurrent
diff --git a/pkg/proc/proc_test.go b/pkg/proc/proc_test.go
index 274bc020..d6a88bfa 100644
--- a/pkg/proc/proc_test.go
+++ b/pkg/proc/proc_test.go
@@ -597,6 +597,7 @@ func TestNextGeneral(t *testing.T) {
 }
 
 func TestNextConcurrent(t *testing.T) {
+	skipOn(t, "broken", "windows", "arm64")
 	testcases := []nextTest{
 		{8, 9},
 		{9, 10},
@@ -632,6 +633,7 @@ func TestNextConcurrent(t *testing.T) {
 }
 
 func TestNextConcurrentVariant2(t *testing.T) {
+	skipOn(t, "broken", "windows", "arm64")
 	// Just like TestNextConcurrent but instead of removing the initial breakpoint we check that when it happens is for other goroutines
 	testcases := []nextTest{
 		{8, 9},
@@ -1513,6 +1515,7 @@ func TestBreakpointCounts(t *testing.T) {
 }
 
 func TestHardcodedBreakpointCounts(t *testing.T) {
+	skipOn(t, "broken", "windows", "arm64")
 	withTestProcess("hcbpcountstest", t, func(p *proc.Target, grp *proc.TargetGroup, fixture protest.Fixture) {
 		counts := map[int64]int{}
 		for {
diff --git a/service/dap/server_test.go b/service/dap/server_test.go
index 8b775487..cdd4fdc7 100644
--- a/service/dap/server_test.go
+++ b/service/dap/server_test.go
@@ -3432,6 +3432,9 @@ func TestHaltPreventsAutoResume(t *testing.T) {
 // goroutine is hit the correct number of times and log points set in the
 // children goroutines produce the correct number of output events.
 func TestConcurrentBreakpointsLogPoints(t *testing.T) {
+	if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
+		t.Skip("broken")
+	}
 	tests := []struct {
 		name        string
 		fixture     string