golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-11-02 12:59:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

pkg/proc: return better error attempting to call nonexistent function (#4062)

Browse Source 
Fixes #4051
This commit is contained in:
Derek Parker
2025-08-24 12:27:14 -07:00
committed by GitHub
parent af348314db
commit 6346593568
4 changed files with 108 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
pkg/proc/variables_test.go
View File

@ -1575,6 +1575,58 @@ func testCallFunctionIntl(t *testing.T, grp *proc.TargetGroup, p *proc.Target, t
}
}
func TestIssue4051(t *testing.T) {
protest.MustSupportFunctionCalls(t, testBackend)
protest.AllowRecording(t)
withTestProcess("issue4051", t, func(p *proc.Target, grp *proc.TargetGroup, fixture protest.Fixture) {
err := grp.Continue()
assertNoError(err, t, "initial continue to breakpoint failed")
err = proc.EvalExpressionWithCalls(grp, p.SelectedGoroutine(), `main.Hello("world")`, pnormalLoadConfig, true)
if err == nil {
t.Fatal("expected error, got nil")
}
expectedError := "package main has no function Hello"
if err.Error() != expectedError {
t.Fatalf("expected error %q, got %q", expectedError, err)
}
err = grp.Continue()
assertNoError(err, t, "initial continue to breakpoint failed")
err = proc.EvalExpressionWithCalls(grp, p.SelectedGoroutine(), `main.Hello("world")`, pnormalLoadConfig, true)
if err == nil {
t.Fatal("expected error, got nil")
}
expectedError = `expression "main.Hello" is not a function`
if err.Error() != expectedError {
t.Fatalf("expected error %q, got %q", expectedError, err)
}
v, err := evalVariableWithCfg(p, "main.Hello", pshortLoadConfig)
assertNoError(err, t, "eval of main.Hello returned an error")
assertVariable(t, v, varTest{"main.Hello", true, `"World"`, ``, `string`, nil})
v, err = evalVariableWithCfg(p, "os.a", pshortLoadConfig)
assertNoError(err, t, "eval of os.a returned an error")
assertVariable(t, v, varTest{"os.a", true, "1", ``, `int`, nil})
// TODO(deparker): we *should* get an error here, but the one we expect in this test
// is not the ideal error. We should really improve type checking in the evaluator.
v, err = evalVariableWithCfg(p, "main.f.func1.i", pshortLoadConfig)
expectedError = `main.f has no member func1`
if err.Error() != expectedError {
t.Fatalf("expected error %q, got %q", expectedError, err)
}
_, err = evalVariableWithCfg(p, "main.f.func1.somethingthatdoesntexist", pshortLoadConfig)
expectedError = `main.f has no member func1`
if err.Error() != expectedError {
t.Fatalf("expected error %q, got %q", expectedError, err)
}
})
}
func TestIssue1531(t *testing.T) {
// Go 1.12 introduced a change to the map representation where empty cells can be marked with 1 instead of just 0.
withTestProcess("issue1531", t, func(p *proc.Target, grp *proc.TargetGroup, fixture protest.Fixture) {