golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-10-30 02:07:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc: disable caching for variables with an extended location

Browse Source 
Our current frame caching strategy doesn't handle extended locations
expressions correctly, disable it on variables that don't have a simple
address.
This commit is contained in:
aarzilli
2018-01-27 16:50:18 +01:00
committed by Derek Parker
parent 03139e8f62
commit 62fe792bfd
3 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/proc/variables.go
View File

@ -1897,13 +1897,19 @@ func (scope *EvalScope) variablesByTag(tag dwarf.Tag, cfg *LoadConfig) ([]*Varia
sort.Stable(&variablesByDepth{vars, depths})
}
// prefetch the whole chunk of memory relative to these variables
// Prefetch the whole chunk of memory relative to these variables.
// Variables that are not stored contiguously in memory (i.e. the ones that
// read from a compositeMemory) will be ignored.
minaddr := vars[0].Addr
var maxaddr uintptr
var size int64
for _, v := range vars {
if _, extloc := v.mem.(*compositeMemory); extloc {
continue
}
if v.Addr < minaddr {
minaddr = v.Addr
}
@ -1923,7 +1929,9 @@ func (scope *EvalScope) variablesByTag(tag dwarf.Tag, cfg *LoadConfig) ([]*Varia
mem := cacheMemory(vars[0].mem, minaddr, int(maxaddr-minaddr))
for _, v := range vars {
v.mem = mem
if _, extloc := v.mem.(*compositeMemory); !extloc {
v.mem = mem
}
}
}