golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-11-01 03:42:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc: fix TestIssue1101 flake (#3585)

Browse Source 
If the target process exits and receives a signal at the same time and
we receive the signal first we should call waitpid again to read the
target's exit status.

This also fixes a nil pointer dereference when trapWaitInternal returns
an error, this fix is probably incomplete but I wasn't able to
reproduce its circumstances after 30000 runs of TestIssue1101 to
properly address it.
This commit is contained in:
Alessandro Arzilli
2023-11-27 17:58:27 +01:00
committed by GitHub
parent 4e2d63fa26
commit 4ed41e9060
2 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/proc/proc_test.go
View File

@ -3690,7 +3690,7 @@ func TestIssue1101(t *testing.T) {
// Also it seems that sometimes on linux/386 we will not receive the
// exit status. This happens if the process exits at the same time as it
// receives a signal.
t.Fatalf("process exited status %d (expected 2)", pexit.Status)
t.Fatalf("process exited status %d (expected 2) (last command = %s) (%#v)", pexit.Status, lastCmd, pexit)
}
} else {
assertNoError(exitErr, t, lastCmd)