golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-10-30 18:27:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc: add minor comments (#2228)

Browse Source 
This patch adds some comments around RequestManualStop().
This commit is contained in:
Andrei Matei
2020-11-16 11:55:59 -05:00
committed by GitHub
parent c94db60d27
commit 42f56e2862
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/proc/interface.go
View File

@ -98,6 +98,7 @@ type ThreadInfo interface {
// ProcessManipulation is an interface for changing the execution state of a process. // ProcessManipulation is an interface for changing the execution state of a process.
type ProcessManipulation interface { type ProcessManipulation interface {
// RequestManualStop attempts to stop all the process' threads.
RequestManualStop() error RequestManualStop() error
// CheckAndClearManualStopRequest returns true the first time it's called // CheckAndClearManualStopRequest returns true the first time it's called
// after a call to RequestManualStop. // after a call to RequestManualStop.

7
pkg/proc/native/proc.go
View File

@ -27,11 +27,14 @@ type nativeProcess struct {
os *osProcessDetails os *osProcessDetails
firstStart bool firstStart bool
stopMu sync.Mutex
resumeChan chan<- struct{} resumeChan chan<- struct{}
ptraceChan chan func() ptraceChan chan func()
ptraceDoneChan chan interface{} ptraceDoneChan chan interface{}
childProcess bool // this process was launched, not attached to childProcess bool // this process was launched, not attached to
stopMu sync.Mutex // protects manualStopRequested
// manualStopRequested is set if all the threads in the process were
// signalled to stop as a result of a Halt API call. Used to disambiguate
// why a thread is found to have stopped.
manualStopRequested bool manualStopRequested bool
// Controlling terminal file descriptor for // Controlling terminal file descriptor for
@ -176,7 +179,7 @@ func (dbp *nativeProcess) Breakpoints() *proc.BreakpointMap {
return &dbp.breakpoints return &dbp.breakpoints
} }
// RequestManualStop sets the `halt` flag and // RequestManualStop sets the `manualStopRequested` flag and
// sends SIGSTOP to all threads. // sends SIGSTOP to all threads.
func (dbp *nativeProcess) RequestManualStop() error { func (dbp *nativeProcess) RequestManualStop() error {
if dbp.exited { if dbp.exited {