golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-11-01 20:20:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc: bugfix: array overrun from cgo in updateThreadList

Browse Source
This commit is contained in:
aarzilli
2016-01-08 09:43:37 +01:00
parent 4da4aea89c
commit 4266479531
3 changed files with 23 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
proc/proc_darwin.go
View File

@ -138,20 +138,25 @@ func (dbp *Process) updateThreadList() error {
var (
err error
kret C.kern_return_t
count = C.thread_count(C.task_t(dbp.os.task))
count C.int
list []uint32
)
if count == -1 {
return fmt.Errorf("could not get thread count")
}
list := make([]uint32, count)
// TODO(dp) might be better to malloc mem in C and then free it here
// instead of getting count above and passing in a slice
kret = C.get_threads(C.task_t(dbp.os.task), unsafe.Pointer(&list[0]))
if kret != C.KERN_SUCCESS {
return fmt.Errorf("could not get thread list")
for {
count = C.thread_count(C.task_t(dbp.os.task))
if count == -1 {
return fmt.Errorf("could not get thread count")
}
list = make([]uint32, count)
// TODO(dp) might be better to malloc mem in C and then free it here
// instead of getting count above and passing in a slice
kret = C.get_threads(C.task_t(dbp.os.task), unsafe.Pointer(&list[0]), count)
if kret != -2 {
break
}
}
if count < 0 {
if kret != C.KERN_SUCCESS {
return fmt.Errorf("could not get thread list")
}