golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-10-29 01:27:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc: Do not panic when a command is executed on an exited process

Browse Source 
Fixes #355
This commit is contained in:
aarzilli
2016-01-30 07:23:14 +01:00
parent fb7210934d
commit 3a8730de72
4 changed files with 119 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
service/debugger/debugger.go
View File

@ -213,22 +213,29 @@ func (d *Debugger) FindBreakpoint(id int) *api.Breakpoint {
}
// Threads returns the threads of the target process.
func (d *Debugger) Threads() []*api.Thread {
func (d *Debugger) Threads() ([]*api.Thread, error) {
if d.process.Exited() {
return nil, &proc.ProcessExitedError{}
}
threads := []*api.Thread{}
for _, th := range d.process.Threads {
threads = append(threads, api.ConvertThread(th))
}
return threads
return threads, nil
}
// FindThread returns the thread for the given 'id'.
func (d *Debugger) FindThread(id int) *api.Thread {
for _, thread := range d.Threads() {
func (d *Debugger) FindThread(id int) (*api.Thread, error) {
threads, err := d.Threads()
if err != nil {
return nil, err
}
for _, thread := range threads {
if thread.ID == id {
return thread
return thread, nil
}
}
return nil
return nil, nil
}
// Command handles commands which control the debugger lifecycle