golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-11-04 06:32:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

dwarf/line: ignore end_of_sequence entry if AllPCsBetween (#2180)

Browse Source 
* dwarf/line: ignore end_of_sequence entry if AllPCsBetween

Go 1.15 (but possibly prior versions of Go too) has a tendency to use
an address in the middle of an instruction for this entry, but if it
was correct it would be after the last instruction of the function
anyway.

This problem manifests especially frequently as a target crash in
TestStepConcurrentPtr on linux/arm64 (~6% of the runs).

* Travis-CI: add ignorechecksum option to chocolatey command

Looks like a configuration problem on chocolatey's end.

Co-authored-by: a <a@kra>
This commit is contained in:
Alessandro Arzilli
2020-09-24 17:03:46 +02:00
committed by GitHub
parent 310a124dba
commit 2bd38fff90
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/dwarf/line/state_machine.go
View File

@ -182,7 +182,7 @@ func (lineInfo *DebugLineInfo) AllPCsBetween(begin, end uint64, excludeFile stri
if (sm.address > end) && (end >= sm.lastAddress) { if (sm.address > end) && (end >= sm.lastAddress) {
break break
} }
if sm.address >= begin && sm.address <= end && sm.address > lastaddr && sm.isStmt && ((sm.file != excludeFile) || (sm.line != excludeLine)) { if sm.address >= begin && sm.address <= end && sm.address > lastaddr && sm.isStmt && !sm.endSeq && ((sm.file != excludeFile) || (sm.line != excludeLine)) {
lastaddr = sm.address lastaddr = sm.address
pcs = append(pcs, sm.address) pcs = append(pcs, sm.address)
} }