logflags: Add pid to server-listening-at message (#1885)

* logflags: Add pid to server-listening-at message

* Address review comments: use logger

Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>

pkg/logflags/logflags.go

@@ -122,10 +122,11 @@ func WriteAPIListeningMessage(addr string) {
 }
 
 func writeListeningMessage(server string, addr string) {
+        msg := fmt.Sprintf("%s server listening at: %s", server, addr)
 	if logOut != nil {
-		fmt.Fprintf(logOut, "%s server listening at: %s\n", server, addr)
+		fmt.Fprintln(logOut, msg)
 	} else {
-		fmt.Printf("%s server listening at: %s\n", server, addr)
+		fmt.Println(msg)
 	}
 }
 

service/dap/server.go

@@ -14,6 +14,7 @@ import (
 	"fmt"
 	"io"
 	"net"
+	"os"
 	"path/filepath"
 
 	"github.com/go-delve/delve/pkg/gobuild"
@@ -64,6 +65,7 @@ type Server struct {
 func NewServer(config *service.Config) *Server {
 	logger := logflags.DAPLogger()
 	logflags.WriteDAPListeningMessage(config.Listener.Addr().String())
+	logger.Debug("DAP server pid = ", os.Getpid())
 	return &Server{
 		config:   config,
 		listener: config.Listener,

service/rpccommon/server.go

@@ -9,6 +9,7 @@ import (
 	"net"
 	"net/rpc"
 	"net/rpc/jsonrpc"
+	"os"
 	"reflect"
 	"runtime"
 	"sync"
@@ -74,6 +75,7 @@ func NewServer(config *service.Config) *ServerImpl {
 	if config.Foreground {
 		// Print listener address
 		logflags.WriteAPIListeningMessage(config.Listener.Addr().String())
+		logger.Debug("API server pid = ", os.Getpid())
 	}
 	return &ServerImpl{
 		config:   config,