golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-10-28 04:35:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc/*,service: replace uses of uintptr with uint64 (#2163)

Browse Source 
Since proc is supposed to work independently from the target
architecture it shouldn't use architecture-dependent types, like
uintptr. For example when reading a 64bit core file on a 32bit
architecture, uintptr will be 32bit but the addresses proc needs to
represent will be 64bit.
This commit is contained in:
Alessandro Arzilli
2020-09-09 19:36:15 +02:00
committed by GitHub
parent e07bfd3180
commit 12009e9833
39 changed files with 178 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/proc/core/linux_core.go
View File

@ -326,9 +326,9 @@ func buildMemory(core, exeELF *elf.File, exe io.ReaderAt, notes []*note) proc.Me
for _, entry := range fileNote.entries {
r := &offsetReaderAt{
reader: exe,
offset: uintptr(entry.Start - (entry.FileOfs * fileNote.PageSize)),
offset: entry.Start - (entry.FileOfs * fileNote.PageSize),
}
memory.Add(r, uintptr(entry.Start), uintptr(entry.End-entry.Start))
memory.Add(r, entry.Start, entry.End-entry.Start)
}
}
@ -344,9 +344,9 @@ func buildMemory(core, exeELF *elf.File, exe io.ReaderAt, notes []*note) proc.Me
}
r := &offsetReaderAt{
reader: prog.ReaderAt,
offset: uintptr(prog.Vaddr),
offset: prog.Vaddr,
}
memory.Add(r, uintptr(prog.Vaddr), uintptr(prog.Filesz))
memory.Add(r, prog.Vaddr, prog.Filesz)
}
}
}