From 0a650a0e0fa0afd5b114702969f81e462292f889 Mon Sep 17 00:00:00 2001
From: chainhelen <chainhelen@gmail.com>
Date: Fri, 28 Feb 2020 11:50:22 -0600
Subject: [PATCH] pkg/logflags: Display warning when unknown component for
 --log-output (#1897)

---
 pkg/logflags/logflags.go | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/pkg/logflags/logflags.go b/pkg/logflags/logflags.go
index ed810704..9ad2dd0e 100644
--- a/pkg/logflags/logflags.go
+++ b/pkg/logflags/logflags.go
@@ -160,6 +160,8 @@ func Setup(logFlag bool, logstr string, logDest string) error {
 	}
 	v := strings.Split(logstr, ",")
 	for _, logcmd := range v {
+		// If adding another value, do make sure to
+		// update "Help about logging flags" in commands.go.
 		switch logcmd {
 		case "debugger":
 			debugger = true
@@ -177,8 +179,8 @@ func Setup(logFlag bool, logstr string, logDest string) error {
 			fnCall = true
 		case "minidump":
 			minidump = true
-			// If adding another value, do make sure to
-			// update "Help about logging flags" in commands.go.
+		default:
+			fmt.Fprintf(os.Stderr, "Warning: unknown log output value %q, run 'dlv help log' for usage.\n", logcmd)
 		}
 	}
 	return nil