golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-10-27 20:23:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc: fix interaction of RequestManualStop and conditional breakpoints (#876)

Browse Source 
* proc: fix interaction of RequestManualStop and conditional breakpoints

A conditional breakpoint that is hit but has the condition evaluate to
false can block a RequestManualStop from working. If the conditional
breakpoint is set on an instruction that is executed very frequently by
multiple goroutines (or many conditional breakpoints are set) it could
prevent all calls to RequestManualStop from working.

This commit fixes the problem by changing proc.Continue to exit
unconditionally after a RequestManualStop is called.

* proc/gdbserial: fix ContinueOnce getting stuck on macOS

Fixes #902
This commit is contained in:
Alessandro Arzilli
2017-07-08 01:29:37 +02:00
committed by Derek Parker
parent 8276ba06cd
commit 07e53f7cbb
6 changed files with 87 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/proc/interface.go
View File

@ -87,6 +87,9 @@ type ProcessManipulation interface {
SwitchThread(int) error
SwitchGoroutine(int) error
RequestManualStop() error
// ManualStopRequested returns true the first time it's called after a call
// to RequestManualStop.
ManualStopRequested() bool
Halt() error
Kill() error
Detach(bool) error