build: bump version to v1.9.5

https://github.com/ReVanced/revanced-patcher/releases/tag/v14.2.2

.github/ISSUE_TEMPLATE/bug-issue.yml

@@ -1,5 +1,5 @@
 name: 🐞 Bug report
-description: Report a very clearly broken issue.
+description: Create a new bug report.
 title: 'bug: <title>'
 labels: [bug]
 body:
@@ -8,53 +8,20 @@ body:
       value: |
         # ReVanced Manager bug report
 
-        Important to note that your issue may have already been reported before. Please check for existing issues [here](https://github.com/revanced/revanced-manager/labels/bug).
+        Please check for existing issues [here](https://github.com/revanced/revanced-manager/labels/bug) before creating a new one.
-
-  - type: dropdown
-    attributes:
-      label: Type
-      options:
-        - Error while running the manager
-        - Error at runtime
-        - Cosmetic
-        - Other
-    validations:
-      required: true
   - type: textarea
     attributes:
       label: Bug description
-      description: How did you find the bug? Any additional details that might help?
+      description:
+        - Describe your bug in detail
+        - Add steps to reproduce the bug if possible (Step 1. Download some files. Step 2. ...)
+        - Add images and videos if possible
+        - List selected patches if applicable
     validations:
       required: true
   - type: textarea
     attributes:
-      label: Steps to reproduce
+      label: Version of ReVanced Manager and version & name of application you tried to patch
-      description: Add the steps to reproduce this bug, including your environment.
-      placeholder: Step 1. Download some files. Step 2. ...
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Android version
-      description: Android version used.
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Manager version
-      description: Manager version used.
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Target package name
-      description: App you tried to patch.
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Target package version.
-      description: Version of the app you tried to patch.
     validations:
       required: true
   - type: dropdown
@@ -64,57 +31,31 @@ body:
         - Non-root
         - Root
     validations:
-      required: true
+      required: false
   - type: textarea
     attributes:
-      label: Patches selected.
+      label: Device logs
-      description: Patches you selected for the app.
+      description: Export logs in ReVanced Manager settings.
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Device logs (exported using Manager settings).
-      description: Please copy and paste any relevant log output. This will be automatically formatted into code, so there is no need for backticks.
       render: shell
     validations:
       required: true
   - type: textarea
     attributes:
-      label: Installer logs (exported using Installer menu option) [unneeded if the issue is not during patching].
+      label: Patcher logs
-      description: Please copy and paste any relevant log output. This will be automatically formatted into code, so there is no need for backticks.
+      description: Export logs in "Patcher" screen.
       render: shell
     validations:
       required: false
-  - type: textarea
-    attributes:
-      label: Screenshots or video
-      description: Add screenshots or videos that show the bug here.
-      placeholder: Drag and drop the screenshots/videos into this box.
-    validations:
-      required: false
-  - type: textarea
-    attributes:
-      label: Solution
-      description: If applicable, add a possible solution.
-    validations:
-      required: false
-  - type: textarea
-    attributes:
-      label: Additional context
-      description: Add additional context here.
-    validations:
-      required: false
   - type: checkboxes
-    id: acknowledgments
     attributes:
-      label: Acknowledgments
+      label: Acknowledgements
-      description: Your issue will be closed if you haven't done these steps.
+      description: Your issue will be closed if you don't follow the checklist below!
       options:
-        - label: I have searched the existing issues; this is new and no duplicate or related to another open issue.
+        - label: This request is not a duplicate of an existing issue.
           required: true
-        - label: I have written a short but informative title.
+        - label: I have chosen an appropriate title.
           required: true
-        - label: I properly filled out all of the requested information in this issue.
+        - label: All requested information has been provided properly.
           required: true
-        - label: The issue is solely related to ReVanced Manager and not caused by patches.
+        - label: The issue is solely related to the ReVanced Manager
           required: true

.github/ISSUE_TEMPLATE/feature-issue.yml

@@ -1,52 +1,42 @@
 name: ⭐ Feature request
-description: Create a detailed feature request.
+description: Create a new feature request.
 title: 'feat: <title>'
 labels: [feature-request]
 body:
-  - type: dropdown
+  - type: markdown
     attributes:
-      label: Type
+      value: |
-      options:
+        # ReVanced Manager feature request
-        - Functionality
+
-        - Cosmetic
+        Please check for existing feature requests [here](https://github.com/revanced/revanced-manager/labels/bug) before creating a new one.
-        - Other
-    validations:
-      required: true
   - type: textarea
     attributes:
-      label: Issue
+      label: Feature description
-      description: What is the current problem. Why does it require a feature request?
+      description: Describe your feature in detail.
-    validations:
-      required: true
-  - type: textarea
-    attributes:
-      label: Feature
-      description: Describe your feature in detail. How does it solve the issue?
     validations:
       required: true
   - type: textarea
     attributes:
       label: Motivation
-      description: Why should your feature should be considered?
+      description: Explain why the lack of it is a problem.
     validations:
       required: true
   - type: textarea
     attributes:
       label: Additional context
-      description: Add additional context here.
+      description: In case there is something else you want to add.
     validations:
       required: false
   - type: checkboxes
-    id: acknowledgements
     attributes:
       label: Acknowledgements
-      description: Your issue will be closed if you haven't done these steps.
+      description: Your issue will be closed if you don't follow the checklist below!
       options:
-        - label: I have searched the existing issues and this is a new and no duplicate or related to another open issue.
+        - label: This request is not a duplicate of an existing issue.
           required: true
-        - label: I have written a short but informative title.
+        - label: I have chosen an appropriate title.
           required: true
-        - label: I filled out all of the requested information in this issue properly.
+        - label: All requested information has been provided properly.
           required: true
-        - label: The issue is related solely to the ReVanced Manager 
+        - label: The issue is solely related to the ReVanced Manager
           required: true

.gitignore

@@ -58,6 +58,7 @@ unlinked.ds
 unlinked_spec.ds
 
 # Android related
+.gradle/
 **/android/**/gradle-wrapper.jar
 **/android/.gradle
 **/android/captures/

android/app/build.gradle

@@ -85,7 +85,7 @@ dependencies {
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
 
     // ReVanced
-    implementation "app.revanced:revanced-patcher:14.1.0"
+    implementation "app.revanced:revanced-patcher:14.2.2"
 
     // Signing & aligning
     implementation("org.bouncycastle:bcpkix-jdk15on:1.70")

android/app/src/main/kotlin/app/revanced/manager/flutter/MainActivity.kt

@@ -21,13 +21,8 @@ import kotlinx.coroutines.runBlocking
 import java.io.File
 import java.io.PrintWriter
 import java.io.StringWriter
-import java.util.logging.Level
 import java.util.logging.LogRecord
 import java.util.logging.Logger
-import java.util.logging.SimpleFormatter
-
-private const val PATCHER_CHANNEL = "app.revanced.manager.flutter/patcher"
-private const val INSTALLER_CHANNEL = "app.revanced.manager.flutter/installer"
 
 class MainActivity : FlutterActivity() {
     private val handler = Handler(Looper.getMainLooper())
@@ -37,9 +32,16 @@ class MainActivity : FlutterActivity() {
 
     override fun configureFlutterEngine(flutterEngine: FlutterEngine) {
         super.configureFlutterEngine(flutterEngine)
-        val mainChannel = MethodChannel(flutterEngine.dartExecutor.binaryMessenger, PATCHER_CHANNEL)
+
-        installerChannel =
+        val patcherChannel = "app.revanced.manager.flutter/patcher"
-            MethodChannel(flutterEngine.dartExecutor.binaryMessenger, INSTALLER_CHANNEL)
+        val installerChannel = "app.revanced.manager.flutter/installer"
+
+        val mainChannel =
+            MethodChannel(flutterEngine.dartExecutor.binaryMessenger, patcherChannel)
+
+        this.installerChannel =
+            MethodChannel(flutterEngine.dartExecutor.binaryMessenger, installerChannel)
+
         mainChannel.setMethodCallHandler { call, result ->
             when (call.method) {
                 "runPatcher" -> {
@@ -79,9 +81,7 @@ class MainActivity : FlutterActivity() {
                             keyStoreFilePath,
                             keystorePassword
                         )
-                    } else {
+                    } else result.notImplemented()
-                        result.notImplemented()
-                    }
                 }
 
                 "stopPatcher" -> {
@@ -116,110 +116,95 @@ class MainActivity : FlutterActivity() {
         val cacheDir = File(cacheDirPath)
 
         Thread {
-            try {
+            fun updateProgress(progress: Double, header: String, log: String) {
-                Logger.getLogger("").apply {
-                    handlers.forEach {
-                        it.close()
-                        removeHandler(it)
-                    }
-                    object : java.util.logging.Handler() {
-                        override fun publish(record: LogRecord) = formatter.format(record).toByteArray().let {
-                            if (record.level.intValue() > Level.INFO.intValue())
-                                System.err.write(it)
-                            else
-                                System.out.write(it)
-                        }
-
-                        override fun flush() {
-                            System.out.flush()
-                            System.err.flush()
-                        }
-
-                        override fun close() = flush()
-                    }.also {
-                        it.level = Level.ALL
-                        it.formatter = SimpleFormatter()
-                    }.let(::addHandler)
-                }
                 handler.post {
                     installerChannel.invokeMethod(
                         "update",
                         mapOf(
-                            "progress" to 0.1,
+                            "progress" to progress,
-                            "header" to "",
+                            "header" to header,
-                            "log" to "Copying original APK"
+                            "log" to log
                         )
                     )
                 }
+            }
+
+            fun postStop() = handler.post { stopResult!!.success(null) }
+
+            // Setup logger
+            Logger.getLogger("").apply {
+                handlers.forEach {
+                    it.close()
+                    removeHandler(it)
+                }
+
+                object : java.util.logging.Handler() {
+                    override fun publish(record: LogRecord) =
+                        updateProgress(-1.0, "", record.message)
+
+                    override fun flush() = Unit
+                    override fun close() = flush()
+                }.let(::addHandler)
+            }
+
+            try {
+                updateProgress(0.0, "", "Copying APK")
 
                 if (cancel) {
-                    handler.post { stopResult!!.success(null) }
+                    postStop()
                     return@Thread
                 }
 
                 originalFile.copyTo(inputFile, true)
 
                 if (cancel) {
-                    handler.post { stopResult!!.success(null) }
+                    postStop()
                     return@Thread
                 }
 
-                handler.post {
+                updateProgress(0.05, "Reading APK...", "Reading APK")
-                    installerChannel.invokeMethod(
-                        "update",
-                        mapOf(
-                            "progress" to 0.2,
-                            "header" to "Reading APK...",
-                            "log" to "Reading input APK"
-                        )
-                    )
-                }
 
-                val patcher =
+                val patcher = Patcher(
-                    Patcher(
+                    PatcherOptions(
-                        PatcherOptions(
+                        inputFile,
-                            inputFile,
+                        cacheDir,
-                            cacheDir,
+                        Aapt.binary(applicationContext).absolutePath,
-                            Aapt.binary(applicationContext).absolutePath,
+                        cacheDir.path,
-                            cacheDir.path,
-                        )
                     )
+                )
 
                 if (cancel) {
-                    handler.post { stopResult!!.success(null) }
+                    postStop()
                     return@Thread
                 }
 
-                handler.post {
+                updateProgress(0.1, "Loading patches...", "Loading patches")
-                    installerChannel.invokeMethod(
-                        "update",
-                        mapOf("progress" to 0.3, "header" to "Loading patches...", "log" to "Loading patches")
-                    )
-                }
 
-                val patches =
+                val patches = PatchBundleLoader.Dex(
-                    PatchBundleLoader.Dex(
+                    File(patchBundleFilePath),
-                        File(patchBundleFilePath)
+                    optimizedDexDirectory = cacheDir
-                    ).filter { patch ->
+                ).filter { patch ->
-                        (patch.compatiblePackages?.any { it.name == patcher.context.packageMetadata.packageName } == true || patch.compatiblePackages.isNullOrEmpty()) &&
+                    val isCompatible = patch.compatiblePackages?.any {
-                                selectedPatches.any { it == patch.patchName }
+                        it.name == patcher.context.packageMetadata.packageName
-                    }
+                    } ?: false
+
+                    val compatibleOrUniversal =
+                        isCompatible || patch.compatiblePackages.isNullOrEmpty()
+
+                    compatibleOrUniversal && selectedPatches.any { it == patch.patchName }
+                }
 
                 if (cancel) {
-                    handler.post { stopResult!!.success(null) }
+                    postStop()
                     return@Thread
                 }
 
-                handler.post {
+                updateProgress(0.15, "Executing...", "")
-                    installerChannel.invokeMethod(
+
-                        "update",
+                // Update the progress bar every time a patch is executed from 0.15 to 0.7
-                        mapOf(
+                val totalPatchesCount = patches.size
-                            "progress" to 0.5,
+                val progressStep = 0.55 / totalPatchesCount
-                            "header" to "Executing patches...",
+                var progress = 0.15
-                            "log" to ""
-                        )
-                    )
-                }
 
                 patcher.apply {
                     acceptIntegrations(listOf(integrations))
@@ -227,64 +212,42 @@ class MainActivity : FlutterActivity() {
 
                     runBlocking {
                         apply(false).collect { patchResult: PatchResult ->
-                            patchResult.exception?.let {
+                            if (cancel) {
-                                if (cancel) {
+                                handler.post { stopResult!!.success(null) }
-                                    handler.post { stopResult!!.success(null) }
+                                this.cancel()
-                                    this.cancel()
+                                this@apply.close()
-                                    return@collect
+                                return@collect
-                                }
-                                StringWriter().use { writer ->
-                                    it.printStackTrace(PrintWriter(writer))
-                                    handler.post {
-                                        installerChannel.invokeMethod(
-                                            "update",
-                                            mapOf("progress" to 0.5, "header" to "", "log" to "${patchResult.patchName} failed: $writer")
-                                        )
-                                    }
-                                }
-                            } ?: run {
-                                if (cancel) {
-                                    handler.post { stopResult!!.success(null) }
-                                    this.cancel()
-                                    return@collect
-                                }
-                                val msg = "${patchResult.patchName} succeeded"
-                                handler.post {
-                                    installerChannel.invokeMethod(
-                                        "update",
-                                        mapOf(
-                                            "progress" to 0.5,
-                                            "header" to "",
-                                            "log" to msg
-                                        )
-                                    )
-                                }
                             }
+
+                            val msg = patchResult.exception?.let {
+                                val writer = StringWriter()
+                                it.printStackTrace(PrintWriter(writer))
+                                "${patchResult.patchName} failed: $writer"
+                            } ?: run {
+                                "${patchResult.patchName} succeeded"
+                            }
+
+                            updateProgress(progress, "", msg)
+                            progress += progressStep
                         }
                     }
                 }
 
                 if (cancel) {
-                    handler.post { stopResult!!.success(null) }
+                    postStop()
+                    patcher.close()
                     return@Thread
                 }
 
-                handler.post {
+                updateProgress(0.8, "Building...", "")
-                    installerChannel.invokeMethod(
+
-                        "update",
-                        mapOf(
-                            "progress" to 0.7,
-                            "header" to "Repacking APK...",
-                            "log" to ""
-                        )
-                    )
-                }
                 val res = patcher.get()
                 patcher.close()
+
                 ZipFile(patchedFile).use { file ->
                     res.dexFiles.forEach {
                         if (cancel) {
-                            handler.post { stopResult!!.success(null) }
+                            postStop()
                             return@Thread
                         }
                         file.addEntryCompressData(
@@ -303,92 +266,35 @@ class MainActivity : FlutterActivity() {
                         ZipAligner::getEntryAlignment
                     )
                 }
+
                 if (cancel) {
-                    handler.post { stopResult!!.success(null) }
+                    postStop()
                     return@Thread
                 }
-                handler.post {
+
-                    installerChannel.invokeMethod(
+                updateProgress(0.9, "Signing...", "Signing APK")
-                        "update",
-                        mapOf(
-                            "progress" to 0.9,
-                            "header" to "Signing APK...",
-                            "log" to ""
-                        )
-                    )
-                }
 
                 try {
-                    Signer("ReVanced", keystorePassword).signApk(
+                    Signer("ReVanced", keystorePassword)
-                        patchedFile,
+                        .signApk(patchedFile, outFile, keyStoreFile)
-                        outFile,
-                        keyStoreFile
-                    )
                 } catch (e: Exception) {
-                    //log to console
                     print("Error signing APK: ${e.message}")
                     e.printStackTrace()
                 }
 
-                handler.post {
+                updateProgress(1.0, "Patched", "Patched")
-                    installerChannel.invokeMethod(
-                        "update",
-                        mapOf(
-                            "progress" to 1.0,
-                            "header" to "Finished!",
-                            "log" to "Finished!"
-                        )
-                    )
-                }
             } catch (ex: Throwable) {
                 if (!cancel) {
                     val stack = ex.stackTraceToString()
-                    handler.post {
+                    updateProgress(
-                        installerChannel.invokeMethod(
+                        -100.0,
-                            "update",
+                        "Aborted",
-                            mapOf(
+                        "An error occurred:\n$stack"
-                                "progress" to -100.0,
+                    )
-                                "header" to "Aborted...",
-                                "log" to "An error occurred! Aborted\nError:\n$stack"
-                            )
-                        )
-                    }
                 }
             }
+
             handler.post { result.success(null) }
         }.start()
     }
-
-//    inner class ManagerLogger : Logger {
-//        override fun error(msg: String) {
-//            handler.post {
-//                installerChannel
-//                    .invokeMethod(
-//                        "update",
-//                        mapOf("progress" to -1.0, "header" to "", "log" to msg)
-//                    )
-//            }
-//        }
-//
-//        override fun warn(msg: String) {
-//            handler.post {
-//                installerChannel.invokeMethod(
-//                    "update",
-//                    mapOf("progress" to -1.0, "header" to "", "log" to msg)
-//                )
-//            }
-//        }
-//
-//        override fun info(msg: String) {
-//            handler.post {
-//                installerChannel.invokeMethod(
-//                    "update",
-//                    mapOf("progress" to -1.0, "header" to "", "log" to msg)
-//                )
-//            }
-//        }
-//
-//        override fun trace(_msg: String) { /* unused */
-//        }
-//    }
 }

lib/services/manager_api.dart

@@ -111,17 +111,6 @@ class ManagerAPI {
   }
 
   bool isPatchesChangeEnabled() {
-    if (getPatchedApps().isNotEmpty && !isChangingToggleModified()) {
-      for (final apps in getPatchedApps()) {
-        if (getSavedPatches(apps.originalPackageName)
-                .indexWhere((patch) => patch.excluded) !=
-            -1) {
-          setPatchesChangeWarning(false);
-          setPatchesChangeEnabled(true);
-          break;
-        }
-      }
-    }
     return _prefs.getBool('patchesChangeEnabled') ?? false;
   }
 

lib/ui/views/app_selector/app_selector_viewmodel.dart

@@ -90,10 +90,14 @@ class AppSelectorViewModel extends BaseViewModel {
         await DeviceApps.getApp(packageName, true) as ApplicationWithIcon?;
     if (app != null) {
       if (await checkSplitApk(packageName) && !isRooted) {
-        return showSelectFromStorageDialog(context);
+        if (context.mounted) {
+          return showSelectFromStorageDialog(context);
+        }
       } else if (!await checkSplitApk(packageName) || isRooted) {
         selectApp(app);
-        Navigator.pop(context);
+        if (context.mounted) {
+          Navigator.pop(context);
+        }
       }
     }
   }

lib/ui/views/installer/installer_view.dart

@@ -21,11 +21,23 @@ class InstallerView extends StatelessWidget {
           bottom: false,
           child: Scaffold(
             floatingActionButton: Visibility(
-              visible: !model.isPatching,
+              visible: !model.isPatching && !model.hasErrors,
               child: FloatingActionButton.extended(
-                label: I18nText('installerView.installButton'),
+                label: I18nText(
-                icon: const Icon(Icons.file_download_outlined),
+                  model.isInstalled
-                onPressed: () => model.installTypeDialog(context),
+                      ? 'installerView.openButton'
+                      : 'installerView.installButton',
+                ),
+                icon: model.isInstalled
+                    ? const Icon(Icons.open_in_new)
+                    : const Icon(Icons.file_download_outlined),
+                onPressed: model.isInstalled
+                    ? () => {
+                          model.openApp(),
+                          model.cleanPatcher(),
+                          Navigator.of(context).pop(),
+                        }
+                    : () => model.installTypeDialog(context),
                 elevation: 0,
               ),
             ),

lib/ui/views/navigation/navigation_viewmodel.dart

@@ -18,13 +18,12 @@ class NavigationViewModel extends IndexTrackingViewModel {
   Future<void> initialize(BuildContext context) async {
     locator<Toast>().initialize(context);
     final SharedPreferences prefs = await SharedPreferences.getInstance();
-    requestManageExternalStorage();
+    await requestManageExternalStorage();
 
     if (prefs.getBool('permissionsRequested') == null) {
       await Permission.storage.request();
-      await Permission.manageExternalStorage.request();
       await prefs.setBool('permissionsRequested', true);
-      RootAPI().hasRootPermissions().then(
+      await RootAPI().hasRootPermissions().then(
             (value) => Permission.requestInstallPackages.request().then(
                   (value) => Permission.ignoreBatteryOptimizations.request(),
                 ),

lib/ui/views/patches_selector/patches_selector_view.dart

@@ -199,7 +199,8 @@ class _PatchesSelectorViewState extends State<PatchesSelectorView> {
                                   supportedPackageVersions:
                                       model.getSupportedVersions(patch),
                                   isUnsupported: !isPatchSupported(patch),
-                                  isChangeEnabled: _managerAPI.isPatchesChangeEnabled(),
+                                  isChangeEnabled:
+                                      _managerAPI.isPatchesChangeEnabled(),
                                   isNew: model.isPatchNew(
                                     patch,
                                     model.getAppInfo().packageName,
@@ -221,8 +222,23 @@ class _PatchesSelectorViewState extends State<PatchesSelectorView> {
                                   padding: const EdgeInsets.symmetric(
                                     vertical: 10.0,
                                   ),
-                                  child: I18nText(
+                                  child: Container(
-                                    'patchesSelectorView.universalPatches',
+                                    padding: const EdgeInsets.only(
+                                      top: 10.0,
+                                      bottom: 10.0,
+                                      left: 5.0,
+                                    ),
+                                    child: I18nText(
+                                      'patchesSelectorView.universalPatches',
+                                      child: Text(
+                                        '',
+                                        style: TextStyle(
+                                          color: Theme.of(context)
+                                              .colorScheme
+                                              .primary,
+                                        ),
+                                      ),
+                                    ),
                                   ),
                                 ),
                                 ...model.getQueriedPatches(_query).map((patch) {
@@ -236,7 +252,8 @@ class _PatchesSelectorViewState extends State<PatchesSelectorView> {
                                       supportedPackageVersions:
                                           model.getSupportedVersions(patch),
                                       isUnsupported: !isPatchSupported(patch),
-                                      isChangeEnabled: _managerAPI.isPatchesChangeEnabled(),
+                                      isChangeEnabled:
+                                          _managerAPI.isPatchesChangeEnabled(),
                                       isNew: false,
                                       isSelected: model.isSelected(patch),
                                       onChanged: (value) => model.selectPatch(

pubspec.yaml

@@ -4,7 +4,7 @@ homepage: https://github.com/revanced/revanced-manager
 
 publish_to: 'none'
 
-version: 1.9.0+100900000
+version: 1.9.5+100900500
 
 environment:
   sdk: '>=3.0.0 <4.0.0'