mirror of
https://github.com/flutter/packages.git
synced 2025-06-08 12:47:00 +08:00
704207985a
Adds new LUCI targets in bringup mode to run all possible Dart unit tests in Chrome. This is a new test (see linked issue), not a port of a Cirrus test, so it involves changes to tooling and packages: - The tooling now accepts an explicit platform. The default behavior if none is provided is the previous behavior of running in VM for everything but web plugin implementations (since that's convenient locally). - The tooling now has a basic understanding of `dart_test.yaml` `test_on` directives, to know when to skip. - Packages that don't support web have opt-out files. - Packages that do support web but have a few tests that fail on web have those tests opted out. - Packages that do support web but have a lot of failures on web have temporary opt-out files with TODOs + issue links. Most of https://github.com/flutter/flutter/issues/128979
516 lines
17 KiB
Dart
516 lines
17 KiB
Dart
// Copyright 2013 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:args/command_runner.dart';
|
|
import 'package:file/file.dart';
|
|
import 'package:file/memory.dart';
|
|
import 'package:flutter_plugin_tools/src/common/core.dart';
|
|
import 'package:flutter_plugin_tools/src/common/plugin_utils.dart';
|
|
import 'package:flutter_plugin_tools/src/dart_test_command.dart';
|
|
import 'package:platform/platform.dart';
|
|
import 'package:test/test.dart';
|
|
|
|
import 'mocks.dart';
|
|
import 'util.dart';
|
|
|
|
void main() {
|
|
group('TestCommand', () {
|
|
late FileSystem fileSystem;
|
|
late Platform mockPlatform;
|
|
late Directory packagesDir;
|
|
late CommandRunner<void> runner;
|
|
late RecordingProcessRunner processRunner;
|
|
|
|
setUp(() {
|
|
fileSystem = MemoryFileSystem();
|
|
mockPlatform = MockPlatform();
|
|
packagesDir = createPackagesDirectory(fileSystem: fileSystem);
|
|
processRunner = RecordingProcessRunner();
|
|
final DartTestCommand command = DartTestCommand(
|
|
packagesDir,
|
|
processRunner: processRunner,
|
|
platform: mockPlatform,
|
|
);
|
|
|
|
runner = CommandRunner<void>('test_test', 'Test for $DartTestCommand');
|
|
runner.addCommand(command);
|
|
});
|
|
|
|
test('legacy "test" name still works', () async {
|
|
final RepositoryPackage plugin = createFakePlugin('a_plugin', packagesDir,
|
|
extraFiles: <String>['test/a_test.dart']);
|
|
|
|
await runCapturingPrint(runner, <String>['test']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color'], plugin.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('runs flutter test on each plugin', () async {
|
|
final RepositoryPackage plugin1 = createFakePlugin('plugin1', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
final RepositoryPackage plugin2 = createFakePlugin('plugin2', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
|
|
await runCapturingPrint(runner, <String>['dart-test']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color'], plugin1.path),
|
|
ProcessCall(getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color'], plugin2.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('runs flutter test on Flutter package example tests', () async {
|
|
final RepositoryPackage plugin = createFakePlugin('a_plugin', packagesDir,
|
|
extraFiles: <String>[
|
|
'test/empty_test.dart',
|
|
'example/test/an_example_test.dart'
|
|
]);
|
|
|
|
await runCapturingPrint(runner, <String>['dart-test']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color'], plugin.path),
|
|
ProcessCall(getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color'], getExampleDir(plugin).path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('fails when Flutter tests fail', () async {
|
|
createFakePlugin('plugin1', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
createFakePlugin('plugin2', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
|
|
processRunner
|
|
.mockProcessesForExecutable[getFlutterCommand(mockPlatform)] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(
|
|
MockProcess(exitCode: 1), <String>['dart-test']), // plugin 1 test
|
|
FakeProcessInfo(MockProcess(), <String>['dart-test']), // plugin 2 test
|
|
];
|
|
|
|
Error? commandError;
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['dart-test'], errorHandler: (Error e) {
|
|
commandError = e;
|
|
});
|
|
|
|
expect(commandError, isA<ToolExit>());
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('The following packages had errors:'),
|
|
contains(' plugin1'),
|
|
]));
|
|
});
|
|
|
|
test('skips testing plugins without test directory', () async {
|
|
createFakePlugin('plugin1', packagesDir);
|
|
final RepositoryPackage plugin2 = createFakePlugin('plugin2', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
|
|
await runCapturingPrint(runner, <String>['dart-test']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color'], plugin2.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('runs dart run test on non-Flutter packages', () async {
|
|
final RepositoryPackage plugin = createFakePlugin('a', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
final RepositoryPackage package = createFakePackage('b', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
|
|
await runCapturingPrint(
|
|
runner, <String>['dart-test', '--enable-experiment=exp1']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(
|
|
getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color', '--enable-experiment=exp1'],
|
|
plugin.path),
|
|
ProcessCall('dart', const <String>['pub', 'get'], package.path),
|
|
ProcessCall(
|
|
'dart',
|
|
const <String>['run', '--enable-experiment=exp1', 'test'],
|
|
package.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('runs dart run test on non-Flutter package examples', () async {
|
|
final RepositoryPackage package = createFakePackage(
|
|
'a_package', packagesDir, extraFiles: <String>[
|
|
'test/empty_test.dart',
|
|
'example/test/an_example_test.dart'
|
|
]);
|
|
|
|
await runCapturingPrint(runner, <String>['dart-test']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall('dart', const <String>['pub', 'get'], package.path),
|
|
ProcessCall('dart', const <String>['run', 'test'], package.path),
|
|
ProcessCall('dart', const <String>['pub', 'get'],
|
|
getExampleDir(package).path),
|
|
ProcessCall('dart', const <String>['run', 'test'],
|
|
getExampleDir(package).path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('fails when getting non-Flutter package dependencies fails', () async {
|
|
createFakePackage('a_package', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
|
|
processRunner.mockProcessesForExecutable['dart'] = <FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(exitCode: 1), <String>['pub', 'get'])
|
|
];
|
|
|
|
Error? commandError;
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['dart-test'], errorHandler: (Error e) {
|
|
commandError = e;
|
|
});
|
|
|
|
expect(commandError, isA<ToolExit>());
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('Unable to fetch dependencies'),
|
|
contains('The following packages had errors:'),
|
|
contains(' a_package'),
|
|
]));
|
|
});
|
|
|
|
test('fails when non-Flutter tests fail', () async {
|
|
createFakePackage('a_package', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
|
|
processRunner.mockProcessesForExecutable['dart'] = <FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(), <String>['pub', 'get']),
|
|
FakeProcessInfo(MockProcess(exitCode: 1), <String>['run']), // run test
|
|
];
|
|
|
|
Error? commandError;
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['dart-test'], errorHandler: (Error e) {
|
|
commandError = e;
|
|
});
|
|
|
|
expect(commandError, isA<ToolExit>());
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('The following packages had errors:'),
|
|
contains(' a_package'),
|
|
]));
|
|
});
|
|
|
|
test('runs in Chrome when requested for Flutter package', () async {
|
|
final RepositoryPackage package = createFakePackage(
|
|
'a_package',
|
|
packagesDir,
|
|
isFlutter: true,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
);
|
|
|
|
await runCapturingPrint(
|
|
runner, <String>['dart-test', '--platform=chrome']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(
|
|
getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color', '--platform=chrome'],
|
|
package.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('runs in Chrome by default for Flutter plugins that implement web',
|
|
() async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'some_plugin_web',
|
|
packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
platformSupport: <String, PlatformDetails>{
|
|
platformWeb: const PlatformDetails(PlatformSupport.inline),
|
|
},
|
|
);
|
|
|
|
await runCapturingPrint(runner, <String>['dart-test']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(
|
|
getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color', '--platform=chrome'],
|
|
plugin.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('runs in Chrome when requested for Flutter plugins that implement web',
|
|
() async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'some_plugin_web',
|
|
packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
platformSupport: <String, PlatformDetails>{
|
|
platformWeb: const PlatformDetails(PlatformSupport.inline),
|
|
},
|
|
);
|
|
|
|
await runCapturingPrint(
|
|
runner, <String>['dart-test', '--platform=chrome']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(
|
|
getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color', '--platform=chrome'],
|
|
plugin.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('runs in Chrome when requested for Flutter plugin that endorse web',
|
|
() async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
platformSupport: <String, PlatformDetails>{
|
|
platformWeb: const PlatformDetails(PlatformSupport.federated),
|
|
},
|
|
);
|
|
|
|
await runCapturingPrint(
|
|
runner, <String>['dart-test', '--platform=chrome']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(
|
|
getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color', '--platform=chrome'],
|
|
plugin.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('skips running non-web plugins in browser mode', () async {
|
|
createFakePlugin(
|
|
'non_web_plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
);
|
|
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['dart-test', '--platform=chrome']);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains("Non-web plugin tests don't need web testing."),
|
|
]));
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[]),
|
|
);
|
|
});
|
|
|
|
test('skips running web plugins in explicit vm mode', () async {
|
|
createFakePlugin(
|
|
'some_plugin_web',
|
|
packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
platformSupport: <String, PlatformDetails>{
|
|
platformWeb: const PlatformDetails(PlatformSupport.inline),
|
|
},
|
|
);
|
|
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['dart-test', '--platform=vm']);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains("Web plugin tests don't need vm testing."),
|
|
]));
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[]),
|
|
);
|
|
});
|
|
|
|
test('does not skip for plugins that endorse web', () async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'some_plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
platformSupport: <String, PlatformDetails>{
|
|
platformWeb: const PlatformDetails(PlatformSupport.federated),
|
|
platformAndroid: const PlatformDetails(PlatformSupport.federated),
|
|
},
|
|
);
|
|
|
|
await runCapturingPrint(
|
|
runner, <String>['dart-test', '--platform=chrome']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(
|
|
getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color', '--platform=chrome'],
|
|
plugin.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('runs in Chrome when requested for Dart package', () async {
|
|
final RepositoryPackage package = createFakePackage(
|
|
'package',
|
|
packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
);
|
|
|
|
await runCapturingPrint(
|
|
runner, <String>['dart-test', '--platform=chrome']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall('dart', const <String>['pub', 'get'], package.path),
|
|
ProcessCall('dart',
|
|
const <String>['run', 'test', '--platform=chrome'], package.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('skips running in browser mode if package opts out', () async {
|
|
final RepositoryPackage package = createFakePackage(
|
|
'a_package',
|
|
packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
);
|
|
package.directory.childFile('dart_test.yaml').writeAsStringSync('''
|
|
test_on: vm
|
|
''');
|
|
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['dart-test', '--platform=chrome']);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('Package has opted out of non-vm testing.'),
|
|
]));
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[]),
|
|
);
|
|
});
|
|
|
|
test('skips running in vm mode if package opts out', () async {
|
|
final RepositoryPackage package = createFakePackage(
|
|
'a_package',
|
|
packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
);
|
|
package.directory.childFile('dart_test.yaml').writeAsStringSync('''
|
|
test_on: browser
|
|
''');
|
|
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['dart-test', '--platform=vm']);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('Package has opted out of vm testing.'),
|
|
]));
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[]),
|
|
);
|
|
});
|
|
|
|
test('tries to run for a test_on that the tool does not recognize',
|
|
() async {
|
|
final RepositoryPackage package = createFakePackage(
|
|
'a_package',
|
|
packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart'],
|
|
);
|
|
package.directory.childFile('dart_test.yaml').writeAsStringSync('''
|
|
test_on: !vm && firefox
|
|
''');
|
|
|
|
await runCapturingPrint(runner, <String>['dart-test']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall('dart', const <String>['pub', 'get'], package.path),
|
|
ProcessCall('dart', const <String>['run', 'test'], package.path),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('enable-experiment flag', () async {
|
|
final RepositoryPackage plugin = createFakePlugin('a', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
final RepositoryPackage package = createFakePackage('b', packagesDir,
|
|
extraFiles: <String>['test/empty_test.dart']);
|
|
|
|
await runCapturingPrint(
|
|
runner, <String>['dart-test', '--enable-experiment=exp1']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(
|
|
getFlutterCommand(mockPlatform),
|
|
const <String>['test', '--color', '--enable-experiment=exp1'],
|
|
plugin.path),
|
|
ProcessCall('dart', const <String>['pub', 'get'], package.path),
|
|
ProcessCall(
|
|
'dart',
|
|
const <String>['run', '--enable-experiment=exp1', 'test'],
|
|
package.path),
|
|
]),
|
|
);
|
|
});
|
|
});
|
|
}
|