mirror of
https://github.com/flutter/packages.git
synced 2026-03-13 10:40:37 +08:00
cc3dca67f2
Makes the analysis options changes described in
https://github.com/flutter/flutter/issues/178827:
- Adding
[omit_obvious_local_variable_types](https://dart.dev/tools/linter-rules/omit_obvious_local_variable_types)
- Adding
[specify_nonobvious_local_variable_types](https://dart.dev/tools/linter-rules/specify_nonobvious_local_variable_types)
- Adding
[specify_nonobvious_property_types](https://dart.dev/tools/linter-rules/specify_nonobvious_property_types)
- Adding
[type_annotate_public_apis](https://dart.dev/tools/linter-rules/type_annotate_public_apis)
- Removing
[always_specify_types](https://dart.dev/tools/linter-rules/always_specify_types)
After those changes, makes the following repo-wide changes:
- `dart fix --apply` in all packages and in script/tool/
- `dart format` in all packages and in script/tool/
- `update-excerpts` repo tooling command to update excerpts based on the
changes to their sources
Also updates the min Flutter/Dart SDK version to 3.35/3.9 for the
following packages, to avoid `analyze` failures in the `N-2` legacy
analysis run due to what appears to be a 3.9 change in what the Dart
analyzer continues to be an obvious local type in loop iterations:
- go_router
- google_fonts
- google_identity_services_web
- google_maps_flutter_web
- local_auth_platform_interface
- metrics_center
- multicast_dns
- pigeon
- rfw
- shared_preferences
- two_dimensional_scrollables
- vector_graphics_compiler
- mustache_template
- path_parsing
Because this is causing a significant amount of format churn already, I
took this opportunity to update the repository tooling to a min Dart SDK
of 3.8 (the N-2 stable version, so the earliest version we need the
tooling to support) to pick up the new format style, so the amount of
automated formatter change is higher in script/tool/ than in the
packages.
This does contain two manual changes (other than the repo tooling min
version):
-
d700b45c7d
changes `dynamic` to `Object?` in a few places where `dynamic` caused
analyzer warnings under the new rule set.
- Updates the repo tooling to ignore `.dart_tool/` when looking for
unexpected local `analysis_options.yaml` files, to fix issues running
the repo tool's `analyze` command locally based on recent changes in
`dart` behavior.
This does not include any CHANGELOG or version updates; even though we
normally version any changes to production code, mass automated changes
like this aren't worth the churn of releasing. This includes changes to
lib/example/main.dart and to README.md excerpts; while the style changes
will be user-visible on pub.dev, it's fine for those changes to wait for
the next release of each package.
Part of https://github.com/flutter/flutter/issues/178827
918 lines
29 KiB
Dart
918 lines
29 KiB
Dart
// Copyright 2013 The Flutter Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:args/command_runner.dart';
|
|
import 'package:file/file.dart';
|
|
import 'package:flutter_plugin_tools/src/make_deps_path_based_command.dart';
|
|
import 'package:git/git.dart';
|
|
import 'package:pubspec_parse/pubspec_parse.dart';
|
|
import 'package:test/test.dart';
|
|
|
|
import 'mocks.dart';
|
|
import 'util.dart';
|
|
|
|
void main() {
|
|
late Directory packagesDir;
|
|
late Directory thirdPartyPackagesDir;
|
|
late CommandRunner<void> runner;
|
|
late RecordingProcessRunner gitProcessRunner;
|
|
|
|
setUp(() {
|
|
final GitDir gitDir;
|
|
(:packagesDir, processRunner: _, :gitProcessRunner, :gitDir) =
|
|
configureBaseCommandMocks();
|
|
thirdPartyPackagesDir = packagesDir.parent
|
|
.childDirectory('third_party')
|
|
.childDirectory('packages');
|
|
|
|
final command = MakeDepsPathBasedCommand(packagesDir, gitDir: gitDir);
|
|
|
|
runner = CommandRunner<void>(
|
|
'make-deps-path-based_command',
|
|
'Test for $MakeDepsPathBasedCommand',
|
|
);
|
|
runner.addCommand(command);
|
|
});
|
|
|
|
/// Adds dummy 'dependencies:' entries for each package in [dependencies]
|
|
/// to [package].
|
|
void addDependencies(
|
|
RepositoryPackage package,
|
|
Iterable<String> dependencies, {
|
|
String constraint = '<2.0.0',
|
|
}) {
|
|
final List<String> lines = package.pubspecFile.readAsLinesSync();
|
|
final int dependenciesStartIndex = lines.indexOf('dependencies:');
|
|
assert(dependenciesStartIndex != -1);
|
|
lines.insertAll(dependenciesStartIndex + 1, <String>[
|
|
for (final String dependency in dependencies)
|
|
' $dependency: $constraint',
|
|
]);
|
|
package.pubspecFile.writeAsStringSync(lines.join('\n'));
|
|
}
|
|
|
|
/// Adds dummy 'dependencies:' entries for each package in [dependencies]
|
|
/// to [package], using a path-based dependency.
|
|
void addPathDependencies(
|
|
RepositoryPackage package,
|
|
Iterable<String> dependencies, {
|
|
required String relativePathBase,
|
|
}) {
|
|
final List<String> lines = package.pubspecFile.readAsLinesSync();
|
|
final int dependenciesStartIndex = lines.indexOf('dependencies:');
|
|
assert(dependenciesStartIndex != -1);
|
|
lines.insertAll(dependenciesStartIndex + 1, <String>[
|
|
for (final String dependency in dependencies)
|
|
' $dependency: { path: $relativePathBase$dependency }',
|
|
]);
|
|
package.pubspecFile.writeAsStringSync(lines.join('\n'));
|
|
}
|
|
|
|
/// Adds a 'dev_dependencies:' section with entries for each package in
|
|
/// [dependencies] to [package].
|
|
void addDevDependenciesSection(
|
|
RepositoryPackage package,
|
|
Iterable<String> devDependencies, {
|
|
String constraint = '<2.0.0',
|
|
}) {
|
|
final String originalContent = package.pubspecFile.readAsStringSync();
|
|
package.pubspecFile.writeAsStringSync('''
|
|
$originalContent
|
|
|
|
dev_dependencies:
|
|
${devDependencies.map((String dep) => ' $dep: $constraint').join('\n')}
|
|
''');
|
|
}
|
|
|
|
/// Adds a 'dependency_overrides:' section with entries for each package in
|
|
/// [overrides] to [package].
|
|
void addDependencyOverridesSection(
|
|
RepositoryPackage package,
|
|
Iterable<String> overrides, {
|
|
String path = '../',
|
|
}) {
|
|
final String originalContent = package.pubspecFile.readAsStringSync();
|
|
package.pubspecFile.writeAsStringSync('''
|
|
$originalContent
|
|
|
|
dependency_overrides:
|
|
${overrides.map((String dep) => ' $dep:\n path: $path').join('\n')}
|
|
''');
|
|
}
|
|
|
|
Map<String, String> getDependencyOverrides(RepositoryPackage package) {
|
|
final Pubspec pubspec = package.parsePubspec();
|
|
return pubspec.dependencyOverrides.map(
|
|
(String name, Dependency dep) => MapEntry<String, String>(
|
|
name,
|
|
(dep is PathDependency) ? dep.path : dep.toString(),
|
|
),
|
|
);
|
|
}
|
|
|
|
test('no-ops for no plugins', () async {
|
|
createFakePackage('foo', packagesDir, isFlutter: true);
|
|
final RepositoryPackage packageBar = createFakePackage(
|
|
'bar',
|
|
packagesDir,
|
|
isFlutter: true,
|
|
);
|
|
addDependencies(packageBar, <String>['foo']);
|
|
final String originalPubspecContents = packageBar.pubspecFile
|
|
.readAsStringSync();
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[contains('No target dependencies')]),
|
|
);
|
|
// The 'foo' reference should not have been modified.
|
|
expect(packageBar.pubspecFile.readAsStringSync(), originalPubspecContents);
|
|
});
|
|
|
|
test('includes explanatory comment', () async {
|
|
final RepositoryPackage packageA = createFakePackage(
|
|
'package_a',
|
|
packagesDir,
|
|
isFlutter: true,
|
|
);
|
|
createFakePackage('package_b', packagesDir, isFlutter: true);
|
|
|
|
addDependencies(packageA, <String>['package_b']);
|
|
|
|
await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=package_b',
|
|
]);
|
|
|
|
expect(
|
|
packageA.pubspecFile.readAsLinesSync(),
|
|
containsAllInOrder(<String>[
|
|
'# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.',
|
|
'# See https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins',
|
|
'dependency_overrides:',
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('rewrites "dependencies" references', () async {
|
|
final RepositoryPackage simplePackage = createFakePackage(
|
|
'foo',
|
|
packagesDir,
|
|
isFlutter: true,
|
|
);
|
|
final Directory pluginGroup = packagesDir.childDirectory('bar');
|
|
|
|
createFakePackage('bar_platform_interface', pluginGroup, isFlutter: true);
|
|
final RepositoryPackage pluginImplementation = createFakePlugin(
|
|
'bar_android',
|
|
pluginGroup,
|
|
);
|
|
final RepositoryPackage pluginAppFacing = createFakePlugin(
|
|
'bar',
|
|
pluginGroup,
|
|
);
|
|
|
|
addDependencies(simplePackage, <String>[
|
|
'bar',
|
|
'bar_android',
|
|
'bar_platform_interface',
|
|
]);
|
|
addDependencies(pluginAppFacing, <String>[
|
|
'bar_platform_interface',
|
|
'bar_android',
|
|
]);
|
|
addDependencies(pluginImplementation, <String>['bar_platform_interface']);
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=bar,bar_platform_interface',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAll(<String>[
|
|
'Rewriting references to: bar, bar_platform_interface...',
|
|
' Modified packages/bar/bar/pubspec.yaml',
|
|
' Modified packages/bar/bar_android/pubspec.yaml',
|
|
' Modified packages/foo/pubspec.yaml',
|
|
]),
|
|
);
|
|
expect(
|
|
output,
|
|
isNot(
|
|
contains(' Modified packages/bar/bar_platform_interface/pubspec.yaml'),
|
|
),
|
|
);
|
|
|
|
final Map<String, String?> simplePackageOverrides = getDependencyOverrides(
|
|
simplePackage,
|
|
);
|
|
expect(simplePackageOverrides.length, 2);
|
|
expect(simplePackageOverrides['bar'], '../../packages/bar/bar');
|
|
expect(
|
|
simplePackageOverrides['bar_platform_interface'],
|
|
'../../packages/bar/bar_platform_interface',
|
|
);
|
|
|
|
final Map<String, String?> appFacingPackageOverrides =
|
|
getDependencyOverrides(pluginAppFacing);
|
|
expect(appFacingPackageOverrides.length, 1);
|
|
expect(
|
|
appFacingPackageOverrides['bar_platform_interface'],
|
|
'../../../packages/bar/bar_platform_interface',
|
|
);
|
|
});
|
|
|
|
test('rewrites "dev_dependencies" references', () async {
|
|
createFakePackage('foo', packagesDir);
|
|
final RepositoryPackage builderPackage = createFakePackage(
|
|
'foo_builder',
|
|
packagesDir,
|
|
);
|
|
|
|
addDevDependenciesSection(builderPackage, <String>['foo']);
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=foo',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAll(<String>[
|
|
'Rewriting references to: foo...',
|
|
' Modified packages/foo_builder/pubspec.yaml',
|
|
]),
|
|
);
|
|
|
|
final Map<String, String?> overrides = getDependencyOverrides(
|
|
builderPackage,
|
|
);
|
|
expect(overrides.length, 1);
|
|
expect(overrides['foo'], '../../packages/foo');
|
|
});
|
|
|
|
test('rewrites examples when rewriting the main package', () async {
|
|
final Directory pluginGroup = packagesDir.childDirectory('bar');
|
|
createFakePackage('bar_platform_interface', pluginGroup, isFlutter: true);
|
|
final RepositoryPackage pluginImplementation = createFakePlugin(
|
|
'bar_android',
|
|
pluginGroup,
|
|
);
|
|
final RepositoryPackage pluginAppFacing = createFakePlugin(
|
|
'bar',
|
|
pluginGroup,
|
|
);
|
|
|
|
addDependencies(pluginAppFacing, <String>[
|
|
'bar_platform_interface',
|
|
'bar_android',
|
|
]);
|
|
addDependencies(pluginImplementation, <String>['bar_platform_interface']);
|
|
|
|
await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=bar_android',
|
|
]);
|
|
|
|
final Map<String, String?> exampleOverrides = getDependencyOverrides(
|
|
pluginAppFacing.getExamples().first,
|
|
);
|
|
expect(exampleOverrides.length, 1);
|
|
expect(
|
|
exampleOverrides['bar_android'],
|
|
'../../../../packages/bar/bar_android',
|
|
);
|
|
});
|
|
|
|
test(
|
|
'example overrides include both local and main-package dependencies',
|
|
() async {
|
|
final Directory pluginGroup = packagesDir.childDirectory('bar');
|
|
createFakePackage('bar_platform_interface', pluginGroup, isFlutter: true);
|
|
createFakePlugin('bar_android', pluginGroup);
|
|
final RepositoryPackage pluginAppFacing = createFakePlugin(
|
|
'bar',
|
|
pluginGroup,
|
|
);
|
|
createFakePackage('another_package', packagesDir);
|
|
|
|
addDependencies(pluginAppFacing, <String>[
|
|
'bar_platform_interface',
|
|
'bar_android',
|
|
]);
|
|
addDependencies(pluginAppFacing.getExamples().first, <String>[
|
|
'another_package',
|
|
]);
|
|
|
|
await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=bar_android,another_package',
|
|
]);
|
|
|
|
final Map<String, String?> exampleOverrides = getDependencyOverrides(
|
|
pluginAppFacing.getExamples().first,
|
|
);
|
|
expect(exampleOverrides.length, 2);
|
|
expect(
|
|
exampleOverrides['another_package'],
|
|
'../../../../packages/another_package',
|
|
);
|
|
expect(
|
|
exampleOverrides['bar_android'],
|
|
'../../../../packages/bar/bar_android',
|
|
);
|
|
},
|
|
);
|
|
|
|
test(
|
|
'does not rewrite path-based dependencies that are already path based',
|
|
() async {
|
|
final RepositoryPackage package = createFakePlugin('foo', packagesDir);
|
|
final RepositoryPackage example = package.getExamples().first;
|
|
addPathDependencies(example, <String>['foo'], relativePathBase: '../');
|
|
|
|
await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=foo',
|
|
]);
|
|
|
|
final Map<String, String?> exampleOverrides = getDependencyOverrides(
|
|
example,
|
|
);
|
|
expect(exampleOverrides.length, 0);
|
|
},
|
|
);
|
|
|
|
test(
|
|
'alphabetizes overrides from different sections to avoid lint warnings in analysis',
|
|
() async {
|
|
createFakePackage('a', packagesDir);
|
|
createFakePackage('b', packagesDir);
|
|
createFakePackage('c', packagesDir);
|
|
final RepositoryPackage targetPackage = createFakePackage(
|
|
'target',
|
|
packagesDir,
|
|
);
|
|
|
|
addDependencies(targetPackage, <String>['a', 'c']);
|
|
addDevDependenciesSection(targetPackage, <String>['b']);
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=c,a,b',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<String>[
|
|
'Rewriting references to: c, a, b...',
|
|
' Modified packages/target/pubspec.yaml',
|
|
]),
|
|
);
|
|
|
|
// This matches with a regex in order to all for either flow style or
|
|
// expanded style output.
|
|
expect(
|
|
targetPackage.pubspecFile.readAsStringSync(),
|
|
matches(
|
|
RegExp(
|
|
r'dependency_overrides:.*a:.*b:.*c:.*',
|
|
multiLine: true,
|
|
dotAll: true,
|
|
),
|
|
),
|
|
);
|
|
},
|
|
);
|
|
|
|
test('finds third_party packages', () async {
|
|
createFakePackage('bar', thirdPartyPackagesDir, isFlutter: true);
|
|
final RepositoryPackage firstPartyPackge = createFakePlugin(
|
|
'foo',
|
|
packagesDir,
|
|
);
|
|
|
|
addDependencies(firstPartyPackge, <String>['bar']);
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=bar',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAll(<String>[
|
|
'Rewriting references to: bar...',
|
|
' Modified packages/foo/pubspec.yaml',
|
|
]),
|
|
);
|
|
|
|
final Map<String, String?> simplePackageOverrides = getDependencyOverrides(
|
|
firstPartyPackge,
|
|
);
|
|
expect(simplePackageOverrides.length, 1);
|
|
expect(simplePackageOverrides['bar'], '../../third_party/packages/bar');
|
|
});
|
|
|
|
test(
|
|
'handles third_party target package references in third_party',
|
|
() async {
|
|
createFakePackage('bar', thirdPartyPackagesDir, isFlutter: true);
|
|
final RepositoryPackage otherThirdPartyPackge = createFakePlugin(
|
|
'foo',
|
|
thirdPartyPackagesDir,
|
|
);
|
|
|
|
addDependencies(otherThirdPartyPackge, <String>['bar']);
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=bar',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAll(<String>[
|
|
'Rewriting references to: bar...',
|
|
' Modified third_party/packages/foo/pubspec.yaml',
|
|
]),
|
|
);
|
|
|
|
final Map<String, String?> simplePackageOverrides =
|
|
getDependencyOverrides(otherThirdPartyPackge);
|
|
expect(simplePackageOverrides.length, 1);
|
|
expect(
|
|
simplePackageOverrides['bar'],
|
|
'../../../third_party/packages/bar',
|
|
);
|
|
},
|
|
);
|
|
|
|
// This test case ensures that running CI using this command on an interim
|
|
// PR that itself used this command won't fail on the rewrite step.
|
|
test('running a second time no-ops without failing', () async {
|
|
final RepositoryPackage simplePackage = createFakePackage(
|
|
'foo',
|
|
packagesDir,
|
|
isFlutter: true,
|
|
);
|
|
final Directory pluginGroup = packagesDir.childDirectory('bar');
|
|
|
|
createFakePackage('bar_platform_interface', pluginGroup, isFlutter: true);
|
|
final RepositoryPackage pluginImplementation = createFakePlugin(
|
|
'bar_android',
|
|
pluginGroup,
|
|
);
|
|
final RepositoryPackage pluginAppFacing = createFakePlugin(
|
|
'bar',
|
|
pluginGroup,
|
|
);
|
|
|
|
addDependencies(simplePackage, <String>[
|
|
'bar',
|
|
'bar_android',
|
|
'bar_platform_interface',
|
|
]);
|
|
addDependencies(pluginAppFacing, <String>[
|
|
'bar_platform_interface',
|
|
'bar_android',
|
|
]);
|
|
addDependencies(pluginImplementation, <String>['bar_platform_interface']);
|
|
|
|
await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=bar,bar_platform_interface',
|
|
]);
|
|
final String simplePackageUpdatedContent = simplePackage.pubspecFile
|
|
.readAsStringSync();
|
|
final String appFacingPackageUpdatedContent = pluginAppFacing.pubspecFile
|
|
.readAsStringSync();
|
|
final String implementationPackageUpdatedContent = pluginImplementation
|
|
.pubspecFile
|
|
.readAsStringSync();
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=bar,bar_platform_interface',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAll(<String>[
|
|
'Rewriting references to: bar, bar_platform_interface...',
|
|
' Modified packages/bar/bar/pubspec.yaml',
|
|
' Modified packages/bar/bar_android/pubspec.yaml',
|
|
' Modified packages/foo/pubspec.yaml',
|
|
]),
|
|
);
|
|
expect(
|
|
simplePackage.pubspecFile.readAsStringSync(),
|
|
simplePackageUpdatedContent,
|
|
);
|
|
expect(
|
|
pluginAppFacing.pubspecFile.readAsStringSync(),
|
|
appFacingPackageUpdatedContent,
|
|
);
|
|
expect(
|
|
pluginImplementation.pubspecFile.readAsStringSync(),
|
|
implementationPackageUpdatedContent,
|
|
);
|
|
});
|
|
|
|
test('sorts with existing overrides', () async {
|
|
final RepositoryPackage simplePackage = createFakePackage(
|
|
'foo',
|
|
packagesDir,
|
|
isFlutter: true,
|
|
);
|
|
final Directory pluginGroup = packagesDir.childDirectory('bar');
|
|
|
|
createFakePackage('bar_platform_interface', pluginGroup, isFlutter: true);
|
|
final RepositoryPackage pluginImplementation = createFakePlugin(
|
|
'bar_android',
|
|
pluginGroup,
|
|
);
|
|
final RepositoryPackage pluginAppFacing = createFakePlugin(
|
|
'bar',
|
|
pluginGroup,
|
|
);
|
|
|
|
addDependencies(simplePackage, <String>[
|
|
'bar',
|
|
'bar_android',
|
|
'bar_platform_interface',
|
|
]);
|
|
addDependencies(pluginAppFacing, <String>[
|
|
'bar_platform_interface',
|
|
'bar_android',
|
|
]);
|
|
addDependencies(pluginImplementation, <String>['bar_platform_interface']);
|
|
addDependencyOverridesSection(simplePackage, <String>[
|
|
'bar_android',
|
|
], path: '../bar/bar_android');
|
|
|
|
await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies=bar,bar_platform_interface',
|
|
]);
|
|
final String simplePackageUpdatedContent = simplePackage.pubspecFile
|
|
.readAsStringSync();
|
|
|
|
expect(
|
|
simplePackageUpdatedContent.split('\n'),
|
|
containsAllInOrder(<Matcher>[
|
|
contains(' bar:'),
|
|
contains(' bar_android:'),
|
|
contains(' bar_platform_interface:'),
|
|
]),
|
|
);
|
|
});
|
|
|
|
group('target-dependencies-with-non-breaking-updates', () {
|
|
test('no-ops for no published changes', () async {
|
|
final RepositoryPackage package = createFakePackage('foo', packagesDir);
|
|
|
|
final String changedFileOutput = <File>[
|
|
package.pubspecFile,
|
|
].map((File file) => file.path).join('\n');
|
|
gitProcessRunner.mockProcessesForExecutable['git-diff'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: changedFileOutput)),
|
|
];
|
|
// Simulate no change to the version in the interface's pubspec.yaml.
|
|
gitProcessRunner.mockProcessesForExecutable['git-show'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(
|
|
MockProcess(stdout: package.pubspecFile.readAsStringSync()),
|
|
),
|
|
];
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies-with-non-breaking-updates',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[contains('No target dependencies')]),
|
|
);
|
|
});
|
|
|
|
test('no-ops for no deleted packages', () async {
|
|
final String changedFileOutput = <File>[
|
|
// A change for a file that's not on disk simulates a deletion.
|
|
packagesDir.childDirectory('foo').childFile('pubspec.yaml'),
|
|
].map((File file) => file.path).join('\n');
|
|
gitProcessRunner.mockProcessesForExecutable['git-diff'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: changedFileOutput)),
|
|
];
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies-with-non-breaking-updates',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('Skipping packages/foo; deleted.'),
|
|
contains('No target dependencies'),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('includes bugfix version changes as targets', () async {
|
|
const newVersion = '1.0.1';
|
|
final RepositoryPackage package = createFakePackage(
|
|
'foo',
|
|
packagesDir,
|
|
version: newVersion,
|
|
);
|
|
|
|
final File pubspecFile = package.pubspecFile;
|
|
final String changedFileOutput = <File>[
|
|
pubspecFile,
|
|
].map((File file) => file.path).join('\n');
|
|
gitProcessRunner.mockProcessesForExecutable['git-diff'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: changedFileOutput)),
|
|
];
|
|
final String gitPubspecContents = pubspecFile
|
|
.readAsStringSync()
|
|
.replaceAll(newVersion, '1.0.0');
|
|
// Simulate no change to the version in the interface's pubspec.yaml.
|
|
gitProcessRunner.mockProcessesForExecutable['git-show'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: gitPubspecContents)),
|
|
];
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies-with-non-breaking-updates',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('Rewriting references to: foo...'),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('includes minor version changes to 1.0+ as targets', () async {
|
|
const newVersion = '1.1.0';
|
|
final RepositoryPackage package = createFakePackage(
|
|
'foo',
|
|
packagesDir,
|
|
version: newVersion,
|
|
);
|
|
|
|
final File pubspecFile = package.pubspecFile;
|
|
final String changedFileOutput = <File>[
|
|
pubspecFile,
|
|
].map((File file) => file.path).join('\n');
|
|
gitProcessRunner.mockProcessesForExecutable['git-diff'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: changedFileOutput)),
|
|
];
|
|
final String gitPubspecContents = pubspecFile
|
|
.readAsStringSync()
|
|
.replaceAll(newVersion, '1.0.0');
|
|
// Simulate no change to the version in the interface's pubspec.yaml.
|
|
gitProcessRunner.mockProcessesForExecutable['git-show'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: gitPubspecContents)),
|
|
];
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies-with-non-breaking-updates',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('Rewriting references to: foo...'),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('does not include major version changes as targets', () async {
|
|
const newVersion = '2.0.0';
|
|
final RepositoryPackage package = createFakePackage(
|
|
'foo',
|
|
packagesDir,
|
|
version: newVersion,
|
|
);
|
|
|
|
final File pubspecFile = package.pubspecFile;
|
|
final String changedFileOutput = <File>[
|
|
pubspecFile,
|
|
].map((File file) => file.path).join('\n');
|
|
gitProcessRunner.mockProcessesForExecutable['git-diff'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: changedFileOutput)),
|
|
];
|
|
final String gitPubspecContents = pubspecFile
|
|
.readAsStringSync()
|
|
.replaceAll(newVersion, '1.0.0');
|
|
// Simulate no change to the version in the interface's pubspec.yaml.
|
|
gitProcessRunner.mockProcessesForExecutable['git-show'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: gitPubspecContents)),
|
|
];
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies-with-non-breaking-updates',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[contains('No target dependencies')]),
|
|
);
|
|
});
|
|
|
|
test('does not include minor version changes to 0.x as targets', () async {
|
|
const newVersion = '0.8.0';
|
|
final RepositoryPackage package = createFakePackage(
|
|
'foo',
|
|
packagesDir,
|
|
version: newVersion,
|
|
);
|
|
|
|
final File pubspecFile = package.pubspecFile;
|
|
final String changedFileOutput = <File>[
|
|
pubspecFile,
|
|
].map((File file) => file.path).join('\n');
|
|
gitProcessRunner.mockProcessesForExecutable['git-diff'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: changedFileOutput)),
|
|
];
|
|
final String gitPubspecContents = pubspecFile
|
|
.readAsStringSync()
|
|
.replaceAll(newVersion, '0.7.0');
|
|
// Simulate no change to the version in the interface's pubspec.yaml.
|
|
gitProcessRunner.mockProcessesForExecutable['git-show'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: gitPubspecContents)),
|
|
];
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies-with-non-breaking-updates',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[contains('No target dependencies')]),
|
|
);
|
|
});
|
|
|
|
test('does not update references with an older major version', () async {
|
|
const newVersion = '2.0.1';
|
|
final RepositoryPackage targetPackage = createFakePackage(
|
|
'foo',
|
|
packagesDir,
|
|
version: newVersion,
|
|
);
|
|
final RepositoryPackage referencingPackage = createFakePackage(
|
|
'bar',
|
|
packagesDir,
|
|
);
|
|
|
|
// For a dependency on ^1.0.0, the 2.0.0->2.0.1 update should not apply.
|
|
addDependencies(referencingPackage, <String>[
|
|
'foo',
|
|
], constraint: '^1.0.0');
|
|
|
|
final File pubspecFile = targetPackage.pubspecFile;
|
|
final String changedFileOutput = <File>[
|
|
pubspecFile,
|
|
].map((File file) => file.path).join('\n');
|
|
gitProcessRunner.mockProcessesForExecutable['git-diff'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: changedFileOutput)),
|
|
];
|
|
final String gitPubspecContents = pubspecFile
|
|
.readAsStringSync()
|
|
.replaceAll(newVersion, '2.0.0');
|
|
gitProcessRunner.mockProcessesForExecutable['git-show'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: gitPubspecContents)),
|
|
];
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies-with-non-breaking-updates',
|
|
]);
|
|
|
|
final Pubspec referencingPubspec = referencingPackage.parsePubspec();
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[contains('Rewriting references to: foo')]),
|
|
);
|
|
expect(referencingPubspec.dependencyOverrides.isEmpty, true);
|
|
});
|
|
|
|
test('does update references with a matching version range', () async {
|
|
const newVersion = '2.0.1';
|
|
final RepositoryPackage targetPackage = createFakePackage(
|
|
'foo',
|
|
packagesDir,
|
|
version: newVersion,
|
|
);
|
|
final RepositoryPackage referencingPackage = createFakePackage(
|
|
'bar',
|
|
packagesDir,
|
|
);
|
|
|
|
// For a dependency on ^1.0.0, the 2.0.0->2.0.1 update should not apply.
|
|
addDependencies(referencingPackage, <String>[
|
|
'foo',
|
|
], constraint: '^2.0.0');
|
|
|
|
final File pubspecFile = targetPackage.pubspecFile;
|
|
final String changedFileOutput = <File>[
|
|
pubspecFile,
|
|
].map((File file) => file.path).join('\n');
|
|
gitProcessRunner.mockProcessesForExecutable['git-diff'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: changedFileOutput)),
|
|
];
|
|
final String gitPubspecContents = pubspecFile
|
|
.readAsStringSync()
|
|
.replaceAll(newVersion, '2.0.0');
|
|
gitProcessRunner.mockProcessesForExecutable['git-show'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: gitPubspecContents)),
|
|
];
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies-with-non-breaking-updates',
|
|
]);
|
|
|
|
final Pubspec referencingPubspec = referencingPackage.parsePubspec();
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[contains('Rewriting references to: foo')]),
|
|
);
|
|
expect(
|
|
referencingPubspec.dependencyOverrides['foo'] is PathDependency,
|
|
true,
|
|
);
|
|
});
|
|
|
|
test('skips anything outside of the packages directory', () async {
|
|
final Directory toolDir = packagesDir.parent.childDirectory('tool');
|
|
const newVersion = '1.1.0';
|
|
final RepositoryPackage package = createFakePackage(
|
|
'flutter_plugin_tools',
|
|
toolDir,
|
|
version: newVersion,
|
|
);
|
|
|
|
// Simulate a minor version change so it would be a target.
|
|
final File pubspecFile = package.pubspecFile;
|
|
final String changedFileOutput = <File>[
|
|
pubspecFile,
|
|
].map((File file) => file.path).join('\n');
|
|
gitProcessRunner.mockProcessesForExecutable['git-diff'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: changedFileOutput)),
|
|
];
|
|
final String gitPubspecContents = pubspecFile
|
|
.readAsStringSync()
|
|
.replaceAll(newVersion, '1.0.0');
|
|
gitProcessRunner.mockProcessesForExecutable['git-show'] =
|
|
<FakeProcessInfo>[
|
|
FakeProcessInfo(MockProcess(stdout: gitPubspecContents)),
|
|
];
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'make-deps-path-based',
|
|
'--target-dependencies-with-non-breaking-updates',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains(
|
|
'Skipping /tool/flutter_plugin_tools/pubspec.yaml; not in packages directory.',
|
|
),
|
|
contains('No target dependencies'),
|
|
]),
|
|
);
|
|
});
|
|
});
|
|
}
|