Files
packages/script/tool/test/list_command_test.dart
stuartmorgan-g cc3dca67f2 [all] Omit obvious local types (#10511)
Makes the analysis options changes described in
https://github.com/flutter/flutter/issues/178827:
- Adding
[omit_obvious_local_variable_types](https://dart.dev/tools/linter-rules/omit_obvious_local_variable_types)
- Adding
[specify_nonobvious_local_variable_types](https://dart.dev/tools/linter-rules/specify_nonobvious_local_variable_types)
- Adding
[specify_nonobvious_property_types](https://dart.dev/tools/linter-rules/specify_nonobvious_property_types)
- Adding
[type_annotate_public_apis](https://dart.dev/tools/linter-rules/type_annotate_public_apis)
- Removing
[always_specify_types](https://dart.dev/tools/linter-rules/always_specify_types)

After those changes, makes the following repo-wide changes:
- `dart fix --apply` in all packages and in script/tool/
- `dart format` in all packages and in script/tool/
- `update-excerpts` repo tooling command to update excerpts based on the
changes to their sources

Also updates the min Flutter/Dart SDK version to 3.35/3.9 for the
following packages, to avoid `analyze` failures in the `N-2` legacy
analysis run due to what appears to be a 3.9 change in what the Dart
analyzer continues to be an obvious local type in loop iterations:
- go_router
- google_fonts
- google_identity_services_web
- google_maps_flutter_web
- local_auth_platform_interface
- metrics_center
- multicast_dns
- pigeon
- rfw
- shared_preferences
- two_dimensional_scrollables
- vector_graphics_compiler
- mustache_template
- path_parsing

Because this is causing a significant amount of format churn already, I
took this opportunity to update the repository tooling to a min Dart SDK
of 3.8 (the N-2 stable version, so the earliest version we need the
tooling to support) to pick up the new format style, so the amount of
automated formatter change is higher in script/tool/ than in the
packages.

This does contain two manual changes (other than the repo tooling min
version):
-
d700b45c7d
changes `dynamic` to `Object?` in a few places where `dynamic` caused
analyzer warnings under the new rule set.
- Updates the repo tooling to ignore `.dart_tool/` when looking for
unexpected local `analysis_options.yaml` files, to fix issues running
the repo tool's `analyze` command locally based on recent changes in
`dart` behavior.

This does not include any CHANGELOG or version updates; even though we
normally version any changes to production code, mass automated changes
like this aren't worth the churn of releasing. This includes changes to
lib/example/main.dart and to README.md excerpts; while the style changes
will be user-visible on pub.dev, it's fine for those changes to wait for
the next release of each package.

Part of https://github.com/flutter/flutter/issues/178827
2025-11-24 18:26:06 -05:00

213 lines
6.3 KiB
Dart

// Copyright 2013 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:args/command_runner.dart';
import 'package:file/file.dart';
import 'package:flutter_plugin_tools/src/list_command.dart';
import 'package:test/test.dart';
import 'mocks.dart';
import 'util.dart';
void main() {
group('ListCommand', () {
late MockPlatform mockPlatform;
late Directory packagesDir;
late CommandRunner<void> runner;
setUp(() {
mockPlatform = MockPlatform();
(:packagesDir, processRunner: _, gitProcessRunner: _, gitDir: _) =
configureBaseCommandMocks(platform: mockPlatform);
final command = ListCommand(packagesDir, platform: mockPlatform);
runner = CommandRunner<void>('list_test', 'Test for $ListCommand');
runner.addCommand(command);
});
test('lists top-level packages', () async {
createFakePackage('package1', packagesDir);
createFakePlugin('plugin2', packagesDir);
final List<String> plugins = await runCapturingPrint(runner, <String>[
'list',
'--type=package',
]);
expect(
plugins,
orderedEquals(<String>['/packages/package1', '/packages/plugin2']),
);
});
test('lists examples', () async {
createFakePlugin('plugin1', packagesDir);
createFakePlugin(
'plugin2',
packagesDir,
examples: <String>['example1', 'example2'],
);
createFakePlugin('plugin3', packagesDir, examples: <String>[]);
final List<String> examples = await runCapturingPrint(runner, <String>[
'list',
'--type=example',
]);
expect(
examples,
orderedEquals(<String>[
'/packages/plugin1/example',
'/packages/plugin2/example/example1',
'/packages/plugin2/example/example2',
]),
);
});
test('lists packages and subpackages', () async {
createFakePackage('package1', packagesDir);
createFakePlugin(
'plugin2',
packagesDir,
examples: <String>['example1', 'example2'],
);
createFakePlugin('plugin3', packagesDir, examples: <String>[]);
final List<String> packages = await runCapturingPrint(runner, <String>[
'list',
'--type=package-or-subpackage',
]);
expect(
packages,
unorderedEquals(<String>[
'/packages/package1',
'/packages/package1/example',
'/packages/plugin2',
'/packages/plugin2/example/example1',
'/packages/plugin2/example/example2',
'/packages/plugin3',
]),
);
});
test('lists files', () async {
createFakePlugin('plugin1', packagesDir);
createFakePlugin(
'plugin2',
packagesDir,
examples: <String>['example1', 'example2'],
);
createFakePlugin('plugin3', packagesDir, examples: <String>[]);
final List<String> examples = await runCapturingPrint(runner, <String>[
'list',
'--type=file',
]);
expect(
examples,
unorderedEquals(<String>[
'/packages/plugin1/pubspec.yaml',
'/packages/plugin1/AUTHORS',
'/packages/plugin1/CHANGELOG.md',
'/packages/plugin1/README.md',
'/packages/plugin1/example/pubspec.yaml',
'/packages/plugin2/pubspec.yaml',
'/packages/plugin2/AUTHORS',
'/packages/plugin2/CHANGELOG.md',
'/packages/plugin2/README.md',
'/packages/plugin2/example/example1/pubspec.yaml',
'/packages/plugin2/example/example2/pubspec.yaml',
'/packages/plugin3/pubspec.yaml',
'/packages/plugin3/AUTHORS',
'/packages/plugin3/CHANGELOG.md',
'/packages/plugin3/README.md',
]),
);
});
test('lists plugins using federated plugin layout', () async {
createFakePlugin('plugin1', packagesDir);
// Create a federated plugin by creating a directory under the packages
// directory with several packages underneath.
final Directory federatedPluginDir = packagesDir.childDirectory(
'my_plugin',
)..createSync();
createFakePlugin('my_plugin', federatedPluginDir);
createFakePlugin('my_plugin_web', federatedPluginDir);
createFakePlugin('my_plugin_macos', federatedPluginDir);
// Test without specifying `--type`.
final List<String> plugins = await runCapturingPrint(runner, <String>[
'list',
]);
expect(
plugins,
unorderedEquals(<String>[
'/packages/plugin1',
'/packages/my_plugin/my_plugin',
'/packages/my_plugin/my_plugin_web',
'/packages/my_plugin/my_plugin_macos',
]),
);
});
test('can filter plugins with the --packages argument', () async {
createFakePlugin('plugin1', packagesDir);
// Create a federated plugin by creating a directory under the packages
// directory with several packages underneath.
final Directory federatedPluginDir = packagesDir.childDirectory(
'my_plugin',
)..createSync();
createFakePlugin('my_plugin', federatedPluginDir);
createFakePlugin('my_plugin_web', federatedPluginDir);
createFakePlugin('my_plugin_macos', federatedPluginDir);
List<String> plugins = await runCapturingPrint(runner, <String>[
'list',
'--packages=plugin1',
]);
expect(plugins, unorderedEquals(<String>['/packages/plugin1']));
plugins = await runCapturingPrint(runner, <String>[
'list',
'--packages=my_plugin',
]);
expect(
plugins,
unorderedEquals(<String>[
'/packages/my_plugin/my_plugin',
'/packages/my_plugin/my_plugin_web',
'/packages/my_plugin/my_plugin_macos',
]),
);
plugins = await runCapturingPrint(runner, <String>[
'list',
'--packages=my_plugin/my_plugin_web',
]);
expect(
plugins,
unorderedEquals(<String>['/packages/my_plugin/my_plugin_web']),
);
plugins = await runCapturingPrint(runner, <String>[
'list',
'--packages=my_plugin/my_plugin_web,plugin1',
]);
expect(
plugins,
unorderedEquals(<String>[
'/packages/plugin1',
'/packages/my_plugin/my_plugin_web',
]),
);
});
});
}