mirror of
https://github.com/flutter/packages.git
synced 2026-03-13 10:40:37 +08:00
Makes the analysis options changes described in
https://github.com/flutter/flutter/issues/178827:
- Adding
[omit_obvious_local_variable_types](https://dart.dev/tools/linter-rules/omit_obvious_local_variable_types)
- Adding
[specify_nonobvious_local_variable_types](https://dart.dev/tools/linter-rules/specify_nonobvious_local_variable_types)
- Adding
[specify_nonobvious_property_types](https://dart.dev/tools/linter-rules/specify_nonobvious_property_types)
- Adding
[type_annotate_public_apis](https://dart.dev/tools/linter-rules/type_annotate_public_apis)
- Removing
[always_specify_types](https://dart.dev/tools/linter-rules/always_specify_types)
After those changes, makes the following repo-wide changes:
- `dart fix --apply` in all packages and in script/tool/
- `dart format` in all packages and in script/tool/
- `update-excerpts` repo tooling command to update excerpts based on the
changes to their sources
Also updates the min Flutter/Dart SDK version to 3.35/3.9 for the
following packages, to avoid `analyze` failures in the `N-2` legacy
analysis run due to what appears to be a 3.9 change in what the Dart
analyzer continues to be an obvious local type in loop iterations:
- go_router
- google_fonts
- google_identity_services_web
- google_maps_flutter_web
- local_auth_platform_interface
- metrics_center
- multicast_dns
- pigeon
- rfw
- shared_preferences
- two_dimensional_scrollables
- vector_graphics_compiler
- mustache_template
- path_parsing
Because this is causing a significant amount of format churn already, I
took this opportunity to update the repository tooling to a min Dart SDK
of 3.8 (the N-2 stable version, so the earliest version we need the
tooling to support) to pick up the new format style, so the amount of
automated formatter change is higher in script/tool/ than in the
packages.
This does contain two manual changes (other than the repo tooling min
version):
-
d700b45c7d
changes `dynamic` to `Object?` in a few places where `dynamic` caused
analyzer warnings under the new rule set.
- Updates the repo tooling to ignore `.dart_tool/` when looking for
unexpected local `analysis_options.yaml` files, to fix issues running
the repo tool's `analyze` command locally based on recent changes in
`dart` behavior.
This does not include any CHANGELOG or version updates; even though we
normally version any changes to production code, mass automated changes
like this aren't worth the churn of releasing. This includes changes to
lib/example/main.dart and to README.md excerpts; while the style changes
will be user-visible on pub.dev, it's fine for those changes to wait for
the next release of each package.
Part of https://github.com/flutter/flutter/issues/178827
215 lines
5.7 KiB
Dart
215 lines
5.7 KiB
Dart
// Copyright 2013 The Flutter Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:args/command_runner.dart';
|
|
import 'package:file/file.dart';
|
|
import 'package:flutter_plugin_tools/src/common/core.dart';
|
|
import 'package:flutter_plugin_tools/src/dependabot_check_command.dart';
|
|
import 'package:git/git.dart';
|
|
import 'package:test/test.dart';
|
|
|
|
import 'util.dart';
|
|
|
|
void main() {
|
|
late CommandRunner<void> runner;
|
|
late Directory root;
|
|
late Directory packagesDir;
|
|
|
|
setUp(() {
|
|
final GitDir gitDir;
|
|
(:packagesDir, processRunner: _, gitProcessRunner: _, :gitDir) =
|
|
configureBaseCommandMocks();
|
|
root = packagesDir.parent;
|
|
|
|
final command = DependabotCheckCommand(packagesDir, gitDir: gitDir);
|
|
runner = CommandRunner<void>(
|
|
'dependabot_test',
|
|
'Test for $DependabotCheckCommand',
|
|
);
|
|
runner.addCommand(command);
|
|
});
|
|
|
|
void setDependabotCoverage({
|
|
Iterable<String> gradleDirs = const <String>[],
|
|
bool useDirectoriesKey = false,
|
|
}) {
|
|
final String gradleEntries;
|
|
if (useDirectoriesKey) {
|
|
gradleEntries =
|
|
'''
|
|
- package-ecosystem: "gradle"
|
|
directories:
|
|
${gradleDirs.map((String directory) => ' - /$directory').join('\n')}
|
|
schedule:
|
|
interval: "daily"
|
|
''';
|
|
} else {
|
|
gradleEntries = gradleDirs
|
|
.map(
|
|
(String directory) =>
|
|
'''
|
|
- package-ecosystem: "gradle"
|
|
directory: "/$directory"
|
|
schedule:
|
|
interval: "daily"
|
|
''',
|
|
)
|
|
.join('\n');
|
|
}
|
|
final File configFile = root
|
|
.childDirectory('.github')
|
|
.childFile('dependabot.yml');
|
|
configFile.createSync(recursive: true);
|
|
configFile.writeAsStringSync('''
|
|
version: 2
|
|
updates:
|
|
$gradleEntries
|
|
''');
|
|
}
|
|
|
|
test('skips with no supported ecosystems', () async {
|
|
setDependabotCoverage();
|
|
createFakePackage('a_package', packagesDir);
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'dependabot-check',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('SKIPPING: No supported package ecosystems'),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('fails for app missing Gradle coverage', () async {
|
|
setDependabotCoverage();
|
|
final RepositoryPackage package = createFakePackage(
|
|
'a_package',
|
|
packagesDir,
|
|
);
|
|
package.directory
|
|
.childDirectory('example')
|
|
.childDirectory('android')
|
|
.childDirectory('app')
|
|
.createSync(recursive: true);
|
|
|
|
Error? commandError;
|
|
final List<String> output = await runCapturingPrint(
|
|
runner,
|
|
<String>['dependabot-check'],
|
|
errorHandler: (Error e) {
|
|
commandError = e;
|
|
},
|
|
);
|
|
|
|
expect(commandError, isA<ToolExit>());
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('Missing Gradle coverage.'),
|
|
contains(
|
|
'Add a "gradle" entry to .github/dependabot.yml for /packages/a_package/example/android/app',
|
|
),
|
|
contains(
|
|
'a_package/example:\n'
|
|
' Missing Gradle coverage',
|
|
),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('fails for plugin missing Gradle coverage', () async {
|
|
setDependabotCoverage();
|
|
final RepositoryPackage plugin = createFakePlugin('a_plugin', packagesDir);
|
|
plugin.directory.childDirectory('android').createSync(recursive: true);
|
|
|
|
Error? commandError;
|
|
final List<String> output = await runCapturingPrint(
|
|
runner,
|
|
<String>['dependabot-check'],
|
|
errorHandler: (Error e) {
|
|
commandError = e;
|
|
},
|
|
);
|
|
|
|
expect(commandError, isA<ToolExit>());
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[
|
|
contains('Missing Gradle coverage.'),
|
|
contains(
|
|
'Add a "gradle" entry to .github/dependabot.yml for /packages/a_plugin/android',
|
|
),
|
|
contains(
|
|
'a_plugin:\n'
|
|
' Missing Gradle coverage',
|
|
),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('passes for correct Gradle coverage with single directory', () async {
|
|
setDependabotCoverage(
|
|
gradleDirs: <String>[
|
|
'packages/a_plugin/android',
|
|
'packages/a_plugin/example/android/app',
|
|
],
|
|
);
|
|
final RepositoryPackage plugin = createFakePlugin('a_plugin', packagesDir);
|
|
// Test the plugin.
|
|
plugin.directory.childDirectory('android').createSync(recursive: true);
|
|
// And its example app.
|
|
plugin.directory
|
|
.childDirectory('example')
|
|
.childDirectory('android')
|
|
.childDirectory('app')
|
|
.createSync(recursive: true);
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'dependabot-check',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[contains('Ran for 2 package(s)')]),
|
|
);
|
|
});
|
|
|
|
test(
|
|
'passes for correct Gradle coverage with multiple directories',
|
|
() async {
|
|
setDependabotCoverage(
|
|
gradleDirs: <String>[
|
|
'packages/a_plugin/android',
|
|
'packages/a_plugin/example/android/app',
|
|
],
|
|
useDirectoriesKey: true,
|
|
);
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'a_plugin',
|
|
packagesDir,
|
|
);
|
|
// Test the plugin.
|
|
plugin.directory.childDirectory('android').createSync(recursive: true);
|
|
// And its example app.
|
|
plugin.directory
|
|
.childDirectory('example')
|
|
.childDirectory('android')
|
|
.childDirectory('app')
|
|
.createSync(recursive: true);
|
|
|
|
final List<String> output = await runCapturingPrint(runner, <String>[
|
|
'dependabot-check',
|
|
]);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(<Matcher>[contains('Ran for 2 package(s)')]),
|
|
);
|
|
},
|
|
);
|
|
}
|