mirror of
https://github.com/flutter/packages.git
synced 2026-03-13 10:40:37 +08:00
Makes the analysis options changes described in
https://github.com/flutter/flutter/issues/178827:
- Adding
[omit_obvious_local_variable_types](https://dart.dev/tools/linter-rules/omit_obvious_local_variable_types)
- Adding
[specify_nonobvious_local_variable_types](https://dart.dev/tools/linter-rules/specify_nonobvious_local_variable_types)
- Adding
[specify_nonobvious_property_types](https://dart.dev/tools/linter-rules/specify_nonobvious_property_types)
- Adding
[type_annotate_public_apis](https://dart.dev/tools/linter-rules/type_annotate_public_apis)
- Removing
[always_specify_types](https://dart.dev/tools/linter-rules/always_specify_types)
After those changes, makes the following repo-wide changes:
- `dart fix --apply` in all packages and in script/tool/
- `dart format` in all packages and in script/tool/
- `update-excerpts` repo tooling command to update excerpts based on the
changes to their sources
Also updates the min Flutter/Dart SDK version to 3.35/3.9 for the
following packages, to avoid `analyze` failures in the `N-2` legacy
analysis run due to what appears to be a 3.9 change in what the Dart
analyzer continues to be an obvious local type in loop iterations:
- go_router
- google_fonts
- google_identity_services_web
- google_maps_flutter_web
- local_auth_platform_interface
- metrics_center
- multicast_dns
- pigeon
- rfw
- shared_preferences
- two_dimensional_scrollables
- vector_graphics_compiler
- mustache_template
- path_parsing
Because this is causing a significant amount of format churn already, I
took this opportunity to update the repository tooling to a min Dart SDK
of 3.8 (the N-2 stable version, so the earliest version we need the
tooling to support) to pick up the new format style, so the amount of
automated formatter change is higher in script/tool/ than in the
packages.
This does contain two manual changes (other than the repo tooling min
version):
-
d700b45c7d
changes `dynamic` to `Object?` in a few places where `dynamic` caused
analyzer warnings under the new rule set.
- Updates the repo tooling to ignore `.dart_tool/` when looking for
unexpected local `analysis_options.yaml` files, to fix issues running
the repo tool's `analyze` command locally based on recent changes in
`dart` behavior.
This does not include any CHANGELOG or version updates; even though we
normally version any changes to production code, mass automated changes
like this aren't worth the churn of releasing. This includes changes to
lib/example/main.dart and to README.md excerpts; while the style changes
will be user-visible on pub.dev, it's fine for those changes to wait for
the next release of each package.
Part of https://github.com/flutter/flutter/issues/178827
198 lines
5.4 KiB
Dart
198 lines
5.4 KiB
Dart
// Copyright 2013 The Flutter Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:file/file.dart';
|
|
import 'package:flutter_plugin_tools/src/common/gradle.dart';
|
|
import 'package:test/test.dart';
|
|
|
|
import '../mocks.dart';
|
|
import '../util.dart';
|
|
|
|
void main() {
|
|
late Directory packagesDir;
|
|
late RecordingProcessRunner processRunner;
|
|
|
|
setUp(() {
|
|
(:packagesDir, :processRunner, gitProcessRunner: _, gitDir: _) =
|
|
configureBaseCommandMocks();
|
|
});
|
|
|
|
group('isConfigured', () {
|
|
test('reports true when configured on Windows', () async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['android/gradlew.bat'],
|
|
);
|
|
final project = GradleProject(
|
|
plugin,
|
|
processRunner: processRunner,
|
|
platform: MockPlatform(isWindows: true),
|
|
);
|
|
|
|
expect(project.isConfigured(), true);
|
|
});
|
|
|
|
test('reports true when configured on non-Windows', () async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['android/gradlew'],
|
|
);
|
|
final project = GradleProject(
|
|
plugin,
|
|
processRunner: processRunner,
|
|
platform: MockPlatform(isMacOS: true),
|
|
);
|
|
|
|
expect(project.isConfigured(), true);
|
|
});
|
|
|
|
test('reports false when not configured on Windows', () async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['android/foo'],
|
|
);
|
|
final project = GradleProject(
|
|
plugin,
|
|
processRunner: processRunner,
|
|
platform: MockPlatform(isWindows: true),
|
|
);
|
|
|
|
expect(project.isConfigured(), false);
|
|
});
|
|
|
|
test('reports true when configured on non-Windows', () async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['android/foo'],
|
|
);
|
|
final project = GradleProject(
|
|
plugin,
|
|
processRunner: processRunner,
|
|
platform: MockPlatform(isMacOS: true),
|
|
);
|
|
|
|
expect(project.isConfigured(), false);
|
|
});
|
|
});
|
|
|
|
group('runCommand', () {
|
|
test('runs without arguments', () async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['android/gradlew'],
|
|
);
|
|
final project = GradleProject(
|
|
plugin,
|
|
processRunner: processRunner,
|
|
platform: MockPlatform(isMacOS: true),
|
|
);
|
|
|
|
final int exitCode = await project.runCommand('foo');
|
|
|
|
expect(exitCode, 0);
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(
|
|
plugin
|
|
.platformDirectory(FlutterPlatform.android)
|
|
.childFile('gradlew')
|
|
.path,
|
|
const <String>['foo'],
|
|
plugin.platformDirectory(FlutterPlatform.android).path,
|
|
),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('runs with arguments', () async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['android/gradlew'],
|
|
);
|
|
final project = GradleProject(
|
|
plugin,
|
|
processRunner: processRunner,
|
|
platform: MockPlatform(isMacOS: true),
|
|
);
|
|
|
|
final int exitCode = await project.runCommand(
|
|
'foo',
|
|
arguments: <String>['--bar', '--baz'],
|
|
);
|
|
|
|
expect(exitCode, 0);
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(
|
|
plugin
|
|
.platformDirectory(FlutterPlatform.android)
|
|
.childFile('gradlew')
|
|
.path,
|
|
const <String>['foo', '--bar', '--baz'],
|
|
plugin.platformDirectory(FlutterPlatform.android).path,
|
|
),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('runs with the correct wrapper on Windows', () async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['android/gradlew.bat'],
|
|
);
|
|
final project = GradleProject(
|
|
plugin,
|
|
processRunner: processRunner,
|
|
platform: MockPlatform(isWindows: true),
|
|
);
|
|
|
|
final int exitCode = await project.runCommand('foo');
|
|
|
|
expect(exitCode, 0);
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall(
|
|
plugin
|
|
.platformDirectory(FlutterPlatform.android)
|
|
.childFile('gradlew.bat')
|
|
.path,
|
|
const <String>['foo'],
|
|
plugin.platformDirectory(FlutterPlatform.android).path,
|
|
),
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('returns error codes', () async {
|
|
final RepositoryPackage plugin = createFakePlugin(
|
|
'plugin',
|
|
packagesDir,
|
|
extraFiles: <String>['android/gradlew.bat'],
|
|
);
|
|
final project = GradleProject(
|
|
plugin,
|
|
processRunner: processRunner,
|
|
platform: MockPlatform(isWindows: true),
|
|
);
|
|
|
|
processRunner.mockProcessesForExecutable[project.gradleWrapper.path] =
|
|
<FakeProcessInfo>[FakeProcessInfo(MockProcess(exitCode: 1))];
|
|
|
|
final int exitCode = await project.runCommand('foo');
|
|
|
|
expect(exitCode, 1);
|
|
});
|
|
});
|
|
}
|