mirror of
https://github.com/flutter/packages.git
synced 2026-03-13 10:40:37 +08:00
Makes the analysis options changes described in
https://github.com/flutter/flutter/issues/178827:
- Adding
[omit_obvious_local_variable_types](https://dart.dev/tools/linter-rules/omit_obvious_local_variable_types)
- Adding
[specify_nonobvious_local_variable_types](https://dart.dev/tools/linter-rules/specify_nonobvious_local_variable_types)
- Adding
[specify_nonobvious_property_types](https://dart.dev/tools/linter-rules/specify_nonobvious_property_types)
- Adding
[type_annotate_public_apis](https://dart.dev/tools/linter-rules/type_annotate_public_apis)
- Removing
[always_specify_types](https://dart.dev/tools/linter-rules/always_specify_types)
After those changes, makes the following repo-wide changes:
- `dart fix --apply` in all packages and in script/tool/
- `dart format` in all packages and in script/tool/
- `update-excerpts` repo tooling command to update excerpts based on the
changes to their sources
Also updates the min Flutter/Dart SDK version to 3.35/3.9 for the
following packages, to avoid `analyze` failures in the `N-2` legacy
analysis run due to what appears to be a 3.9 change in what the Dart
analyzer continues to be an obvious local type in loop iterations:
- go_router
- google_fonts
- google_identity_services_web
- google_maps_flutter_web
- local_auth_platform_interface
- metrics_center
- multicast_dns
- pigeon
- rfw
- shared_preferences
- two_dimensional_scrollables
- vector_graphics_compiler
- mustache_template
- path_parsing
Because this is causing a significant amount of format churn already, I
took this opportunity to update the repository tooling to a min Dart SDK
of 3.8 (the N-2 stable version, so the earliest version we need the
tooling to support) to pick up the new format style, so the amount of
automated formatter change is higher in script/tool/ than in the
packages.
This does contain two manual changes (other than the repo tooling min
version):
-
d700b45c7d
changes `dynamic` to `Object?` in a few places where `dynamic` caused
analyzer warnings under the new rule set.
- Updates the repo tooling to ignore `.dart_tool/` when looking for
unexpected local `analysis_options.yaml` files, to fix issues running
the repo tool's `analyze` command locally based on recent changes in
`dart` behavior.
This does not include any CHANGELOG or version updates; even though we
normally version any changes to production code, mass automated changes
like this aren't worth the churn of releasing. This includes changes to
lib/example/main.dart and to README.md excerpts; while the style changes
will be user-visible on pub.dev, it's fine for those changes to wait for
the next release of each package.
Part of https://github.com/flutter/flutter/issues/178827
137 lines
3.7 KiB
Dart
137 lines
3.7 KiB
Dart
// Copyright 2013 The Flutter Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:io';
|
|
|
|
import 'package:flutter_plugin_tools/src/common/git_version_finder.dart';
|
|
import 'package:mockito/mockito.dart';
|
|
import 'package:test/test.dart';
|
|
|
|
import 'package_command_test.mocks.dart';
|
|
|
|
void main() {
|
|
late List<List<String>?> gitDirCommands;
|
|
late String gitDiffResponse;
|
|
late MockGitDir gitDir;
|
|
var mergeBaseResponse = '';
|
|
|
|
setUp(() {
|
|
gitDirCommands = <List<String>?>[];
|
|
gitDiffResponse = '';
|
|
gitDir = MockGitDir();
|
|
when(
|
|
gitDir.runCommand(any, throwOnError: anyNamed('throwOnError')),
|
|
).thenAnswer((Invocation invocation) {
|
|
final arguments = invocation.positionalArguments[0]! as List<String>;
|
|
gitDirCommands.add(arguments);
|
|
String? gitStdOut;
|
|
if (arguments[0] == 'diff') {
|
|
gitStdOut = gitDiffResponse;
|
|
} else if (arguments[0] == 'merge-base') {
|
|
gitStdOut = mergeBaseResponse;
|
|
}
|
|
return Future<ProcessResult>.value(
|
|
ProcessResult(0, 0, gitStdOut ?? '', ''),
|
|
);
|
|
});
|
|
});
|
|
|
|
test('No git diff should result no files changed', () async {
|
|
final finder = GitVersionFinder(gitDir, baseSha: 'some base sha');
|
|
final List<String> changedFiles = await finder.getChangedFiles();
|
|
|
|
expect(changedFiles, isEmpty);
|
|
});
|
|
|
|
test('get correct files changed based on git diff', () async {
|
|
gitDiffResponse = '''
|
|
file1/file1.cc
|
|
file2/file2.cc
|
|
''';
|
|
final finder = GitVersionFinder(gitDir, baseSha: 'some base sha');
|
|
final List<String> changedFiles = await finder.getChangedFiles();
|
|
|
|
expect(changedFiles, equals(<String>['file1/file1.cc', 'file2/file2.cc']));
|
|
});
|
|
|
|
test('use correct base sha if not specified', () async {
|
|
mergeBaseResponse = 'shaqwiueroaaidf12312jnadf123nd';
|
|
gitDiffResponse = '''
|
|
file1/pubspec.yaml
|
|
file2/file2.cc
|
|
''';
|
|
|
|
final finder = GitVersionFinder(gitDir);
|
|
await finder.getChangedFiles();
|
|
verify(
|
|
gitDir.runCommand(<String>[
|
|
'merge-base',
|
|
'--fork-point',
|
|
'main',
|
|
'HEAD',
|
|
], throwOnError: false),
|
|
);
|
|
verify(
|
|
gitDir.runCommand(<String>[
|
|
'diff',
|
|
'--name-only',
|
|
mergeBaseResponse,
|
|
'HEAD',
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('uses correct base branch to find base sha if specified', () async {
|
|
mergeBaseResponse = 'shaqwiueroaaidf12312jnadf123nd';
|
|
gitDiffResponse = '''
|
|
file1/pubspec.yaml
|
|
file2/file2.cc
|
|
''';
|
|
|
|
final finder = GitVersionFinder(gitDir, baseBranch: 'upstream/main');
|
|
await finder.getChangedFiles();
|
|
verify(
|
|
gitDir.runCommand(<String>[
|
|
'merge-base',
|
|
'--fork-point',
|
|
'upstream/main',
|
|
'HEAD',
|
|
], throwOnError: false),
|
|
);
|
|
verify(
|
|
gitDir.runCommand(<String>[
|
|
'diff',
|
|
'--name-only',
|
|
mergeBaseResponse,
|
|
'HEAD',
|
|
]),
|
|
);
|
|
});
|
|
|
|
test('use correct base sha if specified', () async {
|
|
const customBaseSha = 'aklsjdcaskf12312';
|
|
gitDiffResponse = '''
|
|
file1/pubspec.yaml
|
|
file2/file2.cc
|
|
''';
|
|
final finder = GitVersionFinder(gitDir, baseSha: customBaseSha);
|
|
await finder.getChangedFiles();
|
|
verify(
|
|
gitDir.runCommand(<String>['diff', '--name-only', customBaseSha, 'HEAD']),
|
|
);
|
|
});
|
|
|
|
test('include uncommitted files if requested', () async {
|
|
const customBaseSha = 'aklsjdcaskf12312';
|
|
gitDiffResponse = '''
|
|
file1/pubspec.yaml
|
|
file2/file2.cc
|
|
''';
|
|
final finder = GitVersionFinder(gitDir, baseSha: customBaseSha);
|
|
await finder.getChangedFiles(includeUncommitted: true);
|
|
// The call should not have HEAD as a final argument like the default diff.
|
|
verify(gitDir.runCommand(<String>['diff', '--name-only', customBaseSha]));
|
|
});
|
|
}
|