flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-01 22:54:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_plugin_tool] Remove podspec --allow-warnings (#4839)

Browse Source
This commit is contained in:
stuartmorgan
2022-02-14 15:50:12 -05:00
committed by GitHub
parent 4aeb80aed7
commit fdba05bf57
4 changed files with 4 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
script/tool/lib/src/lint_podspecs_command.dart
View File

@ -26,13 +26,7 @@ class LintPodspecsCommand extends PackageLoopingCommand {
Directory packagesDir, {
ProcessRunner processRunner = const ProcessRunner(),
Platform platform = const LocalPlatform(),
}) : super(packagesDir, processRunner: processRunner, platform: platform) {
argParser.addMultiOption('ignore-warnings',
help:
'Do not pass --allow-warnings flag to "pod lib lint" for podspecs '
'with this basename (example: plugins with known warnings)',
valueHelp: 'podspec_file_name');
}
}) : super(packagesDir, processRunner: processRunner, platform: platform);
@override
final String name = 'podspecs';
@ -118,8 +112,6 @@ class LintPodspecsCommand extends PackageLoopingCommand {
Future<ProcessResult> _runPodLint(String podspecPath,
{required bool libraryLint}) async {
final bool allowWarnings = (getStringListArg('ignore-warnings'))
.contains(p.basenameWithoutExtension(podspecPath));
final List<String> arguments = <String>[
'lib',
'lint',
@ -127,7 +119,6 @@ class LintPodspecsCommand extends PackageLoopingCommand {
'--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices.
'--skip-tests',
'--use-modular-headers', // Flutter sets use_modular_headers! in its templates.
if (allowWarnings) '--allow-warnings',
if (libraryLint) '--use-libraries'
];