Re-sync analysis_options.yaml with flutter/flutter (#5695)

The analysis options have gotten behind; this re-syncs to the current state of flutter/flutter. For options that are non-trivial to enable, either because they are non-trivial to fix, or touch a very large number of files, they are locally disabled with clear "LOCAL CHANGE" markers so that it's obvious where we are out of sync. For options that are simple to resolve, they are enabled in the PR.

Part of https://github.com/flutter/flutter/issues/76229
This commit is contained in:
stuartmorgan
2022-05-11 11:48:47 -04:00
committed by GitHub
parent 9544f04a50
commit e8b4147fcc
14 changed files with 28 additions and 31 deletions

View File

@ -225,8 +225,8 @@ class PubspecCheckCommand extends PackageLoopingCommand {
bool _checkIssueLink(Pubspec pubspec) {
return pubspec.issueTracker
?.toString()
.startsWith(_expectedIssueLinkFormat) ==
true;
.startsWith(_expectedIssueLinkFormat) ??
false;
}
// Validates the "implements" keyword for a plugin, returning an error
@ -287,8 +287,8 @@ class PubspecCheckCommand extends PackageLoopingCommand {
.where((String package) => !dependencies.contains(package));
if (missingPackages.isNotEmpty) {
return 'The following default_packages are missing '
'corresponding dependencies:\n ' +
missingPackages.join('\n ');
'corresponding dependencies:\n'
' ${missingPackages.join('\n ')}';
}
return null;