flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-02 00:49:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_plugin_tools] Migrate 'test' to new base command (#4133)

Browse Source 
Migrates `test` to the new package looping base command.

Refactors the bulk of the logic to helpers for easier understanding of the flow.

Part of flutter/flutter#83413
This commit is contained in:
stuartmorgan
2021-07-07 08:32:03 -07:00
committed by GitHub
parent b7ff215760
commit d2bac9116b
2 changed files with 69 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

129
script/tool/lib/src/test_command.dart
View File

@ -3,15 +3,14 @@
// found in the LICENSE file.
import 'package:file/file.dart';
import 'package:path/path.dart' as p;
import 'common/core.dart';
import 'common/plugin_command.dart';
import 'common/package_looping_command.dart';
import 'common/plugin_utils.dart';
import 'common/process_runner.dart';
/// A command to run Dart unit tests for packages.
class TestCommand extends PluginCommand {
class TestCommand extends PackageLoopingCommand {
/// Creates an instance of the test command.
TestCommand(
Directory packagesDir, {
@ -20,7 +19,10 @@ class TestCommand extends PluginCommand {
argParser.addOption(
kEnableExperiment,
defaultsTo: '',
help: 'Runs the tests in Dart VM with the given experiments enabled.',
help:
'Runs Dart unit tests in Dart VM with the given experiments enabled. '
'See https://github.com/dart-lang/sdk/blob/master/docs/process/experimental-flags.md '
'for details.',
);
}
@ -32,72 +34,65 @@ class TestCommand extends PluginCommand {
'This command requires "flutter" to be in your path.';
@override
Future<void> run() async {
final List<String> failingPackages = <String>[];
await for (final Directory packageDir in getPackages()) {
final String packageName =
p.relative(packageDir.path, from: packagesDir.path);
if (!packageDir.childDirectory('test').existsSync()) {
print('SKIPPING $packageName - no test subdirectory');
continue;
}
print('RUNNING $packageName tests...');
final String enableExperiment = getStringArg(kEnableExperiment);
// `flutter test` automatically gets packages. `pub run test` does not. :(
int exitCode = 0;
if (isFlutterPackage(packageDir)) {
final List<String> args = <String>[
'test',
'--color',
if (enableExperiment.isNotEmpty)
'--enable-experiment=$enableExperiment',
];
if (isWebPlugin(packageDir)) {
args.add('--platform=chrome');
}
exitCode = await processRunner.runAndStream(
'flutter',
args,
workingDir: packageDir,
);
} else {
exitCode = await processRunner.runAndStream(
'dart',
<String>['pub', 'get'],
workingDir: packageDir,
);
if (exitCode == 0) {
exitCode = await processRunner.runAndStream(
'dart',
<String>[
'pub',
'run',
if (enableExperiment.isNotEmpty)
'--enable-experiment=$enableExperiment',
'test',
],
workingDir: packageDir,
);
}
}
if (exitCode != 0) {
failingPackages.add(packageName);
}
Future<PackageResult> runForPackage(Directory package) async {
if (!package.childDirectory('test').existsSync()) {
return PackageResult.skip('No test/ directory.');
}
print('\n\n');
if (failingPackages.isNotEmpty) {
print('Tests for the following packages are failing (see above):');
for (final String package in failingPackages) {
print(' * $package');
}
throw ToolExit(1);
bool passed;
if (isFlutterPackage(package)) {
passed = await _runFlutterTests(package);
} else {
passed = await _runDartTests(package);
}
return passed ? PackageResult.success() : PackageResult.fail();
}
/// Runs the Dart tests for a Flutter package, returning true on success.
Future<bool> _runFlutterTests(Directory package) async {
final String experiment = getStringArg(kEnableExperiment);
final int exitCode = await processRunner.runAndStream(
flutterCommand,
<String>[
'test',
'--color',
if (experiment.isNotEmpty) '--enable-experiment=$experiment',
// TODO(ditman): Remove this once all plugins are migrated to 'drive'.
if (isWebPlugin(package)) '--platform=chrome',
],
workingDir: package,
);
return exitCode == 0;
}
/// Runs the Dart tests for a non-Flutter package, returning true on success.
Future<bool> _runDartTests(Directory package) async {
// Unlike `flutter test`, `pub run test` does not automatically get
// packages
int exitCode = await processRunner.runAndStream(
'dart',
<String>['pub', 'get'],
workingDir: package,
);
if (exitCode != 0) {
printError('Unable to fetch dependencies.');
return false;
}
print('All tests are passing!');
final String experiment = getStringArg(kEnableExperiment);
exitCode = await processRunner.runAndStream(
'dart',
<String>[
'pub',
'run',
if (experiment.isNotEmpty) '--enable-experiment=$experiment',
'test',
],
workingDir: package,
);
return exitCode == 0;
}
}

11
script/tool/test/test_command_test.dart
View File

@ -73,8 +73,8 @@ void main() {
expect(
output,
containsAllInOrder(<Matcher>[
contains('Tests for the following packages are failing'),
contains(' * plugin1'),
contains('The following packages had errors:'),
contains(' plugin1'),
]));
});
@ -137,7 +137,9 @@ void main() {
expect(
output,
containsAllInOrder(<Matcher>[
contains('Tests for the following packages are failing'),
contains('Unable to fetch dependencies'),
contains('The following packages had errors:'),
contains(' a_package'),
]));
});
@ -160,7 +162,8 @@ void main() {
expect(
output,
containsAllInOrder(<Matcher>[
contains('Tests for the following packages are failing'),
contains('The following packages had errors:'),
contains(' a_package'),
]));
});