flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-06 11:29:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix the build-all exclusion list (#3552)

Browse Source 
build_all_plugins_app.sh contains an exclusion list, which currently contains almost all of the non-app-facing plugins. However, the script those exclusions are passed to expects federated plugin exclusions to be of the form plugin_name/plugin_name_subplugin_name, not just plugin_name_subplugin_name, so in practice almost nothing on that list has actually been doing anything.

This fixes the script to allow either mode of exclusion (since clearly people expect using just the name to work), and scrubs everything from the list that clearly wasn't actually needed.
This commit is contained in:
stuartmorgan
2021-02-16 06:41:53 -08:00
committed by GitHub
parent d3b50950ba
commit d12e22a68d
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
script/tool/lib/src/common.dart
View File

@ -294,8 +294,10 @@ abstract class PluginCommand extends Command<Null> {
// passed.
final String relativePath =
p.relative(subdir.path, from: packagesDir.path);
final String packageName = p.basename(subdir.path);
final String basenamePath = p.basename(entity.path);
if (!excludedPlugins.contains(basenamePath) &&
!excludedPlugins.contains(packageName) &&
!excludedPlugins.contains(relativePath) &&
(plugins.isEmpty ||
plugins.contains(relativePath) ||