flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-05-31 13:38:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_plugin_tools] Run pub get for custom-test (#5322)

Browse Source 
When running a Dart test script for `custom-test`, `pub get` needs to be
run first in order for it to work in a clean environment such as CI.

This will unblock enabling Pigeon's Dart tests in flutter/packages.
This commit is contained in:
stuartmorgan
2022-04-21 16:08:21 -04:00
committed by GitHub
parent 57e6a62dc8
commit cc32f688bb
4 changed files with 59 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
script/tool/test/custom_test_command_test.dart
View File

@ -85,6 +85,21 @@ void main() {
]));
});
test('runs pub get before running Dart test script', () async {
final Directory package = createFakePlugin('a_package', packagesDir,
extraFiles: <String>['tool/run_tests.dart']);
await runCapturingPrint(runner, <String>['custom-test']);
expect(
processRunner.recordedCalls,
containsAll(<ProcessCall>[
ProcessCall('dart', const <String>['pub', 'get'], package.path),
ProcessCall('dart', const <String>['run', 'tool/run_tests.dart'],
package.path),
]));
});
test('runs when only legacy is present', () async {
final Directory package = createFakePlugin('a_package', packagesDir,
extraFiles: <String>['run_tests.sh']);
@ -128,7 +143,8 @@ void main() {
]);
processRunner.mockProcessesForExecutable['dart'] = <io.Process>[
MockProcess(exitCode: 1),
MockProcess(exitCode: 0), // pub get
MockProcess(exitCode: 1), // test script
];
Error? commandError;
@ -146,6 +162,32 @@ void main() {
]));
});
test('fails if pub get fails', () async {
createFakePlugin('a_package', packagesDir, extraFiles: <String>[
'tool/run_tests.dart',
'run_tests.sh',
]);
processRunner.mockProcessesForExecutable['dart'] = <io.Process>[
MockProcess(exitCode: 1),
];
Error? commandError;
final List<String> output = await runCapturingPrint(
runner, <String>['custom-test'], errorHandler: (Error e) {
commandError = e;
});
expect(commandError, isA<ToolExit>());
expect(
output,
containsAllInOrder(<Matcher>[
contains('The following packages had errors:'),
contains('a_package:\n'
' Unable to get script dependencies')
]));
});
test('fails if legacy fails', () async {
final Directory package =
createFakePlugin('a_package', packagesDir, extraFiles: <String>[
@ -260,7 +302,8 @@ void main() {
]);
processRunner.mockProcessesForExecutable['dart'] = <io.Process>[
MockProcess(exitCode: 1),
MockProcess(exitCode: 0), // pub get
MockProcess(exitCode: 1), // test script
];
Error? commandError;