flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-07-04 09:38:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

[tools] Ignore analysis options files in .symlinks (#6119)

Browse Source 
When running `analyze` in a local tree that has done builds, there can be false positives of the "unexpected analysis options" check due to the .symlinks directory making other packages' analysis options show up in the check. This avoids following links to prevent those false positives.
This commit is contained in:
stuartmorgan
2024-02-14 10:11:23 -08:00
committed by GitHub
parent de9654f06b
commit cbb676a2b2
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
script/tool/lib/src/analyze_command.dart
View File

@ -66,7 +66,7 @@ class AnalyzeCommand extends PackageLoopingCommand {
/// Checks that there are no unexpected analysis_options.yaml files.
bool _hasUnexpecetdAnalysisOptions(RepositoryPackage package) {
final List<FileSystemEntity> files =
package.directory.listSync(recursive: true);
package.directory.listSync(recursive: true, followLinks: false);
for (final FileSystemEntity file in files) {
if (file.basename != 'analysis_options.yaml' &&
file.basename != '.analysis_options') {

17
script/tool/test/analyze_command_test.dart
View File

@ -273,6 +273,23 @@ void main() {
]));
});
test('ignores analysis options in the plugin .symlinks directory',
() async {
final RepositoryPackage plugin = createFakePlugin('foo', packagesDir,
extraFiles: <String>['analysis_options.yaml']);
final RepositoryPackage includingPackage =
createFakePlugin('bar', packagesDir);
// Simulate the local state of having built 'bar' if it includes 'foo'.
includingPackage.directory
.childDirectory('example')
.childDirectory('ios')
.childLink('.symlinks')
.createSync(plugin.directory.path, recursive: true);
await runCapturingPrint(
runner, <String>['analyze', '--custom-analysis', 'foo']);
});
test('takes an allow config file', () async {
final RepositoryPackage plugin = createFakePlugin('foo', packagesDir,
extraFiles: <String>['analysis_options.yaml']);