flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-03 17:48:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

[tools] fix version check command not working for new packages (#3818)

Browse Source
This commit is contained in:
Chris Yang
2021-04-21 16:40:20 -07:00
committed by GitHub
parent 63d42fcdb9
commit c4170d8f64
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
script/tool/lib/src/version_check_command.dart
View File

@ -3,7 +3,6 @@
// found in the LICENSE file. // found in the LICENSE file.
import 'dart:async'; import 'dart:async';
import 'dart:io' as io;
import 'package:meta/meta.dart'; import 'package:meta/meta.dart';
import 'package:file/file.dart'; import 'package:file/file.dart';
@ -121,6 +120,7 @@ class VersionCheckCommand extends PluginCommand {
if (masterVersion == null) { if (masterVersion == null) {
print('${indentation}Unable to find pubspec in master. ' print('${indentation}Unable to find pubspec in master. '
'Safe to ignore if the project is new.'); 'Safe to ignore if the project is new.');
continue;
} }
if (masterVersion == headVersion) { if (masterVersion == headVersion) {

20
script/tool/test/version_check_test.dart
View File

@ -61,6 +61,9 @@ void main() {
} else if (invocation.positionalArguments[0][0] == 'show') { } else if (invocation.positionalArguments[0][0] == 'show') {
final String response = final String response =
gitShowResponses[invocation.positionalArguments[0][1]]; gitShowResponses[invocation.positionalArguments[0][1]];
if (response == null) {
throw const io.ProcessException('git', <String>['show']);
}
when<String>(mockProcessResult.stdout as String).thenReturn(response); when<String>(mockProcessResult.stdout as String).thenReturn(response);
} else if (invocation.positionalArguments[0][0] == 'merge-base') { } else if (invocation.positionalArguments[0][0] == 'merge-base') {
when<String>(mockProcessResult.stdout as String).thenReturn('abc123'); when<String>(mockProcessResult.stdout as String).thenReturn('abc123');
@ -150,6 +153,23 @@ void main() {
); );
}); });
test('allows valid version for new package.', () async {
createFakePlugin('plugin', includeChangeLog: true, includeVersion: true);
gitDiffResponse = 'packages/plugin/pubspec.yaml';
gitShowResponses = <String, String>{
'HEAD:packages/plugin/pubspec.yaml': 'version: 1.0.0',
};
final List<String> output =
await runCapturingPrint(runner, <String>['version-check']);
expect(
output,
containsAllInOrder(<String>[
'No version check errors found!',
]),
);
});
test('denies invalid version without explicit base-sha', () async { test('denies invalid version without explicit base-sha', () async {
createFakePlugin('plugin', includeChangeLog: true, includeVersion: true); createFakePlugin('plugin', includeChangeLog: true, includeVersion: true);
gitDiffResponse = 'packages/plugin/pubspec.yaml'; gitDiffResponse = 'packages/plugin/pubspec.yaml';