flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-21 15:20:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove support for bypassing, or prompting for, git tagging (#4275)

Browse Source 
We never want a plugin to be published without tagging the release, so there's no reason to support the added complexity of these flags. Similarly, once someone has confirmed publishing, we don't want to give them an opt-out for doing the tag.
This commit is contained in:
stuartmorgan
2021-08-27 11:36:03 -04:00
committed by GitHub
parent dcf97f741f
commit bc3e0ecf85
4 changed files with 51 additions and 173 deletions
Download Patch File Download Diff File Expand all files Collapse all files

150
script/tool/test/publish_plugin_command_test.dart
View File

@ -80,8 +80,8 @@ void main() {
test('requires an existing flag', () async {
Error? commandError;
final List<String> output = await runCapturingPrint(commandRunner,
<String>['publish-plugin', '--package', 'iamerror', '--no-push-tags'],
final List<String> output = await runCapturingPrint(
commandRunner, <String>['publish-plugin', '--package', 'iamerror'],
errorHandler: (Error e) {
commandError = e;
});
@ -100,8 +100,8 @@ void main() {
];
Error? commandError;
final List<String> output = await runCapturingPrint(commandRunner,
<String>['publish-plugin', '--package', 'foo', '--no-push-tags'],
final List<String> output = await runCapturingPrint(
commandRunner, <String>['publish-plugin', '--package', 'foo'],
errorHandler: (Error e) {
commandError = e;
});
@ -141,56 +141,6 @@ void main() {
'Unable to find URL for remote upstream; cannot push tags'),
]));
});
test("doesn't validate the remote if it's not pushing tags", () async {
createFakePlugin('foo', packagesDir, examples: <String>[]);
// Checking the remote should fail.
processRunner.mockProcessesForExecutable['git-remote'] = <io.Process>[
MockProcess(exitCode: 1),
];
final List<String> output = await runCapturingPrint(
commandRunner, <String>[
'publish-plugin',
'--package',
'foo',
'--no-push-tags',
'--no-tag-release'
]);
expect(
output,
containsAllInOrder(<Matcher>[
contains('Running `pub publish ` in /packages/foo...'),
contains('Package published!'),
contains('Released [foo] successfully.'),
]));
});
test('can publish non-flutter package', () async {
const String packageName = 'a_package';
createFakePackage(packageName, packagesDir);
final List<String> output = await runCapturingPrint(
commandRunner, <String>[
'publish-plugin',
'--package',
packageName,
'--no-push-tags',
'--no-tag-release'
]);
expect(
output,
containsAllInOrder(
<Matcher>[
contains('Running `pub publish ` in /packages/a_package...'),
contains('Package published!'),
],
),
);
});
});
group('Publishes package', () {
@ -206,13 +156,7 @@ void main() {
];
final List<String> output = await runCapturingPrint(
commandRunner, <String>[
'publish-plugin',
'--package',
'foo',
'--no-push-tags',
'--no-tag-release'
]);
commandRunner, <String>['publish-plugin', '--package', 'foo']);
expect(
output,
@ -227,13 +171,8 @@ void main() {
mockStdin.mockUserInputs.add(utf8.encode('user input'));
await runCapturingPrint(commandRunner, <String>[
'publish-plugin',
'--package',
'foo',
'--no-push-tags',
'--no-tag-release'
]);
await runCapturingPrint(
commandRunner, <String>['publish-plugin', '--package', 'foo']);
expect(processRunner.mockPublishProcess.stdinMock.lines,
contains('user input'));
@ -247,8 +186,6 @@ void main() {
'publish-plugin',
'--package',
'foo',
'--no-push-tags',
'--no-tag-release',
'--pub-publish-flags',
'--dry-run,--server=foo'
]);
@ -272,8 +209,6 @@ void main() {
'publish-plugin',
'--package',
'foo',
'--no-push-tags',
'--no-tag-release',
'--skip-confirmation',
'--pub-publish-flags',
'--server=foo'
@ -300,8 +235,6 @@ void main() {
'publish-plugin',
'--package',
'foo',
'--no-push-tags',
'--no-tag-release',
], errorHandler: (Error e) {
commandError = e;
});
@ -324,8 +257,6 @@ void main() {
'--package',
'foo',
'--dry-run',
'--no-push-tags',
'--no-tag-release',
]);
expect(
@ -340,6 +271,28 @@ void main() {
'Done!'
]));
});
test('can publish non-flutter package', () async {
const String packageName = 'a_package';
createFakePackage(packageName, packagesDir);
final List<String> output =
await runCapturingPrint(commandRunner, <String>[
'publish-plugin',
'--package',
packageName,
]);
expect(
output,
containsAllInOrder(
<Matcher>[
contains('Running `pub publish ` in /packages/a_package...'),
contains('Package published!'),
],
),
);
});
});
group('Tags release', () {
@ -349,7 +302,6 @@ void main() {
'publish-plugin',
'--package',
'foo',
'--no-push-tags',
]);
expect(processRunner.recordedCalls,
@ -369,7 +321,6 @@ void main() {
'publish-plugin',
'--package',
'foo',
'--no-push-tags',
], errorHandler: (Error e) {
commandError = e;
});
@ -388,25 +339,6 @@ void main() {
});
group('Pushes tags', () {
test('requires user confirmation', () async {
createFakePlugin('foo', packagesDir, examples: <String>[]);
mockStdin.readLineOutput = 'help';
Error? commandError;
final List<String> output =
await runCapturingPrint(commandRunner, <String>[
'publish-plugin',
'--package',
'foo',
], errorHandler: (Error e) {
commandError = e;
});
expect(commandError, isA<ToolExit>());
expect(output, contains('Tag push canceled.'));
});
test('to upstream by default', () async {
createFakePlugin('foo', packagesDir, examples: <String>[]);
@ -502,30 +434,6 @@ void main() {
contains('Released [foo] successfully.'),
]));
});
test('only if tagging and pushing to remotes are both enabled', () async {
createFakePlugin('foo', packagesDir, examples: <String>[]);
final List<String> output =
await runCapturingPrint(commandRunner, <String>[
'publish-plugin',
'--package',
'foo',
'--no-tag-release',
]);
expect(
processRunner.recordedCalls
.map((ProcessCall call) => call.executable),
isNot(contains('git-push')));
expect(
output,
containsAllInOrder(<Matcher>[
contains('Running `pub publish ` in /packages/foo...'),
contains('Package published!'),
contains('Released [foo] successfully.'),
]));
});
});
group('Auto release (all-changed flag)', () {