flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-17 10:58:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ci] Add more dev dependency checks, and fix errors (#6563)

Browse Source 
- Adds `build_runner`, `mockito`, and `pigeon` to the list of dependencies that we expect to only be in dev_dependencies.
- Fixes the error message for violations; I had missed in initial review that the errorr message was the same as the one for non-repo-local depndencies, making it misleading about what the problem was and how to fix it. (Also fixed the indentation, which had always been wrong.)
- Fixes `camera_avfoundation`, which had a violation introduced in my recent PR to start the Pigeon conversion.

See https://github.com/flutter/flutter/issues/117905
This commit is contained in:
stuartmorgan
2024-04-18 17:43:04 -04:00
committed by GitHub
parent b0e6d7f3b8
commit bb82cb79b9
4 changed files with 92 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

96
script/tool/test/pubspec_check_command_test.dart
View File

@ -1611,10 +1611,10 @@ ${_topicsSection()}
output,
containsAllInOrder(<Matcher>[
contains(
'The following unexpected non-local dependencies were found:\n'
' bad_dependency\n'
'Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies '
'for more information and next steps.'),
' The following unexpected non-local dependencies were found:\n'
' bad_dependency\n'
' Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies\n'
' for more information and next steps.'),
]),
);
});
@ -1643,10 +1643,10 @@ ${_topicsSection()}
output,
containsAllInOrder(<Matcher>[
contains(
'The following unexpected non-local dependencies were found:\n'
' bad_dependency\n'
'Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies '
'for more information and next steps.'),
' The following unexpected non-local dependencies were found:\n'
' bad_dependency\n'
' Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies\n'
' for more information and next steps.'),
]),
);
});
@ -1727,54 +1727,68 @@ ${_topicsSection()}
output,
containsAllInOrder(<Matcher>[
contains(
'The following unexpected non-local dependencies were found:\n'
' allow_pinned\n'
'Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies '
'for more information and next steps.'),
' The following unexpected non-local dependencies were found:\n'
' allow_pinned\n'
' Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies\n'
' for more information and next steps.'),
]),
);
});
test('fails when integration_test, flutter_test or test are used in non dev dependency',
() async {
final RepositoryPackage package =
createFakePackage('a_package', packagesDir, examples: <String>[]);
group('dev dependencies', () {
const List<String> packages = <String>[
'build_runner',
'integration_test',
'flutter_test',
'mockito',
'pigeon',
'test',
];
for (final String dependency in packages) {
test('fails when $dependency is used in non dev dependency',
() async {
final RepositoryPackage package = createFakePackage(
'a_package', packagesDir,
examples: <String>[]);
package.pubspecFile.writeAsStringSync('''
final String version =
dependency == 'integration_test' || dependency == 'flutter_test'
? '{ sdk: flutter }'
: '1.0.0';
package.pubspecFile.writeAsStringSync('''
${_headerSection('a_package')}
${_environmentSection()}
${_dependenciesSection(<String>[
'integration_test: \n sdk: flutter',
'flutter_test: \n sdk: flutter',
'test: 1.0.0'
])}
'$dependency: $version',
])}
${_devDependenciesSection()}
${_topicsSection()}
''');
Error? commandError;
final List<String> output = await runCapturingPrint(runner, <String>[
'pubspec-check',
], errorHandler: (Error e) {
commandError = e;
});
Error? commandError;
final List<String> output =
await runCapturingPrint(runner, <String>[
'pubspec-check',
], errorHandler: (Error e) {
commandError = e;
});
expect(commandError, isA<ToolExit>());
expect(
output,
containsAllInOrder(<Matcher>[
contains(
'The following unexpected non-local dependencies were found:\n'
' test\n'
' integration_test\n'
' flutter_test\n'
'Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies '
'for more information and next steps.'),
]),
);
expect(commandError, isA<ToolExit>());
expect(
output,
containsAllInOrder(<Matcher>[
contains(
' The following dev dependencies were found in the dependencies section:\n'
' $dependency\n'
' Please move them to dev_dependencies.'),
]),
);
});
}
});
test('passes when integration_test or flutter_test are used in non published package',
test(
'passes when integration_test or flutter_test are used in non published package',
() async {
final RepositoryPackage package =
createFakePackage('a_package', packagesDir, examples: <String>[]);