flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-08-06 17:28:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ci] Add more dev dependency checks, and fix errors (#6563)

Browse Source 
- Adds `build_runner`, `mockito`, and `pigeon` to the list of dependencies that we expect to only be in dev_dependencies.
- Fixes the error message for violations; I had missed in initial review that the errorr message was the same as the one for non-repo-local depndencies, making it misleading about what the problem was and how to fix it. (Also fixed the indentation, which had always been wrong.)
- Fixes `camera_avfoundation`, which had a violation introduced in my recent PR to start the Pigeon conversion.

See https://github.com/flutter/flutter/issues/117905
This commit is contained in:
stuartmorgan
2024-04-18 17:43:04 -04:00
committed by GitHub
parent b0e6d7f3b8
commit bb82cb79b9
4 changed files with 92 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
script/tool/lib/src/pubspec_check_command.dart
View File

@ -200,7 +200,10 @@ class PubspecCheckCommand extends PackageLoopingCommand {
final String? dependenciesError = _checkDependencies(pubspec);
if (dependenciesError != null) {
printError('$indentation$dependenciesError');
printError(dependenciesError
.split('\n')
.map((String line) => '$indentation$line')
.join('\n'));
passing = false;
}
@ -542,6 +545,7 @@ class PubspecCheckCommand extends PackageLoopingCommand {
// there are any that aren't allowed.
String? _checkDependencies(Pubspec pubspec) {
final Set<String> badDependencies = <String>{};
final Set<String> misplacedDevDependencies = <String>{};
// Shipped dependencies.
for (final Map<String, Dependency> dependencies
in <Map<String, Dependency>>[
@ -556,24 +560,40 @@ class PubspecCheckCommand extends PackageLoopingCommand {
}
// Ensure that dev-only dependencies aren't in `dependencies`.
const Set<String> devOnlyDependencies = <String>{'integration_test', 'test', 'flutter_test'};
// Non-published packages like pidgeon subpackages are allowed to violate
const Set<String> devOnlyDependencies = <String>{
'build_runner',
'integration_test',
'flutter_test',
'mockito',
'pigeon',
'test',
};
// Non-published packages like pigeon subpackages are allowed to violate
// the dev only dependencies rule.
if (pubspec.publishTo != 'none') {
pubspec.dependencies.forEach((String name, Dependency dependency) {
if (devOnlyDependencies.contains(name)) {
badDependencies.add(name);
misplacedDevDependencies.add(name);
}
});
}
if (badDependencies.isEmpty) {
return null;
}
return 'The following unexpected non-local dependencies were found:\n'
'${badDependencies.map((String name) => ' $name').join('\n')}\n'
'Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies '
'for more information and next steps.';
final List<String> errors = <String>[
if (badDependencies.isNotEmpty)
'''
The following unexpected non-local dependencies were found:
${badDependencies.map((String name) => ' $name').join('\n')}
Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies
for more information and next steps.
''',
if (misplacedDevDependencies.isNotEmpty)
'''
The following dev dependencies were found in the dependencies section:
${misplacedDevDependencies.map((String name) => ' $name').join('\n')}
Please move them to dev_dependencies.
''',
];
return errors.isEmpty ? null : errors.join('\n\n');
}
// Checks whether a given dependency is allowed.