[flutter_plugin_tools] Remove most exitOnError:true usage (#4130)

The intent of package-looping commands is that we always want to run them for all the targeted packages, accumulating failures, and then report them all at the end, so we don't end up with the problem of only finding errors one at a time. However, some of them were using `exitOnError: true` for the underlying commands, causing the first error to be fatal to the test.

This PR:
- Removes all use of `exitOnError: true` from the package-looping commands. (It's still used in `format`, but fixing that is a larger issue, and less important due to the way `format` is currently structured.)
- Fixes the mock process runner used in our tests to correctly simulate `exitOrError: true`; the fact that it didn't was hiding this problem in test (e.g., `drive-examples` had a test that asserted that all failures were summarized correctly, which passed because in tests it was behaving as if `exitOnError` were false)
- Adjusts the mock process runner to allow setting a list of mock result for a specific executable instead of one result for all calls to anything, in order to fix some tests that were broken by the two changes above and unfixable without this (e.g., a test of a command that had been calling one executable with `exitOnError: true` then another with ``exitOnError: false`, where the test was asserting things about the second call failing, which only worked because the first call's failure wasn't actually checked). To limit the scope of the PR, the old method of setting a single result for all calls is still supported for now as a fallback.
- Fixes the fact that the mock `run` and `runAndStream` had opposite default exit code behavior when no mock process was set (since that caused me a lot of confusion while fixing the above until I figured it out).
This commit is contained in:
stuartmorgan
2021-07-02 07:50:24 -07:00
committed by GitHub
parent 4b77aaff42
commit b9f601cc7b
11 changed files with 160 additions and 28 deletions

View File

@ -13,6 +13,8 @@ import 'common/core.dart';
import 'common/package_looping_command.dart';
import 'common/process_runner.dart';
const int _exitGcloudAuthFailed = 2;
/// A command to run tests via Firebase test lab.
class FirebaseTestLabCommand extends PackageLoopingCommand {
/// Creates an instance of the test runner command.
@ -84,16 +86,19 @@ class FirebaseTestLabCommand extends PackageLoopingCommand {
if (serviceKey.isEmpty) {
print('No --service-key provided; skipping gcloud authorization');
} else {
await processRunner.run(
final io.ProcessResult result = await processRunner.run(
'gcloud',
<String>[
'auth',
'activate-service-account',
'--key-file=$serviceKey',
],
exitOnError: true,
logOnError: true,
);
if (result.exitCode != 0) {
printError('Unable to activate gcloud account.');
throw ToolExit(_exitGcloudAuthFailed);
}
final int exitCode = await processRunner.runAndStream('gcloud', <String>[
'config',
'set',