mirror of
https://github.com/flutter/packages.git
synced 2025-06-28 13:47:29 +08:00
[flutter_plugin_tools] Migrate more commands to NNBD (#4026)
Migrates: - `all_plugins_app` - `podspecs` - `firebase-test-lab` Minor functional changes to `firebase-test-lab` based on issues highlighted by the migration: - The build ID used in the path is now a) passable, and b) given a fallback value in the path that isn't "null" - Flag setup will no longer assume that `$HOME` must be set in the environment. - Adds a --build-id flag to `firebase-test-lab` instead of hard-coding the use of `CIRRUS_BUILD_ID`. The default is still `CIRRUS_BUILD_ID` so no CI changes are needed. Part of https://github.com/flutter/flutter/issues/81912
This commit is contained in:
stuartmorgan
@ -2,8 +2,6 @@
|
||||
// Use of this source code is governed by a BSD-style license that can be
|
||||
// found in the LICENSE file.
|
||||
|
||||
// @dart=2.9
|
||||
|
||||
import 'dart:io';
|
||||
|
||||
import 'package:args/command_runner.dart';
|
||||
@ -19,10 +17,10 @@ import 'util.dart';
|
||||
void main() {
|
||||
group('$FirebaseTestLabCommand', () {
|
||||
FileSystem fileSystem;
|
||||
Directory packagesDir;
|
||||
List<String> printedMessages;
|
||||
CommandRunner<void> runner;
|
||||
RecordingProcessRunner processRunner;
|
||||
late Directory packagesDir;
|
||||
late List<String> printedMessages;
|
||||
late CommandRunner<void> runner;
|
||||
late RecordingProcessRunner processRunner;
|
||||
|
||||
setUp(() {
|
||||
fileSystem = MemoryFileSystem();
|
||||
@ -31,7 +29,7 @@ void main() {
|
||||
processRunner = RecordingProcessRunner();
|
||||
final FirebaseTestLabCommand command = FirebaseTestLabCommand(packagesDir,
|
||||
processRunner: processRunner,
|
||||
print: (Object message) => printedMessages.add(message.toString()));
|
||||
print: (Object? message) => printedMessages.add(message.toString()));
|
||||
|
||||
runner = CommandRunner<void>(
|
||||
'firebase_test_lab_command', 'Test for $FirebaseTestLabCommand');
|
||||
@ -97,6 +95,8 @@ void main() {
|
||||
'model=seoul,version=26',
|
||||
'--test-run-id',
|
||||
'testRunId',
|
||||
'--build-id',
|
||||
'buildId',
|
||||
]);
|
||||
|
||||
expect(
|
||||
@ -130,7 +130,7 @@ void main() {
|
||||
'/packages/plugin/example/android'),
|
||||
ProcessCall(
|
||||
'gcloud',
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/null/testRunId/0/ --device model=flame,version=29 --device model=seoul,version=26'
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=flame,version=29 --device model=seoul,version=26'
|
||||
.split(' '),
|
||||
'/packages/plugin/example'),
|
||||
ProcessCall(
|
||||
@ -140,7 +140,7 @@ void main() {
|
||||
'/packages/plugin/example/android'),
|
||||
ProcessCall(
|
||||
'gcloud',
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/null/testRunId/1/ --device model=flame,version=29 --device model=seoul,version=26'
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/1/ --device model=flame,version=29 --device model=seoul,version=26'
|
||||
.split(' '),
|
||||
'/packages/plugin/example'),
|
||||
ProcessCall(
|
||||
@ -150,7 +150,7 @@ void main() {
|
||||
'/packages/plugin/example/android'),
|
||||
ProcessCall(
|
||||
'gcloud',
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/null/testRunId/2/ --device model=flame,version=29 --device model=seoul,version=26'
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/2/ --device model=flame,version=29 --device model=seoul,version=26'
|
||||
.split(' '),
|
||||
'/packages/plugin/example'),
|
||||
ProcessCall(
|
||||
@ -160,7 +160,7 @@ void main() {
|
||||
'/packages/plugin/example/android'),
|
||||
ProcessCall(
|
||||
'gcloud',
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/null/testRunId/3/ --device model=flame,version=29 --device model=seoul,version=26'
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/3/ --device model=flame,version=29 --device model=seoul,version=26'
|
||||
.split(' '),
|
||||
'/packages/plugin/example'),
|
||||
]),
|
||||
@ -196,6 +196,8 @@ void main() {
|
||||
'model=flame,version=29',
|
||||
'--test-run-id',
|
||||
'testRunId',
|
||||
'--build-id',
|
||||
'buildId',
|
||||
'--enable-experiment=exp1',
|
||||
]);
|
||||
|
||||
@ -221,7 +223,7 @@ void main() {
|
||||
'/packages/plugin/example/android'),
|
||||
ProcessCall(
|
||||
'gcloud',
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/null/testRunId/0/ --device model=flame,version=29'
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=flame,version=29'
|
||||
.split(' '),
|
||||
'/packages/plugin/example'),
|
||||
ProcessCall(
|
||||
@ -231,7 +233,7 @@ void main() {
|
||||
'/packages/plugin/example/android'),
|
||||
ProcessCall(
|
||||
'gcloud',
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/null/testRunId/1/ --device model=flame,version=29'
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/1/ --device model=flame,version=29'
|
||||
.split(' '),
|
||||
'/packages/plugin/example'),
|
||||
ProcessCall(
|
||||
@ -241,7 +243,7 @@ void main() {
|
||||
'/packages/plugin/example/android'),
|
||||
ProcessCall(
|
||||
'gcloud',
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/null/testRunId/2/ --device model=flame,version=29'
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/2/ --device model=flame,version=29'
|
||||
.split(' '),
|
||||
'/packages/plugin/example'),
|
||||
ProcessCall(
|
||||
@ -251,7 +253,7 @@ void main() {
|
||||
'/packages/plugin/example/android'),
|
||||
ProcessCall(
|
||||
'gcloud',
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/null/testRunId/3/ --device model=flame,version=29'
|
||||
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 5m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/3/ --device model=flame,version=29'
|
||||
.split(' '),
|
||||
'/packages/plugin/example'),
|
||||
]),
|
||||
|
||||
Reference in New Issue
Block a user