flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-05-26 09:48:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update build-all test for null-safe template (#3773)

Browse Source 
Flutter master now creates NNBD code when running 'flutter create', so
the generated pubspec for build_all needs to use a compatible SDK
version. This updates from 2.0.0 to 2.12.0.

Also includes a test for this, which involved setting up tests for the
file, and doing some refactoring to make the command testable. As a
result, this fixes https://github.com/flutter/flutter/issues/61049
(although more test backfill is needed).
This commit is contained in:
stuartmorgan
2021-03-30 13:34:20 -07:00
committed by GitHub
parent b98ea9175b
commit b8b7ef5cd5
3 changed files with 131 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

91
script/tool/test/create_all_plugins_app_command_test.dart Normal file
View File

@ -0,0 +1,91 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:args/command_runner.dart';
import 'package:file/file.dart';
import 'package:file/local.dart';
import 'package:flutter_plugin_tools/src/create_all_plugins_app_command.dart';
import 'package:test/test.dart';
import 'util.dart';
void main() {
group('$CreateAllPluginsAppCommand', () {
CommandRunner<Null> runner;
FileSystem fileSystem;
Directory testRoot;
Directory packagesDir;
Directory appDir;
setUp(() {
// Since the core of this command is a call to 'flutter create', the test
// has to use the real filesystem. Put everything possible in a unique
// temporary to minimize affect on the host system.
fileSystem = LocalFileSystem();
testRoot = fileSystem.systemTempDirectory.createTempSync();
packagesDir = testRoot.childDirectory('packages');
final CreateAllPluginsAppCommand command = CreateAllPluginsAppCommand(
packagesDir,
fileSystem,
pluginsRoot: testRoot,
);
appDir = command.appDirectory;
runner = CommandRunner<Null>(
'create_all_test', 'Test for $CreateAllPluginsAppCommand');
runner.addCommand(command);
});
tearDown(() {
testRoot.deleteSync(recursive: true);
});
test('pubspec includes all plugins', () async {
createFakePlugin('plugina', packagesDirectory: packagesDir);
createFakePlugin('pluginb', packagesDirectory: packagesDir);
createFakePlugin('pluginc', packagesDirectory: packagesDir);
await runner.run(<String>['all-plugins-app']);
final List<String> pubspec =
appDir.childFile('pubspec.yaml').readAsLinesSync();
expect(
pubspec,
containsAll(<Matcher>[
contains(RegExp('path: .*/packages/plugina')),
contains(RegExp('path: .*/packages/pluginb')),
contains(RegExp('path: .*/packages/pluginc')),
]));
});
test('pubspec has overrides for all plugins', () async {
createFakePlugin('plugina', packagesDirectory: packagesDir);
createFakePlugin('pluginb', packagesDirectory: packagesDir);
createFakePlugin('pluginc', packagesDirectory: packagesDir);
await runner.run(<String>['all-plugins-app']);
final List<String> pubspec =
appDir.childFile('pubspec.yaml').readAsLinesSync();
expect(
pubspec,
containsAllInOrder(<Matcher>[
contains('dependency_overrides:'),
contains(RegExp('path: .*/packages/plugina')),
contains(RegExp('path: .*/packages/pluginb')),
contains(RegExp('path: .*/packages/pluginc')),
]));
});
test('pubspec is compatible with null-safe app code', () async {
createFakePlugin('plugina', packagesDirectory: packagesDir);
await runner.run(<String>['all-plugins-app']);
final String pubspec =
appDir.childFile('pubspec.yaml').readAsStringSync();
expect(pubspec, contains(RegExp('sdk:\\s*(?:["\']>=|[^])2\\.12\\.')));
});
});
}