flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-08-06 08:53:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

[tool] Switch PR description overrides over to labels (#6145)

Browse Source
This commit is contained in:
stuartmorgan
2022-07-27 13:59:04 -04:00
committed by GitHub
parent f2d9f51dd1
commit b83209e3e5
4 changed files with 109 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

117
script/tool/test/version_check_command_test.dart
View File

@ -364,35 +364,25 @@ void main() {
]));
});
test('allows breaking changes to platform interfaces with explanation',
test('allows breaking changes to platform interfaces with override label',
() async {
createFakePlugin('plugin_platform_interface', packagesDir,
version: '2.0.0');
processRunner.mockProcessesForExecutable['git-show'] = <io.Process>[
MockProcess(stdout: 'version: 1.0.0'),
];
final File changeDescriptionFile =
fileSystem.file('change_description.txt');
changeDescriptionFile.writeAsStringSync('''
Some general PR description
## Breaking change justification
This is necessary because of X, Y, and Z
## Another section''');
final List<String> output = await runCapturingPrint(runner, <String>[
'version-check',
'--base-sha=main',
'--change-description-file=${changeDescriptionFile.path}'
'--pr-labels=some label,override: allow breaking change,another-label'
]);
expect(
output,
containsAllInOrder(<Matcher>[
contains('Allowing breaking change to plugin_platform_interface '
'due to "## Breaking change justification" in the change '
'description.'),
'due to the "override: allow breaking change" label.'),
contains('Ran for 1 package(s) (1 with warnings)'),
]),
);
@ -408,42 +398,6 @@ This is necessary because of X, Y, and Z
]));
});
test('throws if a nonexistent change description file is specified',
() async {
createFakePlugin('plugin_platform_interface', packagesDir,
version: '2.0.0');
processRunner.mockProcessesForExecutable['git-show'] = <io.Process>[
MockProcess(stdout: 'version: 1.0.0'),
];
Error? commandError;
final List<String> output = await runCapturingPrint(runner, <String>[
'version-check',
'--base-sha=main',
'--change-description-file=a_missing_file.txt'
], errorHandler: (Error e) {
commandError = e;
});
expect(commandError, isA<ToolExit>());
expect(
output,
containsAllInOrder(<Matcher>[
contains('No such file: a_missing_file.txt'),
]),
);
expect(
processRunner.recordedCalls,
containsAllInOrder(const <ProcessCall>[
ProcessCall(
'git-show',
<String>[
'main:packages/plugin_platform_interface/pubspec.yaml'
],
null)
]));
});
test('allows breaking changes to platform interfaces with bypass flag',
() async {
createFakePlugin('plugin_platform_interface', packagesDir,
@ -965,7 +919,7 @@ packages/plugin/CHANGELOG.md
);
});
test('allows missing version change with justification', () async {
test('allows missing version change with override label', () async {
final RepositoryPackage plugin =
createFakePlugin('plugin', packagesDir, version: '1.0.0');
@ -985,23 +939,16 @@ packages/plugin/pubspec.yaml
'''),
];
final File changeDescriptionFile =
fileSystem.file('change_description.txt');
changeDescriptionFile.writeAsStringSync('''
Some general PR description
No version change: Code change is only to implementation comments.
''');
final List<String> output =
await _runWithMissingChangeDetection(<String>[
'--change-description-file=${changeDescriptionFile.path}'
'--pr-labels=some label,override: no versioning needed,another-label'
]);
expect(
output,
containsAllInOrder(<Matcher>[
contains('Ignoring lack of version change due to '
'"No version change:" in the change description.'),
contains('Ignoring lack of version change due to the '
'"override: no versioning needed" label.'),
]),
);
});
@ -1124,28 +1071,56 @@ packages/plugin/example/lib/foo.dart
'''),
];
final File changeDescriptionFile =
fileSystem.file('change_description.txt');
changeDescriptionFile.writeAsStringSync('''
Some general PR description
No CHANGELOG change: Code change is only to implementation comments.
''');
final List<String> output =
await _runWithMissingChangeDetection(<String>[
'--change-description-file=${changeDescriptionFile.path}'
'--pr-labels=some label,override: no changelog needed,another-label'
]);
expect(
output,
containsAllInOrder(<Matcher>[
contains('Ignoring lack of CHANGELOG update due to '
'"No CHANGELOG change:" in the change description.'),
contains('Ignoring lack of CHANGELOG update due to the '
'"override: no changelog needed" label.'),
]),
);
});
group('dependabot', () {
test('throws if a nonexistent change description file is specified',
() async {
final RepositoryPackage plugin =
createFakePlugin('plugin', packagesDir, version: '1.0.0');
const String changelog = '''
## 1.0.0
* Some changes.
''';
plugin.changelogFile.writeAsStringSync(changelog);
processRunner.mockProcessesForExecutable['git-show'] = <io.Process>[
MockProcess(stdout: 'version: 1.0.0'),
];
processRunner.mockProcessesForExecutable['git-diff'] = <io.Process>[
MockProcess(stdout: '''
packages/plugin/android/build.gradle
'''),
];
Error? commandError;
final List<String> output = await _runWithMissingChangeDetection(
<String>['--change-description-file=a_missing_file.txt'],
errorHandler: (Error e) {
commandError = e;
});
expect(commandError, isA<ToolExit>());
expect(
output,
containsAllInOrder(<Matcher>[
contains('No such file: a_missing_file.txt'),
]),
);
});
test('allows missing version and CHANGELOG change for mockito',
() async {
final RepositoryPackage plugin =
@ -1308,8 +1283,6 @@ packages/plugin/android/build.gradle
);
});
// Tests workaround for
// https://github.com/cirruslabs/cirrus-ci-docs/issues/1029.
test('allow list works for commit messages', () async {
final RepositoryPackage plugin =
createFakePlugin('plugin', packagesDir, version: '1.0.0');