From a9ba0fd7807c941015ecd4c1925b58204c033ac4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marin=20Mika=C3=ABl?= <41113988+MarinMikael@users.noreply.github.com> Date: Fri, 8 Dec 2023 08:26:19 +0900 Subject: [PATCH] [go_router] Fix(docs): Typo in Update navigation.md (#5545) Fixed a typo in navigation.md: ```dart context.go('/123, extra: 'abc'); ``` to ```dart context.go('/123', extra: 'abc'); ``` *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* --- packages/go_router/CHANGELOG.md | 4 ++++ packages/go_router/doc/navigation.md | 2 +- packages/go_router/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/go_router/CHANGELOG.md b/packages/go_router/CHANGELOG.md index b62f174d7f..d7d52ddf96 100644 --- a/packages/go_router/CHANGELOG.md +++ b/packages/go_router/CHANGELOG.md @@ -1,3 +1,7 @@ +## 12.1.3 + +* Fixes a typo in `navigation.md`. + ## 12.1.2 * Fixes an incorrect use of `extends` for Dart 3 compatibility. diff --git a/packages/go_router/doc/navigation.md b/packages/go_router/doc/navigation.md index f351d2b821..b0ad5249f8 100644 --- a/packages/go_router/doc/navigation.md +++ b/packages/go_router/doc/navigation.md @@ -88,7 +88,7 @@ onTap: () => context.pop(true) You can provide additional data along with navigation. ```dart -context.go('/123, extra: 'abc'); +context.go('/123', extra: 'abc'); ``` and retrieve the data from GoRouterState diff --git a/packages/go_router/pubspec.yaml b/packages/go_router/pubspec.yaml index b0360ff601..42e8e8e7ba 100644 --- a/packages/go_router/pubspec.yaml +++ b/packages/go_router/pubspec.yaml @@ -1,7 +1,7 @@ name: go_router description: A declarative router for Flutter based on Navigation 2 supporting deep linking, data-driven routes and more -version: 12.1.2 +version: 12.1.3 repository: https://github.com/flutter/packages/tree/main/packages/go_router issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22