flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-08-06 17:28:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

[go_router] Fix analyzer in test (#3206)

Browse Source 
* Fix analyzer

* Add ignore

* Add ambiguatre

* Formatting
This commit is contained in:
Camille Simon
2023-02-14 11:55:14 -08:00
committed by GitHub
parent 278b4890ef
commit 9baf377ab4
1 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/go_router/test/go_router_test.dart
View File

@ -689,7 +689,8 @@ void main() {
'Handles the Android back button when parentNavigatorKey is set to the root navigator', 'Handles the Android back button when parentNavigatorKey is set to the root navigator',
(WidgetTester tester) async { (WidgetTester tester) async {
final List<MethodCall> log = <MethodCall>[]; final List<MethodCall> log = <MethodCall>[];
TestDefaultBinaryMessengerBinding.instance!.defaultBinaryMessenger _ambiguate(TestDefaultBinaryMessengerBinding.instance)!
.defaultBinaryMessenger
.setMockMethodCallHandler(SystemChannels.platform, .setMockMethodCallHandler(SystemChannels.platform,
(MethodCall methodCall) async { (MethodCall methodCall) async {
log.add(methodCall); log.add(methodCall);
@ -731,7 +732,8 @@ void main() {
testWidgets("Handles the Android back button when ShellRoute can't pop", testWidgets("Handles the Android back button when ShellRoute can't pop",
(WidgetTester tester) async { (WidgetTester tester) async {
final List<MethodCall> log = <MethodCall>[]; final List<MethodCall> log = <MethodCall>[];
TestDefaultBinaryMessengerBinding.instance!.defaultBinaryMessenger _ambiguate(TestDefaultBinaryMessengerBinding.instance)!
.defaultBinaryMessenger
.setMockMethodCallHandler(SystemChannels.platform, .setMockMethodCallHandler(SystemChannels.platform,
(MethodCall methodCall) async { (MethodCall methodCall) async {
log.add(methodCall); log.add(methodCall);
@ -795,7 +797,8 @@ void main() {
'Handles the Android back button when a second Shell has a GoRoute with parentNavigator key', 'Handles the Android back button when a second Shell has a GoRoute with parentNavigator key',
(WidgetTester tester) async { (WidgetTester tester) async {
final List<MethodCall> log = <MethodCall>[]; final List<MethodCall> log = <MethodCall>[];
TestDefaultBinaryMessengerBinding.instance!.defaultBinaryMessenger _ambiguate(TestDefaultBinaryMessengerBinding.instance)!
.defaultBinaryMessenger
.setMockMethodCallHandler(SystemChannels.platform, .setMockMethodCallHandler(SystemChannels.platform,
(MethodCall methodCall) async { (MethodCall methodCall) async {
log.add(methodCall); log.add(methodCall);
@ -884,7 +887,8 @@ void main() {
group('report correct url', () { group('report correct url', () {
final List<MethodCall> log = <MethodCall>[]; final List<MethodCall> log = <MethodCall>[];
setUp(() { setUp(() {
TestDefaultBinaryMessengerBinding.instance!.defaultBinaryMessenger _ambiguate(TestDefaultBinaryMessengerBinding.instance)!
.defaultBinaryMessenger
.setMockMethodCallHandler(SystemChannels.navigation, .setMockMethodCallHandler(SystemChannels.navigation,
(MethodCall methodCall) async { (MethodCall methodCall) async {
log.add(methodCall); log.add(methodCall);
@ -892,7 +896,8 @@ void main() {
}); });
}); });
tearDown(() { tearDown(() {
TestDefaultBinaryMessengerBinding.instance!.defaultBinaryMessenger _ambiguate(TestDefaultBinaryMessengerBinding.instance)!
.defaultBinaryMessenger
.setMockMethodCallHandler(SystemChannels.navigation, null); .setMockMethodCallHandler(SystemChannels.navigation, null);
log.clear(); log.clear();
}); });
@ -3271,3 +3276,9 @@ void main() {
}); });
}); });
} }
/// This allows a value of type T or T? to be treated as a value of type T?.
///
/// We use this so that APIs that have become non-nullable can still be used
/// with `!` and `?` on the stable branch.
T? _ambiguate<T>(T? value) => value;