From 896131fa038b514b9df40158dc47e2da66da5112 Mon Sep 17 00:00:00 2001
From: gmackall <34871572+gmackall@users.noreply.github.com>
Date: Thu, 20 Jul 2023 16:11:47 -0700
Subject: [PATCH] [url_launcher_android] Set `buildFeatures.buildConfig` to
 true for compatibility with AGP 8.0+ (#4535)

This flag controls the generation of the BuildConfig class, which is [used to guard a log line](https://github.com/flutter/packages/blob/05fdd1337f3f9e2335144f4fe20e839743f4efa1/packages/url_launcher/url_launcher_android/android/src/main/java/io/flutter/plugins/urllauncher/UrlLauncher.java#L66).

In AGP 7.x this flag [defaulted to true](https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/BuildFeatures#buildConfig:kotlin.Boolean). AGP 8.x [changed it to default to false](https://developer.android.com/reference/tools/gradle-api/8.0/com/android/build/api/dsl/BuildFeatures#buildConfig()). This PR sets it explicitly to true, so we don't rely on defaults, and fixes an error for people using AGP 8.0+. I also upgraded an old AGP version while I was at it.

Fixes https://github.com/flutter/flutter/issues/128204.
---
 packages/url_launcher/url_launcher_android/CHANGELOG.md      | 4 ++++
 .../url_launcher/url_launcher_android/android/build.gradle   | 5 ++++-
 packages/url_launcher/url_launcher_android/pubspec.yaml      | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/packages/url_launcher/url_launcher_android/CHANGELOG.md b/packages/url_launcher/url_launcher_android/CHANGELOG.md
index f7605d8f2a..331e7a61c2 100644
--- a/packages/url_launcher/url_launcher_android/CHANGELOG.md
+++ b/packages/url_launcher/url_launcher_android/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 6.0.37
+
+* Sets android.defaults.buildfeatures.buildconfig to true for compatibility with AGP 8.0+.
+
 ## 6.0.36
 
 * Bumps androidx.annotation:annotation from 1.2.0 to 1.6.0.
diff --git a/packages/url_launcher/url_launcher_android/android/build.gradle b/packages/url_launcher/url_launcher_android/android/build.gradle
index 930e016546..cf504cb8af 100644
--- a/packages/url_launcher/url_launcher_android/android/build.gradle
+++ b/packages/url_launcher/url_launcher_android/android/build.gradle
@@ -8,7 +8,7 @@ buildscript {
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:4.2.0'
+        classpath 'com.android.tools.build:gradle:7.3.0'
     }
 }
 
@@ -22,6 +22,9 @@ rootProject.allprojects {
 apply plugin: 'com.android.library'
 
 android {
+    buildFeatures {
+        buildConfig true
+    }
     // Conditional for compatibility with AGP <4.2.
     if (project.android.hasProperty("namespace")) {
         namespace 'io.flutter.plugins.urllauncher'
diff --git a/packages/url_launcher/url_launcher_android/pubspec.yaml b/packages/url_launcher/url_launcher_android/pubspec.yaml
index 5967bf0bb9..1ef09dbb97 100644
--- a/packages/url_launcher/url_launcher_android/pubspec.yaml
+++ b/packages/url_launcher/url_launcher_android/pubspec.yaml
@@ -2,7 +2,7 @@ name: url_launcher_android
 description: Android implementation of the url_launcher plugin.
 repository: https://github.com/flutter/packages/tree/main/packages/url_launcher/url_launcher_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
-version: 6.0.36
+version: 6.0.37
 
 environment:
   sdk: ">=2.18.0 <4.0.0"