From 75a21002f7376050f7a264f72d6ed877191837ab Mon Sep 17 00:00:00 2001
From: stuartmorgan <stuartmorgan@google.com>
Date: Wed, 5 May 2021 10:38:05 -0400
Subject: [PATCH] Fix analyzer issues in bsdiff (#342)

Fixes minor issues flagged by the analyzer in preparation for fixing the
CI to run checks against the packages in third_party/packages.
---
 third_party/packages/bsdiff/example/pubspec.yaml |  1 +
 third_party/packages/bsdiff/lib/bsdiff.dart      | 10 ++++++----
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/third_party/packages/bsdiff/example/pubspec.yaml b/third_party/packages/bsdiff/example/pubspec.yaml
index d5c909918c..dd9bbc9b34 100644
--- a/third_party/packages/bsdiff/example/pubspec.yaml
+++ b/third_party/packages/bsdiff/example/pubspec.yaml
@@ -1,6 +1,7 @@
 name: main
 description: A simple example of how to use bsdiff to generate and apply patches.
 version: 0.1.0
+publish_to: none
 
 dependencies:
   bsdiff:
diff --git a/third_party/packages/bsdiff/lib/bsdiff.dart b/third_party/packages/bsdiff/lib/bsdiff.dart
index 7af6acc166..f9b9eb22a5 100644
--- a/third_party/packages/bsdiff/lib/bsdiff.dart
+++ b/third_party/packages/bsdiff/lib/bsdiff.dart
@@ -96,7 +96,7 @@ void _split(List<int> idata, List<int> vdata, int start, int len, int h) {
 
 void _qsufsort(List<int> idata, List<int> vdata, Uint8List olddata) {
   final int oldsize = olddata.length;
-  final List<int> buckets = List<int>(256);
+  final List<int> buckets = <int>[256];
 
   for (int i = 0; i < 256; i++) {
     buckets[i] = 0;
@@ -207,12 +207,13 @@ int _search(List<int> idata, Uint8List olddata, Uint8List newdata, int newskip,
 List<int> _int64bytes(int i) =>
     (ByteData(8)..setInt64(0, i)).buffer.asUint8List();
 
+/// Computes the binary diff between [olddata] and [newdata].
 Uint8List bsdiff(List<int> olddata, List<int> newdata) {
   final int oldsize = olddata.length;
   final int newsize = newdata.length;
 
-  final List<int> idata = List<int>(oldsize + 1);
-  _qsufsort(idata, List<int>(oldsize + 1), olddata);
+  final List<int> idata = <int>[oldsize + 1];
+  _qsufsort(idata, <int>[oldsize + 1], olddata);
 
   final Uint8List db = Uint8List(newsize + 1);
   final Uint8List eb = Uint8List(newsize + 1);
@@ -346,6 +347,7 @@ Uint8List bsdiff(List<int> olddata, List<int> newdata) {
   return bytes;
 }
 
+/// Returns the result of applying [diffdata] to [olddata].
 Uint8List bspatch(List<int> olddata, List<int> diffdata) {
   final List<int> magic = diffdata.sublist(0, 8);
   if (const AsciiCodec().decode(magic) != 'BZDIFF40') {
@@ -377,7 +379,7 @@ Uint8List bspatch(List<int> olddata, List<int> diffdata) {
   int newpos = 0;
 
   while (newpos < newsize) {
-    final List<int> ctrl = List<int>(3);
+    final List<int> ctrl = <int>[3];
     for (int i = 0; i <= 2; i++) {
       ctrl[i] = cpfdata.getInt64(8 * cpfpos++);
     }