flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-28 05:37:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_plugin_tools] Remove global state from tests (#4018)

Browse Source 
Eliminates the global test filesystem and global test packages directory, in favor of local versions. This guarantees that each test runs with a clean filesystem state, rather than relying on cleanup. It also simplifies understanding the tests, since everything is done via params and return values instead of needing to know about the magic global variables and which methods mutate them.
This commit is contained in:
stuartmorgan
2021-06-07 10:04:43 -07:00
committed by GitHub
parent bb0a1ea161
commit 74d03857f8
16 changed files with 456 additions and 537 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
script/tool/test/pubspec_check_command_test.dart
View File

@ -21,7 +21,7 @@ void main() {
setUp(() {
fileSystem = MemoryFileSystem();
packagesDir = fileSystem.currentDirectory.childDirectory('packages');
initializeFakePackages(parentDir: packagesDir.parent);
createPackagesDirectory(parentDir: packagesDir.parent);
processRunner = RecordingProcessRunner();
final PubspecCheckCommand command =
PubspecCheckCommand(packagesDir, processRunner: processRunner);
@ -88,8 +88,8 @@ dev_dependencies:
}
test('passes for a plugin following conventions', () async {
final Directory pluginDirectory = createFakePlugin('plugin',
withSingleExample: true, packagesDirectory: packagesDir);
final Directory pluginDirectory =
createFakePlugin('plugin', packagesDir, withSingleExample: true);
pluginDirectory.childFile('pubspec.yaml').writeAsStringSync('''
${headerSection('plugin', isPlugin: true)}
@ -114,8 +114,8 @@ ${devDependenciesSection()}
});
test('passes for a Flutter package following conventions', () async {
final Directory pluginDirectory = createFakePlugin('plugin',
withSingleExample: true, packagesDirectory: packagesDir);
final Directory pluginDirectory =
createFakePlugin('plugin', packagesDir, withSingleExample: true);
pluginDirectory.childFile('pubspec.yaml').writeAsStringSync('''
${headerSection('plugin')}
@ -163,8 +163,8 @@ ${dependenciesSection()}
});
test('fails when homepage is included', () async {
final Directory pluginDirectory = createFakePlugin('plugin',
withSingleExample: true, packagesDirectory: packagesDir);
final Directory pluginDirectory =
createFakePlugin('plugin', packagesDir, withSingleExample: true);
pluginDirectory.childFile('pubspec.yaml').writeAsStringSync('''
${headerSection('plugin', isPlugin: true, includeHomepage: true)}
@ -184,8 +184,8 @@ ${devDependenciesSection()}
});
test('fails when repository is missing', () async {
final Directory pluginDirectory = createFakePlugin('plugin',
withSingleExample: true, packagesDirectory: packagesDir);
final Directory pluginDirectory =
createFakePlugin('plugin', packagesDir, withSingleExample: true);
pluginDirectory.childFile('pubspec.yaml').writeAsStringSync('''
${headerSection('plugin', isPlugin: true, includeRepository: false)}
@ -205,8 +205,8 @@ ${devDependenciesSection()}
});
test('fails when homepage is given instead of repository', () async {
final Directory pluginDirectory = createFakePlugin('plugin',
withSingleExample: true, packagesDirectory: packagesDir);
final Directory pluginDirectory =
createFakePlugin('plugin', packagesDir, withSingleExample: true);
pluginDirectory.childFile('pubspec.yaml').writeAsStringSync('''
${headerSection('plugin', isPlugin: true, includeHomepage: true, includeRepository: false)}
@ -226,8 +226,8 @@ ${devDependenciesSection()}
});
test('fails when issue tracker is missing', () async {
final Directory pluginDirectory = createFakePlugin('plugin',
withSingleExample: true, packagesDirectory: packagesDir);
final Directory pluginDirectory =
createFakePlugin('plugin', packagesDir, withSingleExample: true);
pluginDirectory.childFile('pubspec.yaml').writeAsStringSync('''
${headerSection('plugin', isPlugin: true, includeIssueTracker: false)}
@ -247,8 +247,8 @@ ${devDependenciesSection()}
});
test('fails when environment section is out of order', () async {
final Directory pluginDirectory = createFakePlugin('plugin',
withSingleExample: true, packagesDirectory: packagesDir);
final Directory pluginDirectory =
createFakePlugin('plugin', packagesDir, withSingleExample: true);
pluginDirectory.childFile('pubspec.yaml').writeAsStringSync('''
${headerSection('plugin', isPlugin: true)}
@ -268,8 +268,8 @@ ${environmentSection()}
});
test('fails when flutter section is out of order', () async {
final Directory pluginDirectory = createFakePlugin('plugin',
withSingleExample: true, packagesDirectory: packagesDir);
final Directory pluginDirectory =
createFakePlugin('plugin', packagesDir, withSingleExample: true);
pluginDirectory.childFile('pubspec.yaml').writeAsStringSync('''
${headerSection('plugin', isPlugin: true)}
@ -289,8 +289,8 @@ ${devDependenciesSection()}
});
test('fails when dependencies section is out of order', () async {
final Directory pluginDirectory = createFakePlugin('plugin',
withSingleExample: true, packagesDirectory: packagesDir);
final Directory pluginDirectory =
createFakePlugin('plugin', packagesDir, withSingleExample: true);
pluginDirectory.childFile('pubspec.yaml').writeAsStringSync('''
${headerSection('plugin', isPlugin: true)}
@ -310,8 +310,8 @@ ${dependenciesSection()}
});
test('fails when devDependencies section is out of order', () async {
final Directory pluginDirectory = createFakePlugin('plugin',
withSingleExample: true, packagesDirectory: packagesDir);
final Directory pluginDirectory =
createFakePlugin('plugin', packagesDir, withSingleExample: true);
pluginDirectory.childFile('pubspec.yaml').writeAsStringSync('''
${headerSection('plugin', isPlugin: true)}