flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-09 05:59:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

[tools] Convert test utils to RepositoryPackage (#5605)

Browse Source
This commit is contained in:
stuartmorgan
2022-05-03 17:14:11 -04:00
committed by GitHub
parent 5a06b47e51
commit 5ec6644f3f
39 changed files with 1124 additions and 986 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
script/tool/lib/src/common/plugin_command.dart
View File

@ -368,7 +368,7 @@ abstract class PluginCommand extends Command<void> {
await for (final FileSystemEntity entity
in dir.list(followLinks: false)) {
// A top-level Dart package is a plugin package.
if (_isDartPackage(entity)) {
if (isPackage(entity)) {
if (packages.isEmpty || packages.contains(p.basename(entity.path))) {
yield PackageEnumerationEntry(
RepositoryPackage(entity as Directory),
@ -378,7 +378,7 @@ abstract class PluginCommand extends Command<void> {
// Look for Dart packages under this top-level directory.
await for (final FileSystemEntity subdir
in entity.list(followLinks: false)) {
if (_isDartPackage(subdir)) {
if (isPackage(subdir)) {
// There are three ways for a federated plugin to match:
// - package name (path_provider_android)
// - fully specified name (path_provider/path_provider_android)
@ -427,9 +427,9 @@ abstract class PluginCommand extends Command<void> {
{bool filterExcluded = true}) async* {
yield* package.directory
.list(recursive: true, followLinks: false)
.where(_isDartPackage)
.where(isPackage)
.map((FileSystemEntity directory) =>
// _isDartPackage guarantees that this cast is valid.
// isPackage guarantees that this cast is valid.
RepositoryPackage(directory as Directory));
}
@ -448,12 +448,6 @@ abstract class PluginCommand extends Command<void> {
.cast<File>();
}
/// Returns whether the specified entity is a directory containing a
/// `pubspec.yaml` file.
bool _isDartPackage(FileSystemEntity entity) {
return entity is Directory && entity.childFile('pubspec.yaml').existsSync();
}
/// Retrieve an instance of [GitVersionFinder] based on `_baseShaArg` and [gitDir].
///
/// Throws tool exit if [gitDir] nor root directory is a git directory.