flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-08 12:47:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

[tools] Remove single-example RepositoryPackage method (#5600)

Browse Source
This commit is contained in:
stuartmorgan
2022-05-03 13:59:11 -04:00
committed by GitHub
parent 1186d6831f
commit 5a06b47e51
6 changed files with 186 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
script/tool/lib/src/firebase_test_lab_command.dart
View File

@ -119,7 +119,32 @@ class FirebaseTestLabCommand extends PackageLoopingCommand {
@override
Future<PackageResult> runForPackage(RepositoryPackage package) async {
final RepositoryPackage example = package.getSingleExampleDeprecated();
final List<PackageResult> results = <PackageResult>[];
for (final RepositoryPackage example in package.getExamples()) {
results.add(await _runForExample(example, package: package));
}
// If all results skipped, report skip overall.
if (results
.every((PackageResult result) => result.state == RunState.skipped)) {
return PackageResult.skip('No examples support Android.');
}
// Otherwise, report failure if there were any failures.
final List<String> allErrors = results
.map((PackageResult result) =>
result.state == RunState.failed ? result.details : <String>[])
.expand((List<String> list) => list)
.toList();
return allErrors.isEmpty
? PackageResult.success()
: PackageResult.fail(allErrors);
}
/// Runs the test for the given example of [package].
Future<PackageResult> _runForExample(
RepositoryPackage example, {
required RepositoryPackage package,
}) async {
final Directory androidDirectory =
example.directory.childDirectory('android');
if (!androidDirectory.existsSync()) {
@ -163,7 +188,7 @@ class FirebaseTestLabCommand extends PackageLoopingCommand {
// Used within the loop to ensure a unique GCS output location for each
// test file's run.
int resultsCounter = 0;
for (final File test in _findIntegrationTestFiles(package)) {
for (final File test in _findIntegrationTestFiles(example)) {
final String testName =
getRelativePosixPath(test, from: package.directory);
print('Testing $testName...');
@ -175,7 +200,8 @@ class FirebaseTestLabCommand extends PackageLoopingCommand {
final String buildId = getStringArg('build-id');
final String testRunId = getStringArg('test-run-id');
final String resultsDir =
'plugins_android_test/${package.displayName}/$buildId/$testRunId/${resultsCounter++}/';
'plugins_android_test/${package.displayName}/$buildId/$testRunId/'
'${example.directory.basename}/${resultsCounter++}/';
// Automatically retry failures; there is significant flake with these
// tests whose cause isn't yet understood, and having to re-run the
@ -299,12 +325,10 @@ class FirebaseTestLabCommand extends PackageLoopingCommand {
return true;
}
/// Finds and returns all integration test files for [package].
Iterable<File> _findIntegrationTestFiles(RepositoryPackage package) sync* {
final Directory integrationTestDir = package
.getSingleExampleDeprecated()
.directory
.childDirectory('integration_test');
/// Finds and returns all integration test files for [example].
Iterable<File> _findIntegrationTestFiles(RepositoryPackage example) sync* {
final Directory integrationTestDir =
example.directory.childDirectory('integration_test');
if (!integrationTestDir.existsSync()) {
return;