flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-29 14:18:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_plugin_tools] Preserve Dart SDK version in all-plugins-app (#5281)

Browse Source 
Fixes `all-plugins-app` to preserve the original application's Dart SDK
version to avoid changing language feature opt-ins that the template may
rely on.
This commit is contained in:
stuartmorgan
2022-04-15 14:01:46 -04:00
committed by GitHub
parent b0567c3fcc
commit 57e6a62dc8
3 changed files with 50 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
script/tool/test/create_all_plugins_app_command_test.dart
View File

@ -2,10 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:io' as io;
import 'package:args/command_runner.dart';
import 'package:file/file.dart';
import 'package:file/local.dart';
import 'package:flutter_plugin_tools/src/common/repository_package.dart';
import 'package:flutter_plugin_tools/src/create_all_plugins_app_command.dart';
import 'package:platform/platform.dart';
import 'package:pubspec_parse/pubspec_parse.dart';
import 'package:test/test.dart';
import 'util.dart';
@ -76,14 +81,31 @@ void main() {
]));
});
test('pubspec is compatible with null-safe app code', () async {
test('pubspec preserves existing Dart SDK version', () async {
const String baselineProjectName = 'baseline';
final Directory baselineProjectDirectory =
testRoot.childDirectory(baselineProjectName);
io.Process.runSync(
getFlutterCommand(const LocalPlatform()),
<String>[
'create',
'--template=app',
'--project-name=$baselineProjectName',
baselineProjectDirectory.path,
],
);
final Pubspec baselinePubspec =
RepositoryPackage(baselineProjectDirectory).parsePubspec();
createFakePlugin('plugina', packagesDir);
await runCapturingPrint(runner, <String>['all-plugins-app']);
final String pubspec =
command.appDirectory.childFile('pubspec.yaml').readAsStringSync();
final Pubspec generatedPubspec =
RepositoryPackage(command.appDirectory).parsePubspec();
expect(pubspec, contains(RegExp('sdk:\\s*(?:["\']>=|[^])2\\.12\\.')));
const String dartSdkKey = 'sdk';
expect(generatedPubspec.environment?[dartSdkKey],
baselinePubspec.environment?[dartSdkKey]);
});
test('handles --output-dir', () async {