flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-03 01:30:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_plugin_tools] Preserve Dart SDK version in all-plugins-app (#5281)

Browse Source 
Fixes `all-plugins-app` to preserve the original application's Dart SDK
version to avoid changing language feature opt-ins that the template may
rely on.
This commit is contained in:
stuartmorgan
2022-04-15 14:01:46 -04:00
committed by GitHub
parent b0567c3fcc
commit 57e6a62dc8
3 changed files with 50 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
script/tool/lib/src/create_all_plugins_app_command.dart
View File

@ -147,6 +147,19 @@ class CreateAllPluginsAppCommand extends PluginCommand {
}
Future<void> _genPubspecWithAllPlugins() async {
final RepositoryPackage buildAllApp = RepositoryPackage(appDirectory);
// Read the old pubspec file's Dart SDK version, in order to preserve it
// in the new file. The template sometimes relies on having opted in to
// specific language features via SDK version, so using a different one
// can cause compilation failures.
final Pubspec originalPubspec = buildAllApp.parsePubspec();
const String dartSdkKey = 'sdk';
final VersionConstraint dartSdkConstraint =
originalPubspec.environment?[dartSdkKey] ??
VersionConstraint.compatibleWith(
Version.parse('2.12.0'),
);
final Map<String, PathDependency> pluginDeps =
await _getValidPathDependencies();
final Pubspec pubspec = Pubspec(
@ -154,9 +167,7 @@ class CreateAllPluginsAppCommand extends PluginCommand {
description: 'Flutter app containing all 1st party plugins.',
version: Version.parse('1.0.0+1'),
environment: <String, VersionConstraint>{
'sdk': VersionConstraint.compatibleWith(
Version.parse('2.12.0'),
),
dartSdkKey: dartSdkConstraint,
},
dependencies: <String, Dependency>{
'flutter': SdkDependency('flutter'),
@ -166,8 +177,7 @@ class CreateAllPluginsAppCommand extends PluginCommand {
},
dependencyOverrides: pluginDeps,
);
final File pubspecFile = appDirectory.childFile('pubspec.yaml');
pubspecFile.writeAsStringSync(_pubspecToString(pubspec));
buildAllApp.pubspecFile.writeAsStringSync(_pubspecToString(pubspec));
}
Future<Map<String, PathDependency>> _getValidPathDependencies() async {
@ -212,7 +222,12 @@ dev_dependencies:${_pubspecMapString(pubspec.devDependencies)}
for (final MapEntry<String, dynamic> entry in values.entries) {
buffer.writeln();
if (entry.value is VersionConstraint) {
buffer.write(' ${entry.key}: ${entry.value}');
String value = entry.value.toString();
// Range constraints require quoting.
if (value.startsWith('>') || value.startsWith('<')) {
value = "'$value'";
}
buffer.write(' ${entry.key}: $value');
} else if (entry.value is SdkDependency) {
final SdkDependency dep = entry.value as SdkDependency;
buffer.write(' ${entry.key}: \n sdk: ${dep.sdk}');