flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-05-29 03:49:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Switch script/tools over to the new analysis options (#3777)

Browse Source 
Removes the legacy analysis options override and fixes all resulting issues. This is a combination of dart fix and manual changes (mostly mechanical, but some small restructuring to address warnings more cleanly, such as creating typed structs from args when they are used repeatedly to avoid repeated casting, or making things that were unnecessarily public private).

One small opportunistic extra cleanup is that the handling of null-safety prerelease versions is removed, as any new plugin would be written null-safe from the start, so we no longer need to allow those versions.

Part of flutter/flutter#76229
This commit is contained in:
stuartmorgan
2021-04-06 13:04:25 -07:00
committed by GitHub
parent 5ea4d5fdfc
commit 3d9e523218
35 changed files with 675 additions and 652 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
script/tool/test/test_command_test.dart
View File

@ -11,7 +11,7 @@ import 'util.dart';
void main() {
group('$TestCommand', () {
CommandRunner<TestCommand> runner;
CommandRunner<void> runner;
final RecordingProcessRunner processRunner = RecordingProcessRunner();
setUp(() {
@ -19,7 +19,7 @@ void main() {
final TestCommand command = TestCommand(mockPackagesDir, mockFileSystem,
processRunner: processRunner);
runner = CommandRunner<Null>('test_test', 'Test for $TestCommand');
runner = CommandRunner<void>('test_test', 'Test for $TestCommand');
runner.addCommand(command);
});
@ -43,8 +43,10 @@ void main() {
expect(
processRunner.recordedCalls,
orderedEquals(<ProcessCall>[
ProcessCall('flutter', <String>['test', '--color'], plugin1Dir.path),
ProcessCall('flutter', <String>['test', '--color'], plugin2Dir.path),
ProcessCall(
'flutter', const <String>['test', '--color'], plugin1Dir.path),
ProcessCall(
'flutter', const <String>['test', '--color'], plugin2Dir.path),
]),
);
@ -63,7 +65,8 @@ void main() {
expect(
processRunner.recordedCalls,
orderedEquals(<ProcessCall>[
ProcessCall('flutter', <String>['test', '--color'], plugin2Dir.path),
ProcessCall(
'flutter', const <String>['test', '--color'], plugin2Dir.path),
]),
);
@ -89,12 +92,12 @@ void main() {
orderedEquals(<ProcessCall>[
ProcessCall(
'flutter',
<String>['test', '--color', '--enable-experiment=exp1'],
const <String>['test', '--color', '--enable-experiment=exp1'],
plugin1Dir.path),
ProcessCall('pub', <String>['get'], plugin2Dir.path),
ProcessCall('pub', const <String>['get'], plugin2Dir.path),
ProcessCall(
'pub',
<String>['run', '--enable-experiment=exp1', 'test'],
const <String>['run', '--enable-experiment=exp1', 'test'],
plugin2Dir.path),
]),
);
@ -117,8 +120,10 @@ void main() {
expect(
processRunner.recordedCalls,
orderedEquals(<ProcessCall>[
ProcessCall('flutter',
<String>['test', '--color', '--platform=chrome'], pluginDir.path),
ProcessCall(
'flutter',
const <String>['test', '--color', '--platform=chrome'],
pluginDir.path),
]),
);
});
@ -142,12 +147,12 @@ void main() {
orderedEquals(<ProcessCall>[
ProcessCall(
'flutter',
<String>['test', '--color', '--enable-experiment=exp1'],
const <String>['test', '--color', '--enable-experiment=exp1'],
plugin1Dir.path),
ProcessCall('pub', <String>['get'], plugin2Dir.path),
ProcessCall('pub', const <String>['get'], plugin2Dir.path),
ProcessCall(
'pub',
<String>['run', '--enable-experiment=exp1', 'test'],
const <String>['run', '--enable-experiment=exp1', 'test'],
plugin2Dir.path),
]),
);