flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-08-16 13:01:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Switch script/tools over to the new analysis options (#3777)

Browse Source 
Removes the legacy analysis options override and fixes all resulting issues. This is a combination of dart fix and manual changes (mostly mechanical, but some small restructuring to address warnings more cleanly, such as creating typed structs from args when they are used repeatedly to avoid repeated casting, or making things that were unnecessarily public private).

One small opportunistic extra cleanup is that the handling of null-safety prerelease versions is removed, as any new plugin would be written null-safe from the start, so we no longer need to allow those versions.

Part of flutter/flutter#76229
This commit is contained in:
stuartmorgan
2021-04-06 13:04:25 -07:00
committed by GitHub
parent 5ea4d5fdfc
commit 3d9e523218
35 changed files with 675 additions and 652 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
script/tool/lib/src/license_check_command.dart
View File

@ -62,8 +62,8 @@ final List<RegExp> _thirdPartyLicenseBlockRegexes = <RegExp>[
// Slight variants are not accepted because they may prevent consolidation in
// tools that assemble all licenses used in distributed applications.
// standardized.
final String _fullBsdLicenseText =
'''Copyright 2013 The Flutter Authors. All rights reserved.
const String _fullBsdLicenseText = '''
Copyright 2013 The Flutter Authors. All rights reserved.
Redistribution and use in source and binary forms, with or without modification,
are permitted provided that the following conditions are met:
@ -110,7 +110,7 @@ class LicenseCheckCommand extends PluginCommand {
'Ensures that all code files have copyright/license blocks.';
@override
Future<Null> run() async {
Future<void> run() async {
final Iterable<File> codeFiles = (await _getAllFiles()).where((File file) =>
_codeFileExtensions.contains(p.extension(file.path)) &&
!_shouldIgnoreFile(file));
@ -160,7 +160,7 @@ class LicenseCheckCommand extends PluginCommand {
if (_isThirdParty(file)) {
if (!_thirdPartyLicenseBlockRegexes
.any((regex) => regex.hasMatch(content))) {
.any((RegExp regex) => regex.hasMatch(content))) {
unrecognizedThirdPartyFiles.add(file);
}
} else {
@ -175,7 +175,8 @@ class LicenseCheckCommand extends PluginCommand {
_print('\n');
// Sort by path for more usable output.
final pathCompare = (File a, File b) => a.path.compareTo(b.path);
final int Function(File, File) pathCompare =
(File a, File b) => a.path.compareTo(b.path);
incorrectFirstPartyFiles.sort(pathCompare);
unrecognizedThirdPartyFiles.sort(pathCompare);
@ -200,7 +201,7 @@ class LicenseCheckCommand extends PluginCommand {
'the new third-party license block.\n');
}
bool succeeded =
final bool succeeded =
incorrectFirstPartyFiles.isEmpty && unrecognizedThirdPartyFiles.isEmpty;
if (succeeded) {
_print('All source files passed validation!');
@ -230,7 +231,7 @@ class LicenseCheckCommand extends PluginCommand {
'Please ensure that they use the exact format used in this repository".\n');
}
bool succeeded = incorrectLicenseFiles.isEmpty;
final bool succeeded = incorrectLicenseFiles.isEmpty;
if (succeeded) {
_print('All LICENSE files passed validation!');
}