From 38f4b595363f00f7abcd2204b7618bf9f61888e8 Mon Sep 17 00:00:00 2001 From: Tarrin Neal Date: Fri, 7 Jul 2023 15:32:05 -0700 Subject: [PATCH] [shared_preferences] Variable binding in a condition requires an initializer fix (#4407) Not sure that testing for this makes sense, unless we want to add old xcode versions to our test suite. Let me know if I'm thinking about this incorrectly though. fixes https://github.com/flutter/flutter/issues/129983 --- .../shared_preferences_foundation/CHANGELOG.md | 4 ++++ .../darwin/Classes/SharedPreferencesPlugin.swift | 2 +- .../shared_preferences_foundation/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/shared_preferences/shared_preferences_foundation/CHANGELOG.md b/packages/shared_preferences/shared_preferences_foundation/CHANGELOG.md index d68c11162d..7bbf5322a0 100644 --- a/packages/shared_preferences/shared_preferences_foundation/CHANGELOG.md +++ b/packages/shared_preferences/shared_preferences_foundation/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.3.1 + +* Fixes variable binding bug on older versions of Xcode. + ## 2.3.0 * Adds `clearWithParameters` and `getAllWithParameters` methods. diff --git a/packages/shared_preferences/shared_preferences_foundation/darwin/Classes/SharedPreferencesPlugin.swift b/packages/shared_preferences/shared_preferences_foundation/darwin/Classes/SharedPreferencesPlugin.swift index bb91ca0bd5..fcfe97e568 100644 --- a/packages/shared_preferences/shared_preferences_foundation/darwin/Classes/SharedPreferencesPlugin.swift +++ b/packages/shared_preferences/shared_preferences_foundation/darwin/Classes/SharedPreferencesPlugin.swift @@ -55,7 +55,7 @@ public class SharedPreferencesPlugin: NSObject, FlutterPlugin, UserDefaultsApi { func getAllPrefs(prefix: String, allowList: [String]?) -> [String: Any] { var filteredPrefs: [String: Any] = [:] var allowSet: Set?; - if let allowList { + if let allowList = allowList { allowSet = Set(allowList) } if let appDomain = Bundle.main.bundleIdentifier, diff --git a/packages/shared_preferences/shared_preferences_foundation/pubspec.yaml b/packages/shared_preferences/shared_preferences_foundation/pubspec.yaml index a6d714dcc0..1fd7a8c666 100644 --- a/packages/shared_preferences/shared_preferences_foundation/pubspec.yaml +++ b/packages/shared_preferences/shared_preferences_foundation/pubspec.yaml @@ -2,7 +2,7 @@ name: shared_preferences_foundation description: iOS and macOS implementation of the shared_preferences plugin. repository: https://github.com/flutter/packages/tree/main/packages/shared_preferences/shared_preferences_foundation issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+shared_preferences%22 -version: 2.3.0 +version: 2.3.1 environment: sdk: ">=2.18.0 <4.0.0"