flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-06-23 00:25:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

[tools] Recognize Pigeon tests in version-check (#6813)

Browse Source 
Pigeon has an usual test structure since it generates test code to run
in a dummy plugin; add that structure to the list of recognized tests so
that changes to its platform tests won't be flagged by `version-check`.
This commit is contained in:
stuartmorgan
2022-12-10 20:09:32 -05:00
committed by GitHub
parent d404da6e85
commit 3306027234
4 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
script/tool/CHANGELOG.md
View File

@ -1,5 +1,6 @@
## NEXT ## 13.1
* Updates `version-check` to recognize Pigeon's platform test structure.
* Pins `package:git` dependency to `2.0.x` until `dart >=2.18.0` becomes our * Pins `package:git` dependency to `2.0.x` until `dart >=2.18.0` becomes our
oldest legacy. oldest legacy.
* Updates test mocks. * Updates test mocks.

4
script/tool/lib/src/common/package_state_utils.dart
View File

@ -110,7 +110,9 @@ bool _isTestChange(List<String> pathComponents) {
pathComponents.contains('integration_test') || pathComponents.contains('integration_test') ||
pathComponents.contains('androidTest') || pathComponents.contains('androidTest') ||
pathComponents.contains('RunnerTests') || pathComponents.contains('RunnerTests') ||
pathComponents.contains('RunnerUITests'); pathComponents.contains('RunnerUITests') ||
// Pigeon's custom platform tests.
pathComponents.first == 'platform_tests';
} }
// True if the given file is an example file other than the one that will be // True if the given file is an example file other than the one that will be

2
script/tool/pubspec.yaml
View File

@ -1,7 +1,7 @@
name: flutter_plugin_tools name: flutter_plugin_tools
description: Productivity utils for flutter/plugins and flutter/packages description: Productivity utils for flutter/plugins and flutter/packages
repository: https://github.com/flutter/plugins/tree/main/script/tool repository: https://github.com/flutter/plugins/tree/main/script/tool
version: 0.13.0 version: 0.13.1
dependencies: dependencies:
args: ^2.1.0 args: ^2.1.0

3
script/tool/test/common/package_state_utils_test.dart
View File

@ -80,6 +80,9 @@ void main() {
'packages/a_plugin/example/macos/Runner.xcodeproj/project.pbxproj', 'packages/a_plugin/example/macos/Runner.xcodeproj/project.pbxproj',
'packages/a_plugin/example/windows/CMakeLists.txt', 'packages/a_plugin/example/windows/CMakeLists.txt',
'packages/a_plugin/example/pubspec.yaml', 'packages/a_plugin/example/pubspec.yaml',
// Pigeon platform tests, which have an unusual structure.
'packages/a_plugin/platform_tests/shared_test_plugin_code/lib/integration_tests.dart',
'packages/a_plugin/platform_tests/test_plugin/windows/test_plugin.cpp',
]; ];
final PackageChangeState state = await checkPackageChangeState(package, final PackageChangeState state = await checkPackageChangeState(package,