mirror of
https://github.com/flutter/packages.git
synced 2025-05-28 02:47:17 +08:00
[tool] add all and dry-run flags to publish-plugin command (#3776)
This commit is contained in:
Chris Yang
@ -53,7 +53,8 @@ void main() {
|
||||
mockPackagesDir, mockPackagesDir.fileSystem,
|
||||
processRunner: processRunner,
|
||||
print: (Object message) => printedMessages.add(message.toString()),
|
||||
stdinput: mockStdin));
|
||||
stdinput: mockStdin,
|
||||
gitDir: await GitDir.fromExisting(mockPackagesDir.path)));
|
||||
});
|
||||
|
||||
tearDown(() {
|
||||
@ -95,9 +96,11 @@ void main() {
|
||||
throwsA(const TypeMatcher<ToolExit>()));
|
||||
|
||||
expect(
|
||||
printedMessages.last,
|
||||
contains(
|
||||
"There are files in the package directory that haven't been saved in git."));
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'There are files in the package directory that haven\'t been saved in git. Refusing to publish these files:\n\n?? foo/tmp\n\nIf the directory should be clean, you can run `git clean -xdf && git reset --hard HEAD` to wipe all local changes.',
|
||||
'Failed, see above for details.',
|
||||
]));
|
||||
});
|
||||
|
||||
test('fails immediately if the remote doesn\'t exist', () async {
|
||||
@ -110,7 +113,7 @@ void main() {
|
||||
|
||||
test("doesn't validate the remote if it's not pushing tags", () async {
|
||||
// Immediately return 0 when running `pub publish`.
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(0);
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
|
||||
await commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
@ -131,7 +134,7 @@ void main() {
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>['commit', '-m', 'Initial commit']);
|
||||
// Immediately return 0 when running `pub publish`.
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(0);
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
await commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
'--package',
|
||||
@ -152,9 +155,10 @@ void main() {
|
||||
'--no-push-tags',
|
||||
'--no-tag-release'
|
||||
]);
|
||||
processRunner.mockPublishProcess.stdoutController.add(utf8.encode('Foo'));
|
||||
processRunner.mockPublishProcess.stderrController.add(utf8.encode('Bar'));
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(0);
|
||||
|
||||
processRunner.mockPublishStdout = 'Foo';
|
||||
processRunner.mockPublishStderr = 'Bar';
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
|
||||
await publishCommand;
|
||||
|
||||
@ -170,8 +174,8 @@ void main() {
|
||||
'--no-push-tags',
|
||||
'--no-tag-release'
|
||||
]);
|
||||
mockStdin.controller.add(utf8.encode('user input'));
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(0);
|
||||
mockStdin.mockUserInputs.add(utf8.encode('user input'));
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
|
||||
await publishCommand;
|
||||
|
||||
@ -180,7 +184,7 @@ void main() {
|
||||
});
|
||||
|
||||
test('forwards --pub-publish-flags to pub publish', () async {
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(0);
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
await commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
'--package',
|
||||
@ -199,7 +203,7 @@ void main() {
|
||||
});
|
||||
|
||||
test('throws if pub publish fails', () async {
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(128);
|
||||
processRunner.mockPublishCompleteCode = 128;
|
||||
await expectLater(
|
||||
() => commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
@ -210,13 +214,35 @@ void main() {
|
||||
]),
|
||||
throwsA(const TypeMatcher<ToolExit>()));
|
||||
|
||||
expect(printedMessages, contains('Publish failed. Exiting.'));
|
||||
expect(printedMessages, contains('Publish foo failed.'));
|
||||
});
|
||||
|
||||
test('publish, dry run', () async {
|
||||
// Immediately return 1 when running `pub publish`. If dry-run does not work, test should throw.
|
||||
processRunner.mockPublishCompleteCode = 1;
|
||||
await commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
'--package',
|
||||
testPluginName,
|
||||
'--dry-run',
|
||||
'--no-push-tags',
|
||||
'--no-tag-release',
|
||||
]);
|
||||
|
||||
expect(processRunner.pushTagsArgs, isEmpty);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'=============== DRY RUN ===============',
|
||||
'Running `pub publish ` in ${pluginDir.path}...\n',
|
||||
'Done!'
|
||||
]));
|
||||
});
|
||||
});
|
||||
|
||||
group('Tags release', () {
|
||||
test('with the version and name from the pubspec.yaml', () async {
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(0);
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
await commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
'--package',
|
||||
@ -231,7 +257,7 @@ void main() {
|
||||
});
|
||||
|
||||
test('only if publishing succeeded', () async {
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(128);
|
||||
processRunner.mockPublishCompleteCode = 128;
|
||||
await expectLater(
|
||||
() => commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
@ -241,7 +267,7 @@ void main() {
|
||||
]),
|
||||
throwsA(const TypeMatcher<ToolExit>()));
|
||||
|
||||
expect(printedMessages, contains('Publish failed. Exiting.'));
|
||||
expect(printedMessages, contains('Publish foo failed.'));
|
||||
final String tag = (await gitDir.runCommand(
|
||||
<String>['show-ref', 'fake_package-v0.0.1'],
|
||||
throwOnError: false))
|
||||
@ -257,7 +283,7 @@ void main() {
|
||||
});
|
||||
|
||||
test('requires user confirmation', () async {
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(0);
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
mockStdin.readLineOutput = 'help';
|
||||
await expectLater(
|
||||
() => commandRunner.run(<String>[
|
||||
@ -272,7 +298,7 @@ void main() {
|
||||
|
||||
test('to upstream by default', () async {
|
||||
await gitDir.runCommand(<String>['tag', 'garbage']);
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(0);
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
mockStdin.readLineOutput = 'y';
|
||||
await commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
@ -286,10 +312,30 @@ void main() {
|
||||
expect(printedMessages.last, 'Done!');
|
||||
});
|
||||
|
||||
test('to upstream by default, dry run', () async {
|
||||
await gitDir.runCommand(<String>['tag', 'garbage']);
|
||||
// Immediately return 1 when running `pub publish`. If dry-run does not work, test should throw.
|
||||
processRunner.mockPublishCompleteCode = 1;
|
||||
mockStdin.readLineOutput = 'y';
|
||||
await commandRunner.run(
|
||||
<String>['publish-plugin', '--package', testPluginName, '--dry-run']);
|
||||
|
||||
expect(processRunner.pushTagsArgs, isEmpty);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'=============== DRY RUN ===============',
|
||||
'Running `pub publish ` in ${pluginDir.path}...\n',
|
||||
'Tagging release fake_package-v0.0.1...',
|
||||
'Pushing tag to upstream...',
|
||||
'Done!'
|
||||
]));
|
||||
});
|
||||
|
||||
test('to different remotes based on a flag', () async {
|
||||
await gitDir.runCommand(
|
||||
<String>['remote', 'add', 'origin', 'http://localhost:8001']);
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(0);
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
mockStdin.readLineOutput = 'y';
|
||||
await commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
@ -306,7 +352,7 @@ void main() {
|
||||
});
|
||||
|
||||
test('only if tagging and pushing to remotes are both enabled', () async {
|
||||
processRunner.mockPublishProcess.exitCodeCompleter.complete(0);
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
await commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
'--package',
|
||||
@ -318,15 +364,495 @@ void main() {
|
||||
expect(printedMessages.last, 'Done!');
|
||||
});
|
||||
});
|
||||
|
||||
group('Auto release (all-changed flag)', () {
|
||||
setUp(() async {
|
||||
io.Process.runSync('git', <String>['init'],
|
||||
workingDirectory: mockPackagesDir.path);
|
||||
gitDir = await GitDir.fromExisting(mockPackagesDir.path);
|
||||
await gitDir.runCommand(
|
||||
<String>['remote', 'add', 'upstream', 'http://localhost:8000']);
|
||||
});
|
||||
|
||||
test('can release newly created plugins', () async {
|
||||
// Non-federated
|
||||
final Directory pluginDir1 = createFakePlugin('plugin1',
|
||||
withSingleExample: true, packagesDirectory: mockPackagesDir);
|
||||
// federated
|
||||
final Directory pluginDir2 = createFakePlugin('plugin2',
|
||||
withSingleExample: true,
|
||||
parentDirectoryName: 'plugin2',
|
||||
packagesDirectory: mockPackagesDir);
|
||||
createFakePubspec(pluginDir1,
|
||||
name: 'plugin1',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
createFakePubspec(pluginDir2,
|
||||
name: 'plugin2',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>['commit', '-m', 'Add plugins']);
|
||||
// Immediately return 0 when running `pub publish`.
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
mockStdin.readLineOutput = 'y';
|
||||
await commandRunner
|
||||
.run(<String>['publish-plugin', '--all-changed', '--base-sha=HEAD~']);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'Checking local repo...',
|
||||
'Local repo is ready!',
|
||||
'Getting existing tags...',
|
||||
'Running `pub publish ` in ${pluginDir1.path}...\n',
|
||||
'Running `pub publish ` in ${pluginDir2.path}...\n',
|
||||
'Packages released: plugin1, plugin2',
|
||||
'Done!'
|
||||
]));
|
||||
expect(processRunner.pushTagsArgs, isNotEmpty);
|
||||
expect(processRunner.pushTagsArgs[0], 'push');
|
||||
expect(processRunner.pushTagsArgs[1], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[2], 'plugin1-v0.0.1');
|
||||
expect(processRunner.pushTagsArgs[3], 'push');
|
||||
expect(processRunner.pushTagsArgs[4], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[5], 'plugin2-v0.0.1');
|
||||
});
|
||||
|
||||
test('can release newly created plugins, while there are existing plugins',
|
||||
() async {
|
||||
// Prepare an exiting plugin and tag it
|
||||
final Directory pluginDir0 = createFakePlugin('plugin0',
|
||||
withSingleExample: true, packagesDirectory: mockPackagesDir);
|
||||
createFakePubspec(pluginDir0,
|
||||
name: 'plugin0',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>['commit', '-m', 'Add plugins']);
|
||||
// Immediately return 0 when running `pub publish`.
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
mockStdin.readLineOutput = 'y';
|
||||
await commandRunner
|
||||
.run(<String>['publish-plugin', '--all-changed', '--base-sha=HEAD~']);
|
||||
processRunner.pushTagsArgs.clear();
|
||||
|
||||
// Non-federated
|
||||
final Directory pluginDir1 = createFakePlugin('plugin1',
|
||||
withSingleExample: true, packagesDirectory: mockPackagesDir);
|
||||
// federated
|
||||
final Directory pluginDir2 = createFakePlugin('plugin2',
|
||||
withSingleExample: true,
|
||||
parentDirectoryName: 'plugin2',
|
||||
packagesDirectory: mockPackagesDir);
|
||||
createFakePubspec(pluginDir1,
|
||||
name: 'plugin1',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
createFakePubspec(pluginDir2,
|
||||
name: 'plugin2',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>['commit', '-m', 'Add plugins']);
|
||||
// Immediately return 0 when running `pub publish`.
|
||||
await commandRunner
|
||||
.run(<String>['publish-plugin', '--all-changed', '--base-sha=HEAD~']);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'Checking local repo...',
|
||||
'Local repo is ready!',
|
||||
'Getting existing tags...',
|
||||
'Running `pub publish ` in ${pluginDir1.path}...\n',
|
||||
'Running `pub publish ` in ${pluginDir2.path}...\n',
|
||||
'Packages released: plugin1, plugin2',
|
||||
'Done!'
|
||||
]));
|
||||
expect(processRunner.pushTagsArgs, isNotEmpty);
|
||||
expect(processRunner.pushTagsArgs[0], 'push');
|
||||
expect(processRunner.pushTagsArgs[1], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[2], 'plugin1-v0.0.1');
|
||||
expect(processRunner.pushTagsArgs[3], 'push');
|
||||
expect(processRunner.pushTagsArgs[4], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[5], 'plugin2-v0.0.1');
|
||||
});
|
||||
|
||||
test('can release newly created plugins, dry run', () async {
|
||||
// Non-federated
|
||||
final Directory pluginDir1 = createFakePlugin('plugin1',
|
||||
withSingleExample: true, packagesDirectory: mockPackagesDir);
|
||||
// federated
|
||||
final Directory pluginDir2 = createFakePlugin('plugin2',
|
||||
withSingleExample: true,
|
||||
parentDirectoryName: 'plugin2',
|
||||
packagesDirectory: mockPackagesDir);
|
||||
createFakePubspec(pluginDir1,
|
||||
name: 'plugin1',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
createFakePubspec(pluginDir2,
|
||||
name: 'plugin2',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>['commit', '-m', 'Add plugins']);
|
||||
// Immediately return 1 when running `pub publish`. If dry-run does not work, test should throw.
|
||||
processRunner.mockPublishCompleteCode = 1;
|
||||
mockStdin.readLineOutput = 'y';
|
||||
await commandRunner.run(<String>[
|
||||
'publish-plugin',
|
||||
'--all-changed',
|
||||
'--base-sha=HEAD~',
|
||||
'--dry-run'
|
||||
]);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'Checking local repo...',
|
||||
'Local repo is ready!',
|
||||
'=============== DRY RUN ===============',
|
||||
'Getting existing tags...',
|
||||
'Running `pub publish ` in ${pluginDir1.path}...\n',
|
||||
'Tagging release plugin1-v0.0.1...',
|
||||
'Pushing tag to upstream...',
|
||||
'Running `pub publish ` in ${pluginDir2.path}...\n',
|
||||
'Tagging release plugin2-v0.0.1...',
|
||||
'Pushing tag to upstream...',
|
||||
'Packages released: plugin1, plugin2',
|
||||
'Done!'
|
||||
]));
|
||||
expect(processRunner.pushTagsArgs, isEmpty);
|
||||
});
|
||||
|
||||
test('version change triggers releases.', () async {
|
||||
// Non-federated
|
||||
final Directory pluginDir1 = createFakePlugin('plugin1',
|
||||
withSingleExample: true, packagesDirectory: mockPackagesDir);
|
||||
// federated
|
||||
final Directory pluginDir2 = createFakePlugin('plugin2',
|
||||
withSingleExample: true,
|
||||
parentDirectoryName: 'plugin2',
|
||||
packagesDirectory: mockPackagesDir);
|
||||
createFakePubspec(pluginDir1,
|
||||
name: 'plugin1',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
createFakePubspec(pluginDir2,
|
||||
name: 'plugin2',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>['commit', '-m', 'Add plugins']);
|
||||
// Immediately return 0 when running `pub publish`.
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
mockStdin.readLineOutput = 'y';
|
||||
await commandRunner
|
||||
.run(<String>['publish-plugin', '--all-changed', '--base-sha=HEAD~']);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'Checking local repo...',
|
||||
'Local repo is ready!',
|
||||
'Getting existing tags...',
|
||||
'Running `pub publish ` in ${pluginDir1.path}...\n',
|
||||
'Running `pub publish ` in ${pluginDir2.path}...\n',
|
||||
'Packages released: plugin1, plugin2',
|
||||
'Done!'
|
||||
]));
|
||||
expect(processRunner.pushTagsArgs, isNotEmpty);
|
||||
expect(processRunner.pushTagsArgs[0], 'push');
|
||||
expect(processRunner.pushTagsArgs[1], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[2], 'plugin1-v0.0.1');
|
||||
expect(processRunner.pushTagsArgs[3], 'push');
|
||||
expect(processRunner.pushTagsArgs[4], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[5], 'plugin2-v0.0.1');
|
||||
|
||||
processRunner.pushTagsArgs.clear();
|
||||
printedMessages.clear();
|
||||
|
||||
final List<String> plugin1Pubspec =
|
||||
pluginDir1.childFile('pubspec.yaml').readAsLinesSync();
|
||||
plugin1Pubspec[plugin1Pubspec.indexWhere(
|
||||
(String element) => element.contains('version:'))] = 'version: 0.0.2';
|
||||
pluginDir1
|
||||
.childFile('pubspec.yaml')
|
||||
.writeAsStringSync(plugin1Pubspec.join('\n'));
|
||||
final List<String> plugin2Pubspec =
|
||||
pluginDir2.childFile('pubspec.yaml').readAsLinesSync();
|
||||
plugin2Pubspec[plugin2Pubspec.indexWhere(
|
||||
(String element) => element.contains('version:'))] = 'version: 0.0.2';
|
||||
pluginDir2
|
||||
.childFile('pubspec.yaml')
|
||||
.writeAsStringSync(plugin2Pubspec.join('\n'));
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir
|
||||
.runCommand(<String>['commit', '-m', 'Update versions to 0.0.2']);
|
||||
|
||||
await commandRunner
|
||||
.run(<String>['publish-plugin', '--all-changed', '--base-sha=HEAD~']);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'Checking local repo...',
|
||||
'Local repo is ready!',
|
||||
'Getting existing tags...',
|
||||
'Running `pub publish ` in ${pluginDir1.path}...\n',
|
||||
'Running `pub publish ` in ${pluginDir2.path}...\n',
|
||||
'Packages released: plugin1, plugin2',
|
||||
'Done!'
|
||||
]));
|
||||
|
||||
expect(processRunner.pushTagsArgs, isNotEmpty);
|
||||
expect(processRunner.pushTagsArgs[0], 'push');
|
||||
expect(processRunner.pushTagsArgs[1], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[2], 'plugin1-v0.0.2');
|
||||
expect(processRunner.pushTagsArgs[3], 'push');
|
||||
expect(processRunner.pushTagsArgs[4], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[5], 'plugin2-v0.0.2');
|
||||
});
|
||||
|
||||
test(
|
||||
'delete package will not trigger publish but exit the command successfully.',
|
||||
() async {
|
||||
// Non-federated
|
||||
final Directory pluginDir1 = createFakePlugin('plugin1',
|
||||
withSingleExample: true, packagesDirectory: mockPackagesDir);
|
||||
// federated
|
||||
final Directory pluginDir2 = createFakePlugin('plugin2',
|
||||
withSingleExample: true,
|
||||
parentDirectoryName: 'plugin2',
|
||||
packagesDirectory: mockPackagesDir);
|
||||
createFakePubspec(pluginDir1,
|
||||
name: 'plugin1',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
createFakePubspec(pluginDir2,
|
||||
name: 'plugin2',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>['commit', '-m', 'Add plugins']);
|
||||
// Immediately return 0 when running `pub publish`.
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
mockStdin.readLineOutput = 'y';
|
||||
await commandRunner
|
||||
.run(<String>['publish-plugin', '--all-changed', '--base-sha=HEAD~']);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'Checking local repo...',
|
||||
'Local repo is ready!',
|
||||
'Getting existing tags...',
|
||||
'Running `pub publish ` in ${pluginDir1.path}...\n',
|
||||
'Running `pub publish ` in ${pluginDir2.path}...\n',
|
||||
'Packages released: plugin1, plugin2',
|
||||
'Done!'
|
||||
]));
|
||||
expect(processRunner.pushTagsArgs, isNotEmpty);
|
||||
expect(processRunner.pushTagsArgs[0], 'push');
|
||||
expect(processRunner.pushTagsArgs[1], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[2], 'plugin1-v0.0.1');
|
||||
expect(processRunner.pushTagsArgs[3], 'push');
|
||||
expect(processRunner.pushTagsArgs[4], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[5], 'plugin2-v0.0.1');
|
||||
|
||||
processRunner.pushTagsArgs.clear();
|
||||
printedMessages.clear();
|
||||
|
||||
final List<String> plugin1Pubspec =
|
||||
pluginDir1.childFile('pubspec.yaml').readAsLinesSync();
|
||||
plugin1Pubspec[plugin1Pubspec.indexWhere(
|
||||
(String element) => element.contains('version:'))] = 'version: 0.0.2';
|
||||
pluginDir1
|
||||
.childFile('pubspec.yaml')
|
||||
.writeAsStringSync(plugin1Pubspec.join('\n'));
|
||||
|
||||
pluginDir2.deleteSync(recursive: true);
|
||||
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>[
|
||||
'commit',
|
||||
'-m',
|
||||
'Update plugin1 versions to 0.0.2, delete plugin2'
|
||||
]);
|
||||
|
||||
await commandRunner
|
||||
.run(<String>['publish-plugin', '--all-changed', '--base-sha=HEAD~']);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'Checking local repo...',
|
||||
'Local repo is ready!',
|
||||
'Getting existing tags...',
|
||||
'Running `pub publish ` in ${pluginDir1.path}...\n',
|
||||
'The file at The pubspec file at ${pluginDir2.childFile('pubspec.yaml').path} does not exist. Publishing will not happen for plugin2.\nSafe to ignore if the package is deleted in this commit.\n',
|
||||
'Packages released: plugin1',
|
||||
'Done!'
|
||||
]));
|
||||
|
||||
expect(processRunner.pushTagsArgs, isNotEmpty);
|
||||
expect(processRunner.pushTagsArgs.length, 3);
|
||||
expect(processRunner.pushTagsArgs[0], 'push');
|
||||
expect(processRunner.pushTagsArgs[1], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[2], 'plugin1-v0.0.2');
|
||||
});
|
||||
|
||||
test(
|
||||
'versions revert do not trigger releases. Also prints out warning message.',
|
||||
() async {
|
||||
// Non-federated
|
||||
final Directory pluginDir1 = createFakePlugin('plugin1',
|
||||
withSingleExample: true, packagesDirectory: mockPackagesDir);
|
||||
// federated
|
||||
final Directory pluginDir2 = createFakePlugin('plugin2',
|
||||
withSingleExample: true,
|
||||
parentDirectoryName: 'plugin2',
|
||||
packagesDirectory: mockPackagesDir);
|
||||
createFakePubspec(pluginDir1,
|
||||
name: 'plugin1',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.2');
|
||||
createFakePubspec(pluginDir2,
|
||||
name: 'plugin2',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.2');
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>['commit', '-m', 'Add plugins']);
|
||||
// Immediately return 0 when running `pub publish`.
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
mockStdin.readLineOutput = 'y';
|
||||
await commandRunner
|
||||
.run(<String>['publish-plugin', '--all-changed', '--base-sha=HEAD~']);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'Checking local repo...',
|
||||
'Local repo is ready!',
|
||||
'Getting existing tags...',
|
||||
'Running `pub publish ` in ${pluginDir1.path}...\n',
|
||||
'Running `pub publish ` in ${pluginDir2.path}...\n',
|
||||
'Packages released: plugin1, plugin2',
|
||||
'Done!'
|
||||
]));
|
||||
expect(processRunner.pushTagsArgs, isNotEmpty);
|
||||
expect(processRunner.pushTagsArgs[0], 'push');
|
||||
expect(processRunner.pushTagsArgs[1], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[2], 'plugin1-v0.0.2');
|
||||
expect(processRunner.pushTagsArgs[3], 'push');
|
||||
expect(processRunner.pushTagsArgs[4], 'upstream');
|
||||
expect(processRunner.pushTagsArgs[5], 'plugin2-v0.0.2');
|
||||
|
||||
processRunner.pushTagsArgs.clear();
|
||||
printedMessages.clear();
|
||||
|
||||
final List<String> plugin1Pubspec =
|
||||
pluginDir1.childFile('pubspec.yaml').readAsLinesSync();
|
||||
plugin1Pubspec[plugin1Pubspec.indexWhere(
|
||||
(String element) => element.contains('version:'))] = 'version: 0.0.1';
|
||||
pluginDir1
|
||||
.childFile('pubspec.yaml')
|
||||
.writeAsStringSync(plugin1Pubspec.join('\n'));
|
||||
final List<String> plugin2Pubspec =
|
||||
pluginDir2.childFile('pubspec.yaml').readAsLinesSync();
|
||||
plugin2Pubspec[plugin2Pubspec.indexWhere(
|
||||
(String element) => element.contains('version:'))] = 'version: 0.0.1';
|
||||
pluginDir2
|
||||
.childFile('pubspec.yaml')
|
||||
.writeAsStringSync(plugin2Pubspec.join('\n'));
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir
|
||||
.runCommand(<String>['commit', '-m', 'Update versions to 0.0.1']);
|
||||
|
||||
await commandRunner
|
||||
.run(<String>['publish-plugin', '--all-changed', '--base-sha=HEAD~']);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'Checking local repo...',
|
||||
'Local repo is ready!',
|
||||
'Getting existing tags...',
|
||||
'The new version (0.0.1) is lower than the current version (0.0.2) for plugin1.\nThis git commit is a revert, no release is tagged.',
|
||||
'The new version (0.0.1) is lower than the current version (0.0.2) for plugin2.\nThis git commit is a revert, no release is tagged.',
|
||||
'Done!'
|
||||
]));
|
||||
|
||||
expect(processRunner.pushTagsArgs, isEmpty);
|
||||
});
|
||||
|
||||
test('No version change does not release any plugins', () async {
|
||||
// Non-federated
|
||||
final Directory pluginDir1 = createFakePlugin('plugin1',
|
||||
withSingleExample: true, packagesDirectory: mockPackagesDir);
|
||||
// federated
|
||||
final Directory pluginDir2 = createFakePlugin('plugin2',
|
||||
withSingleExample: true,
|
||||
parentDirectoryName: 'plugin2',
|
||||
packagesDirectory: mockPackagesDir);
|
||||
createFakePubspec(pluginDir1,
|
||||
name: 'plugin1',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
createFakePubspec(pluginDir2,
|
||||
name: 'plugin2',
|
||||
includeVersion: true,
|
||||
isFlutter: false,
|
||||
version: '0.0.1');
|
||||
|
||||
io.Process.runSync('git', <String>['init'],
|
||||
workingDirectory: mockPackagesDir.path);
|
||||
gitDir = await GitDir.fromExisting(mockPackagesDir.path);
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>['commit', '-m', 'Add plugins']);
|
||||
|
||||
pluginDir1.childFile('plugin1.dart').createSync();
|
||||
pluginDir2.childFile('plugin2.dart').createSync();
|
||||
await gitDir.runCommand(<String>['add', '-A']);
|
||||
await gitDir.runCommand(<String>['commit', '-m', 'Add dart files']);
|
||||
|
||||
// Immediately return 0 when running `pub publish`.
|
||||
processRunner.mockPublishCompleteCode = 0;
|
||||
mockStdin.readLineOutput = 'y';
|
||||
await commandRunner
|
||||
.run(<String>['publish-plugin', '--all-changed', '--base-sha=HEAD~']);
|
||||
expect(
|
||||
printedMessages,
|
||||
containsAllInOrder(<String>[
|
||||
'Checking local repo...',
|
||||
'Local repo is ready!',
|
||||
'No version updates in this commit.',
|
||||
'Done!'
|
||||
]));
|
||||
expect(processRunner.pushTagsArgs, isEmpty);
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
class TestProcessRunner extends ProcessRunner {
|
||||
final List<io.ProcessResult> results = <io.ProcessResult>[];
|
||||
final MockProcess mockPublishProcess = MockProcess();
|
||||
// Most recent returned publish process.
|
||||
MockProcess mockPublishProcess;
|
||||
final List<String> mockPublishArgs = <String>[];
|
||||
final MockProcessResult mockPushTagsResult = MockProcessResult();
|
||||
final List<String> pushTagsArgs = <String>[];
|
||||
|
||||
String mockPublishStdout;
|
||||
String mockPublishStderr;
|
||||
int mockPublishCompleteCode;
|
||||
|
||||
@override
|
||||
Future<io.ProcessResult> run(
|
||||
String executable,
|
||||
@ -362,23 +888,42 @@ class TestProcessRunner extends ProcessRunner {
|
||||
args[0] == 'pub' &&
|
||||
args[1] == 'publish');
|
||||
mockPublishArgs.addAll(args);
|
||||
mockPublishProcess = MockProcess();
|
||||
if (mockPublishStdout != null) {
|
||||
mockPublishProcess.stdoutController.add(utf8.encode(mockPublishStdout));
|
||||
}
|
||||
if (mockPublishStderr != null) {
|
||||
mockPublishProcess.stderrController.add(utf8.encode(mockPublishStderr));
|
||||
}
|
||||
if (mockPublishCompleteCode != null) {
|
||||
mockPublishProcess.exitCodeCompleter.complete(mockPublishCompleteCode);
|
||||
}
|
||||
|
||||
return mockPublishProcess;
|
||||
}
|
||||
}
|
||||
|
||||
class MockStdin extends Mock implements io.Stdin {
|
||||
final StreamController<List<int>> controller = StreamController<List<int>>();
|
||||
List<List<int>> mockUserInputs = <List<int>>[];
|
||||
StreamController<List<int>> _controller;
|
||||
String readLineOutput;
|
||||
|
||||
@override
|
||||
Stream<S> transform<S>(StreamTransformer<List<int>, S> streamTransformer) {
|
||||
return controller.stream.transform(streamTransformer);
|
||||
// In the test context, only one `PublishPluginCommand` object is created for a single test case.
|
||||
// However, sometimes, we need to run multiple commands in a single test case.
|
||||
// In such situation, this `MockStdin`'s StreamController might be listened to more than once, which is not allowed.
|
||||
//
|
||||
// Create a new controller every time so this Stdin could be listened to multiple times.
|
||||
_controller = StreamController<List<int>>();
|
||||
mockUserInputs.forEach(_addUserInputsToSteam);
|
||||
return _controller.stream.transform(streamTransformer);
|
||||
}
|
||||
|
||||
@override
|
||||
StreamSubscription<List<int>> listen(void onData(List<int> event),
|
||||
{Function onError, void onDone(), bool cancelOnError}) {
|
||||
return controller.stream.listen(onData,
|
||||
return _controller.stream.listen(onData,
|
||||
onError: onError, onDone: onDone, cancelOnError: cancelOnError);
|
||||
}
|
||||
|
||||
@ -387,6 +932,15 @@ class MockStdin extends Mock implements io.Stdin {
|
||||
{Encoding encoding = io.systemEncoding,
|
||||
bool retainNewlines = false}) =>
|
||||
readLineOutput;
|
||||
|
||||
void _addUserInputsToSteam(List<int> input) => _controller.add(input);
|
||||
}
|
||||
|
||||
class MockProcessResult extends Mock implements io.ProcessResult {}
|
||||
class MockProcessResult extends Mock implements io.ProcessResult {
|
||||
MockProcessResult({int exitCode = 0}) : _exitCode = exitCode;
|
||||
|
||||
final int _exitCode;
|
||||
|
||||
@override
|
||||
int get exitCode => _exitCode;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user