flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-08-02 22:01:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

[google_maps_flutter] removed old overrides (#4679)

Browse Source 
Removed 2 overrides with the comment
```
// TODO(mklim): Remove this empty override once https://github.com/flutter/flutter/issues/40126 is fixed in stable.
```
As the issue was fixed in 2019

Related to https://github.com/flutter/flutter/issues/131791
This commit is contained in:
Mikhail
2023-08-11 20:12:27 -04:00
committed by GitHub
parent ea49db5093
commit 08080abd9c
3 changed files with 3 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md
View File

@ -1,5 +1,5 @@
## NEXT ## 2.4.16
* Removes old empty override methods.
* Fixes unawaited_futures violations. * Fixes unawaited_futures violations.
## 2.4.15 ## 2.4.15

14
packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java
View File

@ -604,20 +604,6 @@ final class GoogleMapController
googleMap.setOnMapLongClickListener(listener); googleMap.setOnMapLongClickListener(listener);
} }
// @Override
// The minimum supported version of Flutter doesn't have this method on the PlatformView interface, but the maximum
// does. This will override it when available even with the annotation commented out.
public void onInputConnectionLocked() {
// TODO(mklim): Remove this empty override once https://github.com/flutter/flutter/issues/40126 is fixed in stable.
}
// @Override
// The minimum supported version of Flutter doesn't have this method on the PlatformView interface, but the maximum
// does. This will override it when available even with the annotation commented out.
public void onInputConnectionUnlocked() {
// TODO(mklim): Remove this empty override once https://github.com/flutter/flutter/issues/40126 is fixed in stable.
}
// DefaultLifecycleObserver // DefaultLifecycleObserver
@Override @Override

2
packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml
View File

@ -2,7 +2,7 @@ name: google_maps_flutter_android
description: Android implementation of the google_maps_flutter plugin. description: Android implementation of the google_maps_flutter plugin.
repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_android repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
version: 2.4.15 version: 2.4.16
environment: environment:
sdk: ">=2.18.0 <4.0.0" sdk: ">=2.18.0 <4.0.0"