[webview_flutter] Make WebKitWebViewWidget unit tests stateless (#6228)

Browse Source

This eliminates the state in the Dart unit tests for this class, bringing it into alignment with https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#make-each-test-entirely-self-contained.
- `testController` is now returned by `buildWidget`, which clarifies and enforces that the variable can only be used after `buildWidget` is called
- All the mocks are now in a data object that is created via a `configureMocks` call in each test.

The latter will allow easily adjusting specific mocks in individual tests (vs having to create a new group that has an almost-identical duplicate of `setUp`, but with slight changes) which will be useful when adding macOS support, where the mock `WKWebView` will need to be a different class when testing macOS/iOS codepath divergence.

...

This commit is contained in:

stuartmorgan

2024-03-04 17:20:17 -05:00

committed by GitHub

parent 0625827707

commit 05f97df8d9

1 changed files with 341 additions and 208 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

549

packages/webview_flutter/webview_flutter_wkwebview/test/legacy/web_kit_webview_widget_test.dart

File diff suppressed because it is too large Load Diff